Skip to contentSkip to conversation

bitbake-user-manual: Document override :append, :prepend, :remove order

PATCH New Marek Vasut 1 participant 1 message Dec 18, 2022

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 bitbake-user-manual: Document override :append, :prepend, :remove order

The application order of override syntax :append, :prepend, :remove is inobvious and undocumented. The order does not match variable parse history, i.e. output of "bitbake -e", either.

Add note documenting the exact order in which :append, :prepend, :remove are applied to variable in lib/bb/data_smart.py getVarFlag(). Add note that this order does not match the variable parse history order. This is mostly to prevent others from running into this and scratching their heads, trying to find out what is going on.

---
Cc: Joshua Watt <[email protected]>
Cc: Martin Jansa <[email protected]>
Cc: Peter Kjellerstedt <[email protected]>
Cc: Quentin Schulz <[email protected]>
Cc: Richard Purdie <[email protected]>
---
V2: - Add RB from Quentin
- Mention un-remove implementation
- Reference :remove order in append/prepend override syntax
V3: - Reword the note per suggestion from Quentin
- Use explicit FOOREMOVE per suggestion from Peter
V4: - Rebase on latest bitbake, resend

---
 .../bitbake-user-manual-metadata.rst          | 26 +++++++++++++++++++
 1 file changed, 26 insertions(+)
doc/bitbake-user-manual/bitbake-user-manual-metadata.rst +26 -0
index b839e669..deb7afad 100644
@@ -319,6 +319,10 @@ The variable ``D`` becomes "dvaladditional data".
 
    You must control all spacing when you use the override syntax.
 
+.. note::
+
+   The overrides are applied in this order, ":append", ":prepend", ":remove".
+
 It is also possible to append and prepend to shell functions and
 BitBake-style Python functions. See the ":ref:`bitbake-user-manual/bitbake-user-manual-metadata:shell functions`" and ":ref:`bitbake-user-manual/bitbake-user-manual-metadata:bitbake-style python functions`"
 sections for examples.
@@ -352,6 +356,28 @@ The variable ``FOO`` becomes
 Like ":append" and ":prepend", ":remove" is applied at variable
 expansion time.
 
+.. note::
+
+   The overrides are applied in this order, ":append", ":prepend", ":remove".
+   This implies it is not possible to re-append previously removed strings.
+   However, one can undo a ":remove" by using an intermediate variable whose
+   content is passed to the ":remove" so that modifying the intermediate
+   variable equals to keeping the string in::
+
+     FOOREMOVE = "123 456 789"
+     FOO:remove = "${FOOREMOVE}"
+     ...
+     FOOREMOVE = "123 789"
+
+   This expands to ``FOO:remove = "123 789"``.
+
+.. note::
+
+   Override application order may not match variable parse history, i.e.
+   the output of ``bitbake -e`` may contain ":remove" before ":append",
+   but the result will be removed string, because ":remove" is handled
+   last.
+
 Override Style Operation Advantages
 -----------------------------------
 
Signature · 1 line
2.35.1