Skip to contentSkip to conversation

mm/slab: remove unused slab_early_init

PATCH In review [email protected] 3 participants 3 messages Dec 18, 2022 – Jan 2, 2023 Memory management

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mm/slab: remove unused slab_early_init

From: Gou Hao <[email protected]>

'slab_early_init' was introduced by 'commit e0a42726794f ("[PATCH] mm/slab.c: fix early init assumption")', this flag was used to prevent off-slab caches being created so early during bootup.

The only user of 'slab_early_init' was removed in 'commit
3217fd9bdf00 ("mm/slab: make criteria for off slab
determination robust and simple")'.

---
 mm/slab.c | 3 ---
 1 file changed, 3 deletions(-)
mm/slab.c +0 -3
index 7a269db050ee..ede1f29fd81c 100644
@@ -220,7 +220,6 @@ static inline void fixup_objfreelist_debug(struct kmem_cache *cachep,
 static inline void fixup_slab_list(struct kmem_cache *cachep,
 				struct kmem_cache_node *n, struct slab *slab,
 				void **list);
-static int slab_early_init = 1;
 
 #define INDEX_NODE kmalloc_index(sizeof(struct kmem_cache_node))
 
@@ -1249,8 +1248,6 @@ void __init kmem_cache_init(void)
 	slab_state = PARTIAL_NODE;
 	setup_kmalloc_cache_index_table();
 
-	slab_early_init = 0;
-
 	/* 5) Replace the bootstrap kmem_cache_node */
 	{
 		int nid;
Signature · 1 line
2.20.1
Acked-by on v2 1/1
#1 lore raw
Quoted 7 lines · On Sun, 18 Dec 2022, [email protected] wrote:

From: Gou Hao <[email protected]>

'slab_early_init' was introduced by 'commit e0a42726794f ("[PATCH] mm/slab.c: fix early init assumption")', this flag was used to prevent off-slab caches being created so early during bootup.

Quoted 6 lines

The only user of 'slab_early_init' was removed in 'commit
3217fd9bdf00 ("mm/slab: make criteria for off slab
determination robust and simple")'.

#2 lore raw
In reply to [email protected]
Quoted 7 lines · On 12/18/22 13:31, [email protected] wrote:

From: Gou Hao <[email protected]>

'slab_early_init' was introduced by 'commit e0a42726794f ("[PATCH] mm/slab.c: fix early init assumption")', this flag was used to prevent off-slab caches being created so early during bootup.

Quoted 6 lines

The only user of 'slab_early_init' was removed in 'commit
3217fd9bdf00 ("mm/slab: make criteria for off slab
determination robust and simple")'.

Thanks, added to slab/for-6.3/cleanups

Quoted 25 lines
---
 mm/slab.c | 3 ---
 1 file changed, 3 deletions(-)
mm/slab.c +0 -3
index 7a269db050ee..ede1f29fd81c 100644
@@ -220,7 +220,6 @@ static inline void fixup_objfreelist_debug(struct kmem_cache *cachep,
 static inline void fixup_slab_list(struct kmem_cache *cachep,
 				struct kmem_cache_node *n, struct slab *slab,
 				void **list);
-static int slab_early_init = 1;
 
 #define INDEX_NODE kmalloc_index(sizeof(struct kmem_cache_node))
 
@@ -1249,8 +1248,6 @@ void __init kmem_cache_init(void)
 	slab_state = PARTIAL_NODE;
 	setup_kmalloc_cache_index_table();
 
-	slab_early_init = 0;
-
 	/* 5) Replace the bootstrap kmem_cache_node */
 	{
 		int nid;