Skip to contentSkip to conversation

mmc: sdhci-sprd: disable polling scan for sdio card

PATCH In review Wenchao Chen 2 participants 2 messages Dec 19, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: sdhci-sprd: disable polling scan for sdio card

Enable polling will increase the power consumption of the host.

Fixes fb8bd90f83c4 ("mmc: sdhci-sprd: Add Spreadtrum's initial host controller")
---
 drivers/mmc/host/sdhci-sprd.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/mmc/host/sdhci-sprd.c +4 -0
index 525f979e2a97..113a5c77578f 100644
@@ -696,6 +696,10 @@ static int sdhci_sprd_probe(struct platform_device *pdev)
 	if (ret)
 		goto err_cleanup_host;
 
+	if ((host->mmc->caps2 & MMC_CAP2_NO_SD) &&
+			(host->mmc->caps2 & MMC_CAP2_NO_MMC))
+		host->mmc->caps &= ~MMC_CAP_NEEDS_POLL;
+
 	pm_runtime_mark_last_busy(&pdev->dev);
 	pm_runtime_put_autosuspend(&pdev->dev);
 
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 13 lines · Wenchao Chen

Enable polling will increase the power consumption of the host.

Fixes fb8bd90f83c4 ("mmc: sdhci-sprd: Add Spreadtrum's initial host controller")
---
 drivers/mmc/host/sdhci-sprd.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/mmc/host/sdhci-sprd.c +0 -0
index 525f979e2a97..113a5c77578f 100644

drivers/mmc/host/sdhci-sprd.c static int sdhci_sprd_probe(struct platform_device *pdev) · line 701

Quoted 6 lines
drivers/mmc/host/sdhci-sprd.c +3 -0
@@ -696,6 +696,10 @@ static int sdhci_sprd_probe(struct platform_device *pdev)
 	if (ret)
 		goto err_cleanup_host;
 
+	if ((host->mmc->caps2 & MMC_CAP2_NO_SD) &&
+			(host->mmc->caps2 & MMC_CAP2_NO_MMC))
+		host->mmc->caps &= ~MMC_CAP_NEEDS_POLL;

How is MMC_CAP_NEEDS_POLL getting set? SDHCI won't set it for non-removable cards. Is it removable?

Quoted 4 lines
drivers/mmc/host/sdhci-sprd.c +1 -0
+
 	pm_runtime_mark_last_busy(&pdev->dev);
 	pm_runtime_put_autosuspend(&pdev->dev);