dt-bindings: dma: fsl-mxs-dma: Convert MXS DMA to DT schema
Subsystems (3)
PATCH v2 1/1 dt-bindings: dma: fsl-mxs-dma: Convert MXS DMA to DT schema
Convert the MXS DMA binding to DT schema format using json-schema.
Drop "interrupt-names" property, since it is broken. The drivers/dma/mxs-dma.c in Linux kernel does not use it, the property contains duplicate array entries in existing DTs, and even malformed entries (gmpi, should have been gpmi). Get rid of that optional property altogether.
Update example node names to be standard dma-controller@ , add global interrupt-parent property into example.
---
Cc: Fabio Estevam <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: Vinod Koul <[email protected]>
Cc: [email protected]
Cc: [email protected]
To: [email protected]
---
V2: - Drop -items:-enum: and use plain -enum:
- Fill in blank line between maxItems:8 and if:
- Move not: past if:
- Drop the entire allOf section except ref dma-controller.yaml
--- .../devicetree/bindings/dma/fsl,mxs-dma.yaml | 80 +++++++++++++++++++ .../devicetree/bindings/dma/fsl-mxs-dma.txt | 60 -------------- 2 files changed, 80 insertions(+), 60 deletions(-) create mode 100644 Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml delete mode 100644 Documentation/devicetree/bindings/dma/fsl-mxs-dma.txt
Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml new file +80 -0
@@ -0,0 +1,80 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/dma/fsl,mxs-dma.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Freescale Direct Memory Access (DMA) Controller from i.MX23/i.MX28 + +maintainers: + - Marek Vasut <[email protected]> + +allOf: + - $ref: dma-controller.yaml# + +properties: + compatible: + oneOf: + - items: + - enum: + - fsl,imx6q-dma-apbh + - fsl,imx6sx-dma-apbh + - fsl,imx7d-dma-apbh + - const: fsl,imx28-dma-apbh + - enum: + - fsl,imx23-dma-apbh + - fsl,imx23-dma-apbx + - fsl,imx28-dma-apbh + - fsl,imx28-dma-apbx + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + interrupts: + minItems: 4 + maxItems: 16 + + "#dma-cells": + const: 1 + + dma-channels: + enum: [4, 8, 16] + +required: + - compatible + - reg + - "#dma-cells" + - dma-channels + - interrupts + +additionalProperties: false + +examples: + - | + interrupt-parent = <&irqc>; + + dma-controller@80004000 { + compatible = "fsl,imx28-dma-apbh"; + reg = <0x80004000 0x2000>; + interrupts = <82 83 84 85 + 88 88 88 88 + 88 88 88 88 + 87 86 0 0>; + #dma-cells = <1>; + dma-channels = <16>; + }; + + dma-controller@80024000 { + compatible = "fsl,imx28-dma-apbx"; + reg = <0x80024000 0x2000>; + interrupts = <78 79 66 0 + 80 81 68 69 + 70 71 72 73 + 74 75 76 77>; + #dma-cells = <1>; + dma-channels = <16>; + }; + +...
Documentation/devicetree/bindings/dma/fsl-mxs-dma.txt deleted +0 -60
60 lines not on this page · raw message
Signature · 1 line
2.35.1
Quoted 11 lines · Marek Vasut
Convert the MXS DMA binding to DT schema format using json-schema.
Drop "interrupt-names" property, since it is broken. The
drivers/dma/mxs-dma.cin Linux kernel does not use it, the property contains duplicate array entries in existing DTs, and even malformed entries (gmpi, should have been gpmi). Get rid of that optional property altogether.Update example node names to be standard dma-controller@ , add global interrupt-parent property into example.
Signed-off-by Marek Vasut <[email protected]>
Best regards,
Krzysztof
Quoted 9 lines · Marek Vasut
Convert the MXS DMA binding to DT schema format using json-schema.
Drop "interrupt-names" property, since it is broken. The
drivers/dma/mxs-dma.cin Linux kernel does not use it, the property contains duplicate array entries in existing DTs, and even malformed entries (gmpi, should have been gpmi). Get rid of that optional property altogether.Update example node names to be standard dma-controller@ , add global interrupt-parent property into example.
Applied, thanks
Signature · 1 line
~Vinod