Skip to contentSkip to conversation

regulator: dt-bindings: Convert Fairchild FAN53555 to DT schema

PATCH Superseded Rob Herring 2 participants 4 messages Dec 19, 2022 – Jan 9, 2023

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 regulator: dt-bindings: Convert Fairchild FAN53555 to DT schema

Convert the Fairchild FAN53555 and compatible variants binding to DT schema format.

The example was missing 'reg', so add it.

---
 .../bindings/regulator/fan53555.txt           | 24 --------
 .../bindings/regulator/fcs,fan53555.yaml      | 59 +++++++++++++++++++
 2 files changed, 59 insertions(+), 24 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/regulator/fan53555.txt
 create mode 100644 Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml
Documentation/devicetree/bindings/regulator/fan53555.txt deleted +0 -24
deleted file mode 100644
index 013f096ac0aa..000000000000
@@ -1,24 +0,0 @@
-Binding for Fairchild FAN53555 regulators
-
-Required properties:
-  - compatible: one of "fcs,fan53555", "fcs,fan53526", "silergy,syr827",
-		"silergy,syr828" or "tcs,tcs4525".
-  - reg: I2C address
-
-Optional properties:
-  - fcs,suspend-voltage-selector: declare which of the two available
-		voltage selector registers should be used for the suspend
-		voltage. The other one is used for the runtime voltage setting
-		Possible values are either <0> or <1>
-  - vin-supply: regulator supplying the vin pin
-
-Example:
-
-	regulator@40 {
-		compatible = "fcs,fan53555";
-		regulator-name = "fan53555";
-		regulator-min-microvolt = <1000000>;
-		regulator-max-microvolt = <1800000>;
-		vin-supply = <&parent_reg>;
-		fcs,suspend-voltage-selector = <1>;
-	};
Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml new file +59 -0

59 lines not on this page · raw message

Signature · 1 line
2.35.1
author maintainer
#1 lore raw
Quoted 5 lines · Rob Herring

Convert the Fairchild FAN53555 and compatible variants binding to DT schema format.

The example was missing 'reg', so add it.

Quoted 8 lines
---
 .../bindings/regulator/fan53555.txt           | 24 --------
 .../bindings/regulator/fcs,fan53555.yaml      | 59 +++++++++++++++++++
 2 files changed, 59 insertions(+), 24 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/regulator/fan53555.txt
 create mode 100644 Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml

Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]

regulator@40: Unevaluated properties are not allowed ('regulator-compatible', 'vsel-gpios' were unexpected)

	arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dtb

regulator@40: Unevaluated properties are not allowed ('regulator-init-microvolt' was unexpected)

	arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dtb
	arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg503.dtb

regulator@41: Unevaluated properties are not allowed ('regulator-compatible', 'vsel-gpios' were unexpected)

	arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dtb

regulator@60: Unevaluated properties are not allowed ('vsel-gpios' was unexpected)
arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dtb arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dtb arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dtb

syr827@40: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)

	arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dtb

syr828@41: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)

	arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dtb
author maintainer
#2 lore raw
Quoted 20 lines · Rob Herring
Quoted 5 lines · Rob Herring

Convert the Fairchild FAN53555 and compatible variants binding to DT schema format.

The example was missing 'reg', so add it.

Quoted 8 lines
---
 .../bindings/regulator/fan53555.txt           | 24 --------
 .../bindings/regulator/fcs,fan53555.yaml      | 59 +++++++++++++++++++
 2 files changed, 59 insertions(+), 24 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/regulator/fan53555.txt
 create mode 100644 Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml

Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings.

Quoted 8 lines

Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]

regulator@40: Unevaluated properties are not allowed ('regulator-compatible', 'vsel-gpios' were unexpected)

	arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dtb

The h/w does have a VSEL pin, so I'll respin adding that.

Quoted 4 lines

regulator@40: Unevaluated properties are not allowed ('regulator-init-microvolt' was unexpected)

	arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dtb
	arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg503.dtb

Humm, not in the kernel. Seems u-boot has added some of their own properties...

Rob

maintainer
#3 lore raw
In reply to Rob Herring
Quoted 6 lines · Rob Herring

Convert the Fairchild FAN53555 and compatible variants binding to DT schema format.

The example was missing 'reg', so add it.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: dt-bindings: Convert Fairchild FAN53555 to DT schema

      commit: 6cea468b680e1254c7e8f95b70f4c3798985f05a

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark