Skip to contentSkip to conversation

kbuild: Optionally enable schema checks for %.dtb targets

PATCH In review Rob Herring 3 participants 3 messages Dec 20, 2022 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kbuild: Optionally enable schema checks for %.dtb targets

While not documented, schema checks for single dtb targets mostly work already by setting 'CHECK_DTBS=1'. However, the dependencies are not handled and it only works if 'make dt_bindings_check' was run first and generated processed-schema.json. In addition, changing a binding file doesn't cause the schema to be rebuilt and dtb to be revalidated.

Making this work turns out to be simple. Whenever CHECK_DTBS is set, make 'dt_binding_check' a 'dtbs_prepare' dependency.

I reimplemented here what Masahiro had originally come up with a while back.

Cc Marek Vasut <[email protected]>
Cc Dmitry Baryshkov <[email protected]>
---
 Makefile | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Makefile +4 -1
index 6aa709df6bde..a99d5c4de0fc 100644
@@ -1467,7 +1467,10 @@ dtbs_prepare: include/config/kernel.release scripts_dtc
 
 ifneq ($(filter dtbs_check, $(MAKECMDGOALS)),)
 export CHECK_DTBS=y
-dtbs: dt_binding_check
+endif
+
+ifneq ($(CHECK_DTBS),)
+dtbs_prepare: dt_binding_check
 endif
 
 dtbs_check: dtbs
Signature · 1 line
2.35.1
Tested-by on v1 1/1
#1 lore raw
Quoted 25 lines · Rob Herring

While not documented, schema checks for single dtb targets mostly work already by setting 'CHECK_DTBS=1'. However, the dependencies are not handled and it only works if 'make dt_bindings_check' was run first and generated processed-schema.json. In addition, changing a binding file doesn't cause the schema to be rebuilt and dtb to be revalidated.

Making this work turns out to be simple. Whenever CHECK_DTBS is set, make 'dt_binding_check' a 'dtbs_prepare' dependency.

I reimplemented here what Masahiro had originally come up with a while back.

Cc Marek Vasut <[email protected]>
Cc Dmitry Baryshkov <[email protected]>
---
  Makefile | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)
Makefile +0 -0
index 6aa709df6bde..a99d5c4de0fc 100644
@@ -1467,7 +1467,10 @@ dtbs_prepare: include/config/kernel.release scripts_dtc
 

Makefile dtbs_prepare: include/config/kernel.release scripts_dtc · line 1476

Quoted 10 lines
Makefile +4 -1
  ifneq ($(filter dtbs_check, $(MAKECMDGOALS)),)
  export CHECK_DTBS=y
-dtbs: dt_binding_check
+endif
+
+ifneq ($(CHECK_DTBS),)
+dtbs_prepare: dt_binding_check
  endif
 
  dtbs_check: dtbs

Thank you!

Acked-by Reviewed-by Dmitry Baryshkov Tested-by Dmitry Baryshkov on v1 1/1
#2 lore raw
In reply to Rob Herring
Quoted 7 lines · Rob Herring

While not documented, schema checks for single dtb targets mostly work already by setting 'CHECK_DTBS=1'. However, the dependencies are not handled and it only works if 'make dt_bindings_check' was run first and generated processed-schema.json. In addition, changing a binding file doesn't cause the schema to be rebuilt and dtb to be revalidated.

Quoted 5 lines

Making this work turns out to be simple. Whenever CHECK_DTBS is set, make 'dt_binding_check' a 'dtbs_prepare' dependency.

I reimplemented here what Masahiro had originally come up with a while back.

Oh, I just recalled this patch.

https://lore.kernel.org/all/CAA8EJprdCftvie3UF9QpCWr9oQ5SQbqW8OPOHg0qigf9=RXU-w@mail.gmail.com/T/#m2ce6b1de3c74333645831399c0d1775129d7661a

Dritry tested it.

Quoted 25 lines
Cc Marek Vasut <[email protected]>
Cc Dmitry Baryshkov <[email protected]>
---
 Makefile | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Makefile +4 -2
index 6aa709df6bde..a99d5c4de0fc 100644
@@ -1467,7 +1467,10 @@ dtbs_prepare: include/config/kernel.release scripts_dtc
 
 ifneq ($(filter dtbs_check, $(MAKECMDGOALS)),)
 export CHECK_DTBS=y
-dtbs: dt_binding_check
+endif
+
+ifneq ($(CHECK_DTBS),)
+dtbs_prepare: dt_binding_check
 endif
 
 dtbs_check: dtbs
--
Quoted 2 lines

2.35.1

--
Best Regards
Masahiro Yamada