incremental, manage: do not verify if remove is safe
PATCH 1/1 incremental, manage: do not verify if remove is safe
Function is_remove_safe() was introduced to verify if removing member device won't cause failed state of the array. This verification should be used only with set-faulty command. Add special mode indicating that Incremental removal was executed. If this mode is used do not execute is_remove_safe() routine.
Signed-off-by Kinga Tanska <[email protected]>
--- Incremental.c | 2 +- Manage.c | 79 +++++++++++++++++++++++++++++++-------------------- 2 files changed, 49 insertions(+), 32 deletions(-)
Incremental.c +1 -1
@@ -1744,7 +1744,7 @@ int IncrementalRemove(char *devname, char *id_path, int verbose)memset (&devlist,0 ,sizeof (devlist)); devlist.devname = devname; - devlist.disposition ='f' ; + devlist.disposition ='I' ;/* for a container, we must fail each member array */ if (ent->metadata_version &&strncmp (ent->metadata_version,"external:" ,9 ) ==0 ) {
Manage.c +48 -31
101 lines not on this page · raw message
Signature · 1 line
2.26.2
Dear Kinga,
Thank you for your patch.
Am 20.12.22 um 04:21 schrieb Kinga Tanska:
[…]
Quoted 66 lines
Manage.c +44
-18+/** +* Manage_subdevs() - Execute operation depending on devmode. +* +* @devname: name of the device. +* @fd: file descriptor. +* @devlist: list of sub-devices to manage. +* @verbose: verbose level. +* @test: test flag. +* @update: type of update. +* @force: force flag. +* +* This function executes operation defined by devmode +* for each dev from devlist. +* Devmode can be: +* 'a' - add the device +* 'S' - add the device as a spare - don't try re-add +* 'j' - add the device as a journal device +* 'A' - re-add the device +* 'r' - remove the device: HOT_REMOVE_DISK +* device can be 'faulty' or 'detached' in which case all +* matching devices are removed. +* 'f' - set the device faulty SET_DISK_FAULTY +* device can be 'detached' in which case any device that +* is inaccessible will be marked faulty. +* 'I' - remove device by using incremental fail +* which is executed when device is removed surprisingly. +* 'R' - mark this device as wanting replacement. +* 'W' - this device is added if necessary and activated as +* a replacement for a previous 'R' device. +* ----- +* 'w' - 'W' will be changed to 'w' when it is paired with +* a 'R' device. If a 'W' is found while walking the list +* it must be unpaired, and is an error. +* 'M' - this is created by a 'missing' target. It is a slight +* variant on 'A' +* 'F' - Another variant of 'A', where the device was faulty +* so must be removed from the array first. +* 'c' - confirm the device as found (for clustered environments) +* +* For 'f' and 'r', the device can also be a kernel-internal +* name such as 'sdb'. +* +* Return: 0 on success, otherwise 1 or 2. +*/ int Manage_subdevs (char *devname,int fd,struct mddev_dev *devlist,int verbose,int test,char *update,int force) { -/* Do something to each dev. -* devmode can be -* 'a' - add the device -* 'S' - add the device as a spare - don't try re-add -* 'j' - add the device as a journal device -* 'A' - re-add the device -* 'r' - remove the device: HOT_REMOVE_DISK -* device can be 'faulty' or 'detached' in which case all -* matching devices are removed. -* 'f' - set the device faulty SET_DISK_FAULTY -* device can be 'detached' in which case any device that -* is inaccessible will be marked faulty. -* 'R' - mark this device as wanting replacement. -* 'W' - this device is added if necessary and activated as -* a replacement for a previous 'R' device. -* ----- -* 'w' - 'W' will be changed to 'w' when it is paired with -* a 'R' device. If a 'W' is found while walking the list
Manage.c bool is_remove_safe(mdu_array_info_t *array, const int fd, char *devname, const · line 1363
Quoted 10 lines
Manage.c +0
-10-* it must be unpaired, and is an error. -* 'M' - this is created by a 'missing' target. It is a slight -* variant on 'A' -* 'F' - Another variant of 'A', where the device was faulty -* so must be removed from the array first. -* 'c' - confirm the device as found (for clustered environments) -* -* For 'f' and 'r', the device can also be a kernel-internal -* name such as 'sdb'. -*/
Please move the comment in a separate commit.
Kind regards,
Paul