Skip to contentSkip to conversation

PCI: endpoint: Fix potential double free in __pci_epc_create

PATCH In review Miaoqian Lin 2 participants 2 messages Dec 20, 2022 – Apr 8, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: endpoint: Fix potential double free in __pci_epc_create

When all references are dropped, callback function pci_epc_release() for put_device() already call kfree(epc) to release memory. Remove abundant kfree to fix double free.

Fixes 7711cbb4862a ("PCI: endpoint: Fix WARN() when an endpoint driver is removed")
---
 drivers/pci/endpoint/pci-epc-core.c | 2 --
 1 file changed, 2 deletions(-)
drivers/pci/endpoint/pci-epc-core.c +0 -2
index 2542196e8c3d..7dc640c99d9a 100644
@@ -800,8 +800,6 @@ __pci_epc_create(struct device *dev, const struct pci_epc_ops *ops,
 
 put_dev:
 	put_device(&epc->dev);
-	kfree(epc);
-
 err_ret:
 	return ERR_PTR(ret);
 }
Signature · 1 line
2.25.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Miaoqian Lin

When all references are dropped, callback function pci_epc_release() for put_device() already call kfree(epc) to release memory. Remove abundant kfree to fix double free.

Fixes 7711cbb4862a ("PCI: endpoint: Fix WARN() when an endpoint driver is removed")

- Mani

Quoted 20 lines
---
 drivers/pci/endpoint/pci-epc-core.c | 2 --
 1 file changed, 2 deletions(-)
drivers/pci/endpoint/pci-epc-core.c +0 -2
index 2542196e8c3d..7dc640c99d9a 100644
@@ -800,8 +800,6 @@ __pci_epc_create(struct device *dev, const struct pci_epc_ops *ops,
 
 put_dev:
 	put_device(&epc->dev);
-	kfree(epc);
-
 err_ret:
 	return ERR_PTR(ret);
 }
Signature · 1 line
2.25.1
Signature · 1 line
மணிவண்ணன் சதாசிவம்