package/libgpg-error: Disable unused files installation
PATCH v2 1/1 package/libgpg-error: Disable unused files installation
Disable a number of unused files that were being installed into the root filesystem and thus inflating its size needlessly:
* Disable the building of documentation
* Disable support for other languages which is comprised of Common Lisp that buildroot has no package for
* Only install binaries and shared/static libraries, remove libtool archive
---
Changes in v2:
- remove header files, pkgconfig and other unnecessary files
package/libgpg-error/libgpg-error.mk | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
package/libgpg-error/libgpg-error.mk +8 -1
@@ -14,7 +14,9 @@ LIBGPG_ERROR_INSTALL_STAGING = YES LIBGPG_ERROR_CONFIG_SCRIPTS = gpg-error-config LIBGPG_ERROR_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES) LIBGPG_ERROR_CONF_OPTS = --disable-tests \ - --host=$(BR2_PACKAGE_LIBGPG_ERROR_SYSCFG) + --host=$(BR2_PACKAGE_LIBGPG_ERROR_SYSCFG) \ + --disable-languages \ + --disable-doc ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y) LIBGPG_ERROR_CONF_OPTS += --enable-threads
@@ -22,4 +24,9 @@ else LIBGPG_ERROR_CONF_OPTS += --disable-threads endif +define LIBGPG_ERROR_INSTALL_TARGET_CMDS + $(MAKE) -C $(@D) DESTDIR="$(TARGET_DIR)" install-exec + rm -f $(TARGET_DIR)/usr/lib/libgpg-error.la +endef + $(eval $(autotools-package))
Signature · 6 lines
2.34.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Hi Florian,
Quoted 24 lines · Florian Fainelli
Disable a number of unused files that were being installed into the root filesystem and thus inflating its size needlessly:
* Disable the building of documentation
* Disable support for other languages which is comprised of Common Lisp that buildroot has no package for
* Only install binaries and shared/static libraries, remove libtool archive
Signed-off-by Florian Fainelli <[email protected]>---
Changes in v2:- remove header files, pkgconfig and other unnecessary files
package/libgpg-error/libgpg-error.mk | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)package/libgpg-error/libgpg-error.mk +0
-0
package/libgpg-error/libgpg-error.mk LIBGPG_ERROR_INSTALL_STAGING = YES · line 19
Quoted 7 lines
package/libgpg-error/libgpg-error.mk +3
-1@@ -14,7 +14,9 @@ LIBGPG_ERROR_INSTALL_STAGING = YES LIBGPG_ERROR_CONFIG_SCRIPTS = gpg-error-config LIBGPG_ERROR_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES) LIBGPG_ERROR_CONF_OPTS = --disable-tests \ - --host=$(BR2_PACKAGE_LIBGPG_ERROR_SYSCFG) + --host=$(BR2_PACKAGE_LIBGPG_ERROR_SYSCFG) \ + --disable-languages \ + --disable-doc
This is part of default _CONFIGURE_CMDS for autotools packages. See package/pkg-autotools.mk.
package/libgpg-error/libgpg-error.mk else · line 29
Quoted 9 lines
package/libgpg-error/libgpg-error.mk +3
-0ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y) LIBGPG_ERROR_CONF_OPTS += --enable-threads@@ -22,4 +24,9 @@ else LIBGPG_ERROR_CONF_OPTS += --disable-threads endif +define LIBGPG_ERROR_INSTALL_TARGET_CMDS + $(MAKE) -C $(@D) DESTDIR="$(TARGET_DIR)" install-exec + rm -f $(TARGET_DIR)/usr/lib/libgpg-error.la
The target-finalize target in top Makefile should remove .la files:
find $(TARGET_DIR)/lib/ $(TARGET_DIR)/usr/lib/ $(TARGET_DIR)/usr/libexec/ \
\( -name '*.a' -o -name '*.la' -o -name '*.prl' \) -print0 | xargs -0 rm -fDoesn't that work for you?
baruch
Quoted 3 lines
package/libgpg-error/libgpg-error.mk +2
-0+endef + $(eval $(autotools-package))
Signature · 7 lines
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- [email protected] - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildrootFlorian, All,
On 2022-12-19 15:08 -0800, Florian Fainelli spake thusly:
Quoted 9 lines
Disable a number of unused files that were being installed into the root filesystem and thus inflating its size needlessly:
* Disable the building of documentation
* Disable support for other languages which is comprised of Common Lisp that buildroot has no package for
* Only install binaries and shared/static libraries, remove libtool archive
As Baruch mentioned in his review, disabling the documentation and removing headers and libtool archives whould already be handled by the package infra.
So I applied your v1 instead, and makred this one rejected.
Regards,
Yann E. MORIN.
Quoted 37 lines
Signed-off-by Florian Fainelli <[email protected]>---
Changes in v2:- remove header files, pkgconfig and other unnecessary files
package/libgpg-error/libgpg-error.mk | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)package/libgpg-error/libgpg-error.mk +8
-1@@ -14,7 +14,9 @@ LIBGPG_ERROR_INSTALL_STAGING = YES LIBGPG_ERROR_CONFIG_SCRIPTS = gpg-error-config LIBGPG_ERROR_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES) LIBGPG_ERROR_CONF_OPTS = --disable-tests \ - --host=$(BR2_PACKAGE_LIBGPG_ERROR_SYSCFG) + --host=$(BR2_PACKAGE_LIBGPG_ERROR_SYSCFG) \ + --disable-languages \ + --disable-doc ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y) LIBGPG_ERROR_CONF_OPTS += --enable-threads@@ -22,4 +24,9 @@ else LIBGPG_ERROR_CONF_OPTS += --disable-threads endif +define LIBGPG_ERROR_INSTALL_TARGET_CMDS + $(MAKE) -C $(@D) DESTDIR="$(TARGET_DIR)" install-exec + rm -f $(TARGET_DIR)/usr/lib/libgpg-error.la +endef + $(eval $(autotools-package))Signature · 1 line
2.34.1
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 8 lines · Yann E. MORIN
Florian, All,
On 2022-12-19 15:08 -0800, Florian Fainelli spake thusly:
Quoted 5 lines
Disable a number of unused files that were being installed into the root filesystem and thus inflating its size needlessly:
* Disable the building of documentation
Quoted 8 lines
Quoted 4 lines
* Disable support for other languages which is comprised of Common Lisp that buildroot has no package for
* Only install binaries and shared/static libraries, remove libtool archive
As Baruch mentioned in his review, disabling the documentation and removing headers and libtool archives whould already be handled by the package infra.
It does, I was looking at the target/ folder instead of the actual root filesystem, my bad, thanks and happy holidays.
Signature · 6 lines
Florian _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot