RDMA/hns: Fix refcount leak in hns_roce_mmap
Subsystems (2)
PATCH 1/1 RDMA/hns: Fix refcount leak in hns_roce_mmap
rdma_user_mmap_entry_get_pgoff() takes reference.
Add missing rdma_user_mmap_entry_put() to release the reference.
Fixes 0045e0d3f42e ("RDMA/hns: Support direct wqe of userspace")
Signed-off-by Miaoqian Lin <[email protected]>
--- drivers/infiniband/hw/hns/hns_roce_main.c | 1 + 1 file changed, 1 insertion(+)
drivers/infiniband/hw/hns/hns_roce_main.c +1 -0
@@ -443,6 +443,7 @@ static int hns_roce_mmap(struct ib_ucontext *uctx, struct vm_area_struct *vma) prot =pgprot_device (vma->vm_page_prot);break ;default : +rdma_user_mmap_entry_put (rdma_entry);return -EINVAL ; }
Signature · 1 line
2.25.1
Thank you. This patch is right. Could you change it to this form?
default: ret = -EINVAL; goto out; } ret = rdma_user_mmap_io(uctx, vma, pfn, rdma_entry->npages * PAGE_SIZE, prot, rdma_entry); out: rdma_user_mmap_entry_put(rdma_entry); return ret;
Quoted 22 lines · Miaoqian Lin
rdma_user_mmap_entry_get_pgoff()takes reference.
Add missingrdma_user_mmap_entry_put()to release the reference.Fixes 0045e0d3f42e ("RDMA/hns: Support direct wqe of userspace")Signed-off-by Miaoqian Lin <[email protected]>--- drivers/infiniband/hw/hns/hns_roce_main.c | 1 + 1 file changed, 1 insertion(+)drivers/infiniband/hw/hns/hns_roce_main.c +1
-0@@ -443,6 +443,7 @@ static int hns_roce_mmap(struct ib_ucontext *uctx, struct vm_area_struct *vma) prot =pgprot_device (vma->vm_page_prot);break ;default : +rdma_user_mmap_entry_put (rdma_entry);return -EINVAL ; }