Skip to contentSkip to conversation

f2fs: update comment about f2fs_issue_discard_timeout()

PATCH In review Yangtao Li 2 participants 2 messages Dec 20, 2022 – Jan 11, 2023 F2FS file system

lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH 1/1 f2fs: update comment about f2fs_issue_discard_timeout()

After commit 4d67490498ac ("f2fs: Don't create discard thread when device doesn't support realtime discard"), f2fs_issue_discard_timeout() is not only called by f2fs_put_super().

Let's update it.

---
 fs/f2fs/segment.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/f2fs/segment.c +1 -1
index af2d522b1a89..fd3b16f68ffc 100644
@@ -1654,7 +1654,7 @@ void f2fs_stop_discard_thread(struct f2fs_sb_info *sbi)
 	}
 }
 
-/* This comes from f2fs_put_super */
+/* This comes from f2fs_put_super() and f2fs_remount() */
 bool f2fs_issue_discard_timeout(struct f2fs_sb_info *sbi)
 {
 	struct discard_cmd_control *dcc = SM_I(sbi)->dcc_info;
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 3 lines · Yangtao Li

After commit 4d67490498ac ("f2fs: Don't create discard thread when device doesn't support realtime discard"), f2fs_issue_discard_timeout() is not only called by f2fs_put_super().

Actually, it also comes from error path of fill_super().

We don't need to update this comments all the time, how about removing this since it's trivial.

Thanks,

Quoted 2 lines

Let's update it.

_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel