Grow: fix possible memory leak
PATCH v2 1/1 Grow: fix possible memory leak
In function Grow_addbitmap, struct mdinfo may be allocated but is not freed
in few exit paths. Add free 'mdi' variable in missing exit paths to avoid possible memory leak.
Signed-off-by Blazej Kucman <[email protected]>
--- Grow.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Grow.c +4 -1
@@ -432,6 +432,7 @@ int Grow_addbitmap(char *devname, int fd, struct context *c, struct shape *s)if (((disk.state & (1 <<MD_DISK_WRITEMOSTLY )) ==0 ) && (strcmp (s->bitmap_file,"clustered" ) ==0 )) {pr_err ("%s disks marked write-mostly are not supported with clustered bitmap\n" ,devname); +free (mdi);return 1 ; } fd2 =dev_open (dv,O_RDWR );
@@ -453,8 +454,10 @@ int Grow_addbitmap(char *devname, int fd, struct context *c, struct shape *s)pr_err ("failed to load super-block.\n" ); }close (fd2); -if (rv) +if (rv) { +free (mdi);return 1 ; + } }if (offset_setable) { st->ss->getinfo_super (st, mdi,NULL );
Signature · 1 line
2.35.3
Jes Sorensen
AppliedQuoted 9 lines · Blazej Kucman
In function
Grow_addbitmap, struct mdinfo may be allocated but is not freed
in few exit paths. Add free 'mdi' variable in missing exit paths to avoid possible memory leak.Signed-off-by Blazej Kucman <[email protected]>--- Grow.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Applied!
Thanks,
Jes