Skip to contentSkip to conversation

ASoC: Intel: fix sof-nau8825 link failure

PATCH In review Arnd Bergmann 3 participants 3 messages Dec 21, 2022 – Dec 26, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: Intel: fix sof-nau8825 link failure

From: Arnd Bergmann <[email protected]>

The snd-soc-sof_nau8825.ko module fails to link unless the sof_realtek_common support is also enabled:

ERROR: modpost: "sof_rt1015p_codec_conf" [sound/soc/intel/boards/snd-soc-sof_nau8825.ko] undefined!
ERROR: modpost: "sof_rt1015p_dai_link" [sound/soc/intel/boards/snd-soc-sof_nau8825.ko] undefined!

Fixes 8d0872f6239f ("ASoC: Intel: add sof-nau8825 machine driver")
---
 sound/soc/intel/boards/Kconfig | 1 +
 1 file changed, 1 insertion(+)
sound/soc/intel/boards/Kconfig +1 -0
index a472de1909f4..9aee729c2406 100644
@@ -558,6 +558,7 @@ config SND_SOC_INTEL_SOF_NAU8825_MACH
 	select SND_SOC_HDAC_HDMI
 	select SND_SOC_INTEL_HDA_DSP_COMMON
 	select SND_SOC_INTEL_SOF_MAXIM_COMMON
+	select SND_SOC_INTEL_SOF_REALTEK_COMMON
 	help
 	   This adds support for ASoC machine driver for SOF platforms
 	   with nau8825 codec.
Signature · 1 line
2.35.1
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The snd-soc-sof_nau8825.ko module fails to link unless the sof_realtek_common support is also enabled:

ERROR: modpost: "sof_rt1015p_codec_conf" [sound/soc/intel/boards/snd-soc-sof_nau8825.ko] undefined!
ERROR: modpost: "sof_rt1015p_dai_link" [sound/soc/intel/boards/snd-soc-sof_nau8825.ko] undefined!

Fixes 8d0872f6239f ("ASoC: Intel: add sof-nau8825 machine driver")

Thanks!

Quoted 16 lines
---
 sound/soc/intel/boards/Kconfig | 1 +
 1 file changed, 1 insertion(+)
sound/soc/intel/boards/Kconfig +1 -0
index a472de1909f4..9aee729c2406 100644
@@ -558,6 +558,7 @@ config SND_SOC_INTEL_SOF_NAU8825_MACH
 	select SND_SOC_HDAC_HDMI
 	select SND_SOC_INTEL_HDA_DSP_COMMON
 	select SND_SOC_INTEL_SOF_MAXIM_COMMON
+	select SND_SOC_INTEL_SOF_REALTEK_COMMON
 	help
 	   This adds support for ASoC machine driver for SOF platforms
 	   with nau8825 codec.
maintainer
#2 lore raw
In reply to Arnd Bergmann
Quoted 8 lines · Arnd Bergmann

The snd-soc-sof_nau8825.ko module fails to link unless the sof_realtek_common support is also enabled:

ERROR: modpost: "sof_rt1015p_codec_conf" [sound/soc/intel/boards/snd-soc-sof_nau8825.ko] undefined!
ERROR: modpost: "sof_rt1015p_dai_link" [sound/soc/intel/boards/snd-soc-sof_nau8825.ko] undefined!

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: Intel: fix sof-nau8825 link failure

      commit: 63f3d99b7efe4c5404a9388c05780917099cecf4

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark