Skip to contentSkip to conversation

virt-viewer: add opengl to REQUIRED_DISTRO_FEATURES

PATCH In review [email protected] 2 participants 2 messages Dec 20, 2022 – Dec 22, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virt-viewer: add opengl to REQUIRED_DISTRO_FEATURES

From: Mingli Yu <[email protected]>

Fixes:
ERROR: Nothing PROVIDES 'spice-gtk' (but /build/layers/meta-virtualization/recipes-extended/virt-viewer/virt-viewer_11.0.bb DEPENDS on or otherwise requires it)
spice-gtk was skipped: missing required distro feature 'opengl' (not in DISTRO_FEATURES)
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'virt-viewer', 'spice-gtk']

---
 recipes-extended/virt-viewer/virt-viewer_11.0.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
recipes-extended/virt-viewer/virt-viewer_11.0.bb +3 -1
index 55ca57aa..5799f48f 100644
@@ -16,6 +16,8 @@ SRCREV = "1e99e5e4f409da91638eb79067ec738994c28ef5"
 PV = "11.0+git${SRCPV}"
 S = "${WORKDIR}/git"
 
+REQUIRED_DISTRO_FEATURES = "opengl"
+
 PACKAGECONFIG ?= "libvirt spice vte"
 
 PACKAGECONFIG[libvirt] = "-Dlibvirt=enabled,-Dlibvirt=disabled,libvirt libvirt-glib"
@@ -23,7 +25,7 @@ PACKAGECONFIG[spice] = "-Dspice=enabled,-Dspice=disabled,spice-gtk spice-protoco
 PACKAGECONFIG[vnc] = "-Dvnc=enabled,-Dvnc=disabled,gtk-vnc"
 PACKAGECONFIG[vte] = "-Dvte=enabled,-Dvte=disabled,vte"
 
-inherit meson pkgconfig gtk-icon-cache mime mime-xdg gobject-introspection
+inherit meson pkgconfig gtk-icon-cache mime mime-xdg gobject-introspection features_check
 
 FILES:${PN} += "${datadir}"
 GIR_MESON_OPTION = ''
Signature · 1 line
2.25.1
#1 lore raw

merged.

Bruce

In message: [PATCH] virt-viewer: add opengl to REQUIRED_DISTRO_FEATURES

Quoted 38 lines · on 20/12/2022 [email protected] wrote:

From: Mingli Yu <[email protected]>

Fixes:
ERROR: Nothing PROVIDES 'spice-gtk' (but /build/layers/meta-virtualization/recipes-extended/virt-viewer/virt-viewer_11.0.bb DEPENDS on or otherwise requires it)
spice-gtk was skipped: missing required distro feature 'opengl' (not in DISTRO_FEATURES)
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'virt-viewer', 'spice-gtk']

---
 recipes-extended/virt-viewer/virt-viewer_11.0.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
recipes-extended/virt-viewer/virt-viewer_11.0.bb +3 -1
index 55ca57aa..5799f48f 100644
@@ -16,6 +16,8 @@ SRCREV = "1e99e5e4f409da91638eb79067ec738994c28ef5"
 PV = "11.0+git${SRCPV}"
 S = "${WORKDIR}/git"
 
+REQUIRED_DISTRO_FEATURES = "opengl"
+
 PACKAGECONFIG ?= "libvirt spice vte"
 
 PACKAGECONFIG[libvirt] = "-Dlibvirt=enabled,-Dlibvirt=disabled,libvirt libvirt-glib"
@@ -23,7 +25,7 @@ PACKAGECONFIG[spice] = "-Dspice=enabled,-Dspice=disabled,spice-gtk spice-protoco
 PACKAGECONFIG[vnc] = "-Dvnc=enabled,-Dvnc=disabled,gtk-vnc"
 PACKAGECONFIG[vte] = "-Dvte=enabled,-Dvte=disabled,vte"
 
-inherit meson pkgconfig gtk-icon-cache mime mime-xdg gobject-introspection
+inherit meson pkgconfig gtk-icon-cache mime mime-xdg gobject-introspection features_check
 
 FILES:${PN} += "${datadir}"
 GIR_MESON_OPTION = ''
Signature · 1 line
2.25.1