Skip to contentSkip to conversation

of: base: use strscpy() to instead of strncpy()

PATCH Applied [email protected] 2 participants 2 messages Dec 23, 2022 – Jan 4, 2023 Device tree

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 of: base: use strscpy() to instead of strncpy()

From: Xu Panda <[email protected]>

The implementation of strscpy() is more robust and safer. That's now the recommended way to copy NUL terminated strings.

Signed-off-by Xu Panda <[email protected]>
Signed-off-by Yang Yang <[email protected]>
---
 drivers/of/base.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/of/base.c +1 -2
index d5a5c35eba72..ac6fde53342f 100644
@@ -1884,8 +1884,7 @@ static void of_alias_add(struct alias_prop *ap, struct device_node *np,
 {
 	ap->np = np;
 	ap->id = id;
-	strncpy(ap->stem, stem, stem_len);
-	ap->stem[stem_len] = 0;
+	strscpy(ap->stem, stem, stem_len + 1);
 	list_add_tail(&ap->link, &aliases_lookup);
 	pr_debug("adding DT alias:%s: stem=%s id=%i node=%pOF\n",
 		 ap->alias, ap->stem, ap->id, np);
Signature · 1 line
2.15.2