wl1251: use strscpy() to instead of strncpy()
Subsystems (3)
PATCH 1/1 wl1251: use strscpy() to instead of strncpy()
From: Xu Panda <[email protected]>
The implementation of strscpy() is more robust and safer. That's now the recommended way to copy NUL-terminated strings.
Signed-off-by Xu Panda <[email protected]>
Signed-off-by Yang Yang <[email protected]>
--- drivers/net/wireless/ti/wl1251/acx.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)
drivers/net/wireless/ti/wl1251/acx.c +1 -8
@@ -150,14 +150,7 @@ int wl1251_acx_fw_version(struct wl1251 *wl, char *buf, size_t len) }/* be careful with the buffer sizes */ -strncpy (buf, rev->fw_version,min (len,sizeof (rev->fw_version))); - -/* -* if the firmware version string is exactly -* sizeof(rev->fw_version) long or fw_len is less than -* sizeof(rev->fw_version) it won't be null terminated -*/ - buf[min (len,sizeof (rev->fw_version)) -1 ] ='\0' ; +strscpy (buf, rev->fw_version, len); out:kfree (rev);
Signature · 1 line
2.15.2