arm64: dts: qcom: c630: set venus firmware name
PATCH 26/26 arm64: dts: qcom: c630: set venus firmware name
The Lenovo Yoga C630 can't use the generic venus firmware that is in the linux-firmware repository, and needs a signed one. This file is qcvss850.mbn from the Windows partition and needs to be copied manually.
--- arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 1 + 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts +1 -0
@@ -801,6 +801,7 @@ &usb_2_qmpphy { }; &venus { + firmware-name = "qcom/venus-5.2/qcvss850.mbn"; status = "okay"; };
Signature · 1 line
2.35.1
Quoted 15 lines · Steev Klimaszewski
The Lenovo Yoga C630 can't use the generic venus firmware that is in the linux-firmware repository, and needs a signed one. This file is qcvss850.mbn from the Windows partition and needs to be copied manually.
Signed-off-by Steev Klimaszewski <[email protected]>--- arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 1 + 1 file changed, 1 insertion(+)arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts +0
-0
arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts &usb_2_qmpphy { · line 804
Quoted 4 lines
arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts +1
-0@@ -801,6 +801,7 @@ &usb_2_qmpphy { }; &venus { + firmware-name = "qcom/venus-5.2/qcvss850.mbn";
Please follow the established convention (see e.g. the x13s laptop firmware). It should be "qcom/sdm850/LENOVO/81JL/qcvss850.mbn" (or qcom/sdm845/LENOVO/....).
Quoted 6 lines
arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts +0
-1status = "okay"; }; --2.35.1
Signature · 2 lines
With best wishes Dmitry
Quoted 29 lines · Dmitry Baryshkov
Quoted 15 lines · Steev Klimaszewski
The Lenovo Yoga C630 can't use the generic venus firmware that is in the linux-firmware repository, and needs a signed one. This file is qcvss850.mbn from the Windows partition and needs to be copied manually.
Signed-off-by Steev Klimaszewski <[email protected]>--- arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 1 + 1 file changed, 1 insertion(+)arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts +0
-0arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts &usb_2_qmpphy { · line 804
Quoted 4 lines
arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts +1
-0@@ -801,6 +801,7 @@ &usb_2_qmpphy { }; &venus { + firmware-name = "qcom/venus-5.2/qcvss850.mbn";Please follow the established convention (see e.g. the x13s laptop firmware). It should be "qcom/sdm850/LENOVO/81JL/qcvss850.mbn" (or qcom/sdm845/LENOVO/....).
Quoted 3 lines
arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts +0
-0status = "okay"; };
Quoted 8 lines
Quoted 3 lines
--
2.35.1--
With best wishes
Dmitry
Thanks for pointing that out; will make the change for v2!
PATCH 1/1 arm64: dts: qcom: c630: Fix firmware paths
In reply to Steev KlimaszewskiThe firmware paths were pointing to qcom/manufacturer whereas other devices have them under qcom/chipset/manufacturer, so fix this up on the c630, so we follow the same standard setup.
--- arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts +5 -4
@@ -94,7 +94,7 @@ backlight: backlight { }; &adsp_pas { - firmware-name = "qcom/LENOVO/81JL/qcadsp850.mbn"; + firmware-name = "qcom/sdm850/LENOVO/81JL/qcadsp850.mbn"; status = "okay"; };
@@ -306,7 +306,7 @@ vreg_lvs2a_1p8: lvs2 { }; &cdsp_pas { - firmware-name = "qcom/LENOVO/81JL/qccdsp850.mbn"; + firmware-name = "qcom/sdm850/LENOVO/81JL/qccdsp850.mbn"; status = "okay"; };
@@ -345,7 +345,7 @@ &gpu { status = "okay"; zap-shader { memory-region = <&gpu_mem>; - firmware-name = "qcom/LENOVO/81JL/qcdxkmsuc850.mbn"; + firmware-name = "qcom/sdm850/LENOVO/81JL/qcdxkmsuc850.mbn"; }; };
@@ -502,7 +502,7 @@ &mdss { &mss_pil { status = "okay"; - firmware-name = "qcom/LENOVO/81JL/qcdsp1v2850.mbn", "qcom/LENOVO/81JL/qcdsp2850.mbn"; + firmware-name = "qcom/sdm850/LENOVO/81JL/qcdsp1v2850.mbn", "qcom/sdm850/LENOVO/81JL/qcdsp2850.mbn"; }; &qup_i2c10_default {
@@ -801,6 +801,7 @@ &usb_2_qmpphy { }; &venus { + firmware-name = "qcom/sdm850/LENOVO/81JL/qcvss850.mbn"; status = "okay"; };
Signature · 1 line
2.35.1
Re: [PATCH] arm64: dts: qcom: c630: Fix firmware paths
Quoted 6 lines · Steev Klimaszewski
The firmware paths were pointing to qcom/manufacturer whereas other devices have them under qcom/chipset/manufacturer, so fix this up on the c630, so we follow the same standard setup.
Signed-off-by Steev Klimaszewski <[email protected]>
Thanks!
Quoted 3 lines
--- arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
Signature · 2 lines
With best wishes Dmitry
Re: [PATCH] arm64: dts: qcom: c630: Fix firmware paths
In reply to Steev KlimaszewskiQuoted 5 lines · Steev Klimaszewski
The firmware paths were pointing to qcom/manufacturer whereas other devices have them under qcom/chipset/manufacturer, so fix this up on the c630, so we follow the same standard setup.
Signed-off-by Steev Klimaszewski <[email protected]>
Do not attach your patches to some other threads. It messes with reading and applying.
Best regards,
Krzysztof
Re: [PATCH] arm64: dts: qcom: c630: Fix firmware paths
Quoted 6 lines · Krzysztof Kozlowski
Quoted 4 lines · Steev Klimaszewski
The firmware paths were pointing to qcom/manufacturer whereas other devices have them under qcom/chipset/manufacturer, so fix this up on the c630, so we follow the same standard setup.
Quoted 8 lines
Quoted 1 line
Signed-off-by Steev Klimaszewski <[email protected]>Do not attach your patches to some other threads. It messes with reading and applying.
Best regards,
Krzysztof
Sorry, I screwed up my first patch, and this was supposed to be a v2 of that one. I'll do better on other submissions.
Re: [PATCH] arm64: dts: qcom: c630: Fix firmware paths
In reply to Steev KlimaszewskiQuoted 5 lines · Steev Klimaszewski
The firmware paths were pointing to qcom/manufacturer whereas other devices have them under qcom/chipset/manufacturer, so fix this up on the c630, so we follow the same standard setup.
Applied, thanks!
[01/1] arm64: dts: qcom: c630: Fix firmware paths
commit: 40103eabe3d3139a69e5235cf3a86c89214ef584
[26/26] arm64: dts: qcom: c630: set venus firmware name
(no commit info)
Best regards,
Signature · 1 line
Bjorn Andersson <[email protected]>