Skip to contentSkip to conversation

fix unsupported flow rule transfer attribute

PATCH Applied Steve Yang 3 participants 7 messages Dec 26, 2022 – Jan 17, 2023 Network drivers

lore
Share & tools
lore

Steve Yang

author
#0 lore raw

cover fix unsupported flow rule transfer attribute

ice & i40e doesn't support transfer attribute of flow rule, ignore it when validating rule attributes.

Steve Yang (2):
net/i40e: fix unsupported flow rule transfer attribute net/ice: fix unsupported flow rule transfer attribute

 drivers/net/i40e/i40e_flow.c       | 8 ++++++++
 drivers/net/ice/ice_generic_flow.c | 8 ++++++++
 2 files changed, 16 insertions(+)
Signature · 1 line
2.25.1
author
#1 lore raw

PATCH 1/2 net/i40e: fix unsupported flow rule transfer attribute

i40e doesn't support transfer attribute of flow rule, ignore it when validating rule attributes.

Fixes 86eb05d6350b ("net/i40e: add flow validate function")
---
 drivers/net/i40e/i40e_flow.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/net/i40e/i40e_flow.c +8 -0
index 65a826d51c..67df77890a 100644
@@ -1236,6 +1236,14 @@ i40e_flow_parse_attr(const struct rte_flow_attr *attr,
 		return -rte_errno;
 	}
 
+	/* Not supported */
+	if (attr->transfer) {
+		rte_flow_error_set(error, EINVAL,
+				   RTE_FLOW_ERROR_TYPE_ATTR_TRANSFER,
+				   attr, "Not support transfer.");
+		return -rte_errno;
+	}
+
 	/* Not supported */
 	if (attr->priority) {
 		rte_flow_error_set(error, EINVAL,
Signature · 1 line
2.25.1
Acked-by on v1 1/2 Applied
#2 lore raw

RE: [PATCH v1 1/2] net/i40e: fix unsupported flow rule transfer attribute

Quoted 11 lines

-----Original Message-----
From: Yang, SteveX <[email protected]>
Sent: Monday, December 26, 2022 8:37 AM
To: [email protected]
Cc: Zhang, Yuying <[email protected]>; Xing, Beilei <[email protected]>; Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>; Yang, SteveX <[email protected]>
Subject: [PATCH v1 1/2] net/i40e: fix unsupported flow rule transfer attribute

Quoted 4 lines

i40e doesn't support transfer attribute of flow rule, ignore it when validating rule attributes.

Fixes 86eb05d6350b ("net/i40e: add flow validate function")

Applied to dpdk-next-net-intel.

Thanks
Qi

#3 lore raw

RE: [PATCH v1 1/2] net/i40e: fix unsupported flow rule transfer attribute

Quoted 27 lines

-----Original Message-----
From: Zhang, Qi Z
Sent: Tuesday, January 17, 2023 9:27 AM
To: 'Yang, SteveX' <[email protected]>; [email protected]
Cc: Zhang, Yuying <[email protected]>; Xing, Beilei <[email protected]>; Yang, Qiming <[email protected]>
Subject: RE: [PATCH v1 1/2] net/i40e: fix unsupported flow rule transfer attribute

Quoted 14 lines

-----Original Message-----
From: Yang, SteveX <[email protected]>
Sent: Monday, December 26, 2022 8:37 AM
To: [email protected]
Cc: Zhang, Yuying <[email protected]>; Xing, Beilei <[email protected]>; Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>; Yang, SteveX <[email protected]>
Subject: [PATCH v1 1/2] net/i40e: fix unsupported flow rule transfer attribute

i40e doesn't support transfer attribute of flow rule, ignore it when validating rule attributes.

Fixes 86eb05d6350b ("net/i40e: add flow validate function")

Also added Cc stable.

Quoted 7 lines

Applied to dpdk-next-net-intel.

Thanks
Qi

author
#4 lore raw

PATCH 2/2 net/ice: fix unsupported flow rule transfer attribute

In reply to Steve Yang

ice doesn't support transfer attribute of flow rule, ignore it when validating rule attributes.

Fixes d76116a4678f ("net/ice: add generic flow API")
---
 drivers/net/ice/ice_generic_flow.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/net/ice/ice_generic_flow.c +8 -0
index d496c28dec..86a32f8cb1 100644
@@ -2030,6 +2030,14 @@ ice_flow_valid_attr(struct ice_adapter *ad,
 		return -rte_errno;
 	}
 
+	/* Not supported */
+	if (attr->transfer) {
+		rte_flow_error_set(error, EINVAL,
+				   RTE_FLOW_ERROR_TYPE_ATTR_TRANSFER,
+				   attr, "Not support transfer.");
+		return -rte_errno;
+	}
+
 	/* Check pipeline mode support to set classification stage */
 	if (ad->devargs.pipe_mode_support) {
 		if (attr->priority == 0)
Signature · 1 line
2.25.1
Acked-by on v1 2/2 Applied
#5 lore raw

RE: [PATCH v1 2/2] net/ice: fix unsupported flow rule transfer attribute

Quoted 11 lines

-----Original Message-----
From: Yang, SteveX <[email protected]>
Sent: Monday, December 26, 2022 8:37 AM
To: [email protected]
Cc: Zhang, Yuying <[email protected]>; Xing, Beilei <[email protected]>; Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>; Yang, SteveX <[email protected]>
Subject: [PATCH v1 2/2] net/ice: fix unsupported flow rule transfer attribute

Quoted 6 lines

ice doesn't support transfer attribute of flow rule, ignore it when validating rule attributes.

Fixes d76116a4678f ("net/ice: add generic flow API")

Applied to dpdk-next-net-intel.

Thanks
Qi

Acked-by on the v1 series
#6 lore raw
In reply to Steve Yang

Hi,

Quoted 16 lines

-----Original Message-----
From: Yang, SteveX <[email protected]>
Sent: Monday, December 26, 2022 8:37 AM
To: [email protected]
Cc: Zhang, Yuying <[email protected]>; Xing, Beilei <[email protected]>; Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>; Yang, SteveX <[email protected]>
Subject: [PATCH v1 0/2] fix unsupported flow rule transfer attribute

ice & i40e doesn't support transfer attribute of flow rule, ignore it when validating rule attributes.

Steve Yang (2):
net/i40e: fix unsupported flow rule transfer attribute net/ice: fix unsupported flow rule transfer attribute

Quoted 6 lines
 drivers/net/i40e/i40e_flow.c       | 8 ++++++++
 drivers/net/ice/ice_generic_flow.c | 8 ++++++++
 2 files changed, 16 insertions(+)

--
2.25.1