Skip to contentSkip to conversation

queue-6.1 drop perf-stat-display-event-stats-using-aggr-counts.patch please

DISCUSSION Wang Yugui 2 participants 4 messages Dec 27, 2022 – Dec 28, 2022 Stable branch

lore
Share & tools
lore

Wang Yugui

author
#0 lore raw

Hi,

drop perf-stat-display-event-stats-using-aggr-counts.patch from queue-6.1 please.

It failed to compile on 6.1.y now.

Best Regards
Wang Yugui ([email protected])
2022/12/27

maintainer
#1 lore raw
Quoted 6 lines · Wang Yugui

Hi,

drop perf-stat-display-event-stats-using-aggr-counts.patch from queue-6.1 please.

It failed to compile on 6.1.y now.

Why not just also queue up b89761351089 ("perf stat: Update event skip condition for system-wide per-thread mode and merged uncore and hybrid events")?

thanks,

greg k-h

author
#2 lore raw

Hi,

Quoted 11 lines · Wang Yugui
Quoted 6 lines

Hi,

drop perf-stat-display-event-stats-using-aggr-counts.patch from queue-6.1 please.

It failed to compile on 6.1.y now.

Why not just also queue up b89761351089 ("perf stat: Update event skip condition for system-wide per-thread mode and merged uncore and hybrid events")?

We could add
ca68b374d040 (perf stat: Add struct perf_stat_aggr to perf_stat_evsel)

to queue-6.1 before the patch 'perf-stat-display-event-stats-using-aggr-counts.patch'

to fix the build error.
util/stat-display.c: In function 'print_counter_aggrdata':
util/stat-display.c:690:35: error: 'struct perf_stat_evsel' has no member named 'aggr'
struct perf_stat_aggr *aggr = &ps->aggr[s];

Best Regards
Wang Yugui ([email protected])
2022/12/27

Quoted 3 lines

thanks,

greg k-h

maintainer
#3 lore raw
Quoted 17 lines · Wang Yugui

Hi,

Quoted 11 lines · Wang Yugui
Quoted 6 lines

Hi,

drop perf-stat-display-event-stats-using-aggr-counts.patch from queue-6.1 please.

It failed to compile on 6.1.y now.

Why not just also queue up b89761351089 ("perf stat: Update event skip condition for system-wide per-thread mode and merged uncore and hybrid events")?

We could add
ca68b374d040 (perf stat: Add struct perf_stat_aggr to perf_stat_evsel)

Quoted 6 lines

to queue-6.1 before the patch 'perf-stat-display-event-stats-using-aggr-counts.patch'

to fix the build error.
util/stat-display.c: In function 'print_counter_aggrdata':
util/stat-display.c:690:35: error: 'struct perf_stat_evsel' has no member named 'aggr'
struct perf_stat_aggr *aggr = &ps->aggr[s];

Ok, that got messy fast, as things didn't apply.

I've dropped the original commit here now, can you send a backported series to us for inclusion in 6.1 that will work properly?

thanks,

greg k-h