mei: pxp: Use correct macros to initialize uuid_le
Subsystems (2)
PATCH 1/1 mei: pxp: Use correct macros to initialize uuid_le
GUID_INIT() is for internal guid_t type and shouldn't be used for the uuid_le. I.o.w. relying on the implementation details is layering violation. Use correct macros to initialize uuid_le.
Fixes c2004ce99ed7 ("mei: pxp: export pavp client to me client bus")
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/misc/mei/pxp/mei_pxp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/misc/mei/pxp/mei_pxp.c +2 -2
@@ -238,8 +238,8 @@ static void mei_pxp_remove(struct mei_cl_device *cldev) }/* fbf6fcf1-96cf-4e2e-a6a6-1bab8cbe36b1 : PAVP GUID*/ -#define MEI_GUID_PXP GUID_INIT(0xfbf6fcf1, 0x96cf, 0x4e2e, 0xA6, \ - 0xa6, 0x1b, 0xab, 0x8c, 0xbe, 0x36, 0xb1) +#define MEI_GUID_PXP UUID_LE(0xfbf6fcf1, 0x96cf, 0x4e2e, 0xA6, \ + 0xa6, 0x1b, 0xab, 0x8c, 0xbe, 0x36, 0xb1)static struct mei_cl_device_id mei_pxp_tbl[] = { { .uuid =MEI_GUID_PXP , .version =MEI_CL_VERSION_ANY },
Signature · 1 line
2.35.1
Quoted 8 lines
GUID_INIT()is for internalguid_ttype and shouldn't be used for theuuid_le. I.o.w. relying on the implementation details is layering violation. Use correct macros to initializeuuid_le.Fixes c2004ce99ed7 ("mei: pxp: export pavp client to me client bus")Signed-off-by Andy Shevchenko <[email protected]>
Acked-by Tomas Winkler <[email protected]>
Quoted 22 lines
--- drivers/misc/mei/pxp/mei_pxp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)(quoted diff) +0
-0
b/drivers/misc/mei/pxp/mei_pxp.cindex8dd09b1722eb..7ee1fa7b1cb3100644drivers/misc/mei/pxp/mei_pxp.c +2
-2@@ -238,8 +238,8 @@ static void mei_pxp_remove(struct mei_cl_device *cldev) } /* fbf6fcf1-96cf-4e2e-a6a6-1bab8cbe36b1 : PAVP GUID*/ -#defineMEI_GUID_PXP GUID_INIT(0xfbf6fcf1, 0x96cf, 0x4e2e, 0xA6, \ - 0xa6, 0x1b, 0xab, 0x8c, 0xbe, 0x36, 0xb1) +#define MEI_GUID_PXP UUID_LE(0xfbf6fcf1, 0x96cf, 0x4e2e, 0xA6, \ + 0xa6, 0x1b, 0xab, 0x8c, 0xbe, 0x36, 0xb1)static struct mei_cl_device_id mei_pxp_tbl[] = { { .uuid =MEI_GUID_PXP , .version =MEI_CL_VERSION_ANY }, --2.35.1