Skip to contentSkip to conversation

virtio: vdpa: explain the dependency of SNET_VDPA on HWMON

PATCH In review Alvaro Karsz 3 participants 6 messages Dec 20, 2022 – Jan 8, 2023 virtio core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virtio: vdpa: explain the dependency of SNET_VDPA on HWMON

Add a comment in Kconfig explaining the
"depends on .. && (HWMON || HWMON=n)" part.

This patch should be applied on top of the following patch:

virtio: vdpa: new SolidNET DPU driver,
by Alvaro Karsz [email protected]

---
 drivers/vdpa/Kconfig | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/vdpa/Kconfig +8 -0
index 79625c7cc46..7396e92b485 100644
@@ -89,6 +89,14 @@ config ALIBABA_ENI_VDPA
  config SNET_VDPA
 	tristate "SolidRun's vDPA driver for SolidNET"
 	depends on PCI_MSI && PCI_IOV && (HWMON || HWMON=n)
+
+	# This driver MAY create a HWMON device.
+	# Depending on (HWMON || HWMON=n) ensures that:
+	# If HWMON=n the driver can be compiled either as a module or built-in.
+	# If HWMON=y the driver can be compiled either as a module or built-in.
+	# If HWMON=m the driver is forced to be compiled as a module.
+	# By doing so, IS_ENABLED can be used instead of IS_REACHABLE
+
 	help
 	  vDPA driver for SolidNET DPU.
 	  With this driver, the VirtIO dataplane can be
Signature · 6 lines
2.32.0

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Alvaro Karsz

Add a comment in Kconfig explaining the
"depends on .. && (HWMON || HWMON=n)" part.

This patch should be applied on top of the following patch:

virtio: vdpa: new SolidNET DPU driver,
by Alvaro Karsz [email protected]

Thanks

Quoted 24 lines
---
 drivers/vdpa/Kconfig | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/vdpa/Kconfig +8 -1
index 79625c7cc46..7396e92b485 100644
@@ -89,6 +89,14 @@ config ALIBABA_ENI_VDPA
  config SNET_VDPA
        tristate "SolidRun's vDPA driver for SolidNET"
        depends on PCI_MSI && PCI_IOV && (HWMON || HWMON=n)
+
+       # This driver MAY create a HWMON device.
+       # Depending on (HWMON || HWMON=n) ensures that:
+       # If HWMON=n the driver can be compiled either as a module or built-in.
+       # If HWMON=y the driver can be compiled either as a module or built-in.
+       # If HWMON=m the driver is forced to be compiled as a module.
+       # By doing so, IS_ENABLED can be used instead of IS_REACHABLE
+
        help
          vDPA driver for SolidNET DPU.
          With this driver, the VirtIO dataplane can be
--
Quoted 2 lines

2.32.0

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

#3 lore raw
Quoted 4 lines · Alvaro Karsz

Hi Michael,

Is this patch ok with you?
Do you have any comments?

It's ok. I had to push everything out to next merge window though. Sorry :(

Signature · 6 lines
MST

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization