Skip to contentSkip to conversation

package/tiff: add libdeflate optional dependency

PATCH Applied Fabrice Fontaine 3 participants 3 messages Dec 29, 2022 – Jan 2, 2023

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/tiff: add libdeflate optional dependency

libdeflate is an optional dependency which is enabled by default since version 4.2.0 and
https://gitlab.com/libtiff/libtiff/-/commit/3a2de853a932bd0ea79d1677d319841edb736c38

---
Changes v1 -> v2 (after review of Thomas Petazzoni):
- Drop default y

 package/tiff/Config.in | 5 +++++
 package/tiff/tiff.mk   | 7 +++++++
 2 files changed, 12 insertions(+)
package/tiff/Config.in +5 -0
index f842c2ead8..cc9aa5cfd0 100644
@@ -11,6 +11,11 @@ config BR2_PACKAGE_TIFF_CCITT
 	bool "CCITT Group 3 & 4 support"
 	default y
 
+config BR2_PACKAGE_TIFF_LIBDEFLATE
+	bool "Libdeflate usage (still requires Zlib)"
+	select BR2_PACKAGE_LIBDEFLATE
+	select BR2_PACKAGE_TIFF_ZLIB
+
 config BR2_PACKAGE_TIFF_PACKBITS
 	bool "Macintosh PackBits algorithm"
 	default y
package/tiff/tiff.mk +7 -0
index 7981bdf2c9..a753065fde 100644
@@ -33,6 +33,13 @@ ifneq ($(BR2_PACKAGE_TIFF_CCITT),y)
 TIFF_CONF_OPTS += --disable-ccitt
 endif
 
+ifeq ($(BR2_PACKAGE_TIFF_LIBDEFLATE),y)
+TIFF_CONF_OPTS += --enable-libdeflate
+TIFF_DEPENDENCIES += libdeflate
+else
+TIFF_CONF_OPTS += --disable-libdeflate
+endif
+
 ifneq ($(BR2_PACKAGE_TIFF_PACKBITS),y)
 TIFF_CONF_OPTS += --disable-packbits
 endif
Signature · 6 lines
2.35.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 8 lines · On Thu, 29 Dec 2022 09:48:14 +0100 Fabrice Fontaine…

libdeflate is an optional dependency which is enabled by default since version 4.2.0 and
https://gitlab.com/libtiff/libtiff/-/commit/3a2de853a932bd0ea79d1677d319841edb736c38

---
Changes v1 -> v2 (after review of Thomas Petazzoni):
- Drop default y

Applied to master, thanks.

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw
In reply to Fabrice Fontaine
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

libdeflate is an optional dependency which is enabled by default since version 4.2.0 and
https://gitlab.com/libtiff/libtiff/-/commit/3a2de853a932bd0ea79d1677d319841edb736c38

---
Changes v1 -> v2 (after review of Thomas Petazzoni):
- Drop default y

Committed to 2022.11.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot