i386: Deprecate the -no-hpet QEMU command line option
PATCH v2 1/1 i386: Deprecate the -no-hpet QEMU command line option
The HPET setting has been turned into a machine property a while ago already, so we should finally do the next step and deprecate the legacy CLI option, too.
---
v2:
- Rebased to current version from master branch / adjusted version info
- Dropped the descrpition in hw/i386/pc.c (already done via another patch)
Note: The "hpet" property should now show up in the output of the "query-command-line-options" QMP command since commit 2f129fc107b4a, so it should be feasible for libvirt now to properly probe for the property .
docs/about/deprecated.rst | 6 ++++++ softmmu/vl.c | 1 + qemu-options.hx | 2 +- 3 files changed, 8 insertions(+), 1 deletion(-)
docs/about/deprecated.rst +6 -0
@@ -114,6 +114,12 @@ form is preferred. Using ``-drive if=none`` to configure the OTP device of the sifive_u RISC-V machine is deprecated. Use ``-drive if=pflash`` instead. +``-no-hpet`` (since 8.0) +'''''''''''''''''''''''' + +The HPET setting has been turned into a machine property. +Use ``-machine hpet=off`` instead. + QEMU Machine Protocol (QMP) commands ------------------------------------
softmmu/vl.c +1 -0
@@ -3259,6 +3259,7 @@ void qemu_init(int argc, char **argv)qdict_put_str (machine_opts_dict,"acpi" ,"off" );break ;case QEMU_OPTION_no_hpet: +warn_report ("-no-hpet is deprecated, use '-machine hpet=off' instead" );qdict_put_str (machine_opts_dict,"hpet" ,"off" );break ;case QEMU_OPTION_no_reboot:
qemu-options.hx +1 -1
@@ -2542,7 +2542,7 @@ DEF("no-hpet", 0, QEMU_OPTION_no_hpet, "-no-hpet disable HPET\n", QEMU_ARCH_I386) SRST ``-no-hpet`` - Disable HPET support. + Disable HPET support. Deprecated, use '-machine hpet=off' instead. ERST DEF("acpitable", HAS_ARG, QEMU_OPTION_acpitable,
Signature · 1 line
2.31.1
Quoted 10 lines · Thomas Huth
The HPET setting has been turned into a machine property a while ago already, so we should finally do the next step and deprecate the legacy CLI option, too.
Signed-off-by Thomas Huth <[email protected]>---
v2:
- Rebased to current version from master branch / adjusted version info
- Dropped the descrpition inhw/i386/pc.c(already done via another patch)
Quoted 8 lines
Note: The "hpet" property should now show up in the output of the "query-command-line-options" QMP command since commit
2f129fc107b4a, so it should be feasible for libvirt now to properly probe for the property .docs/about/deprecated.rst | 6 ++++++ softmmu/vl.c | 1 + qemu-options.hx | 2 +- 3 files changed, 8 insertions(+), 1 deletion(-)
Quoted 10 lines · Thomas Huth
The HPET setting has been turned into a machine property a while ago already, so we should finally do the next step and deprecate the legacy CLI option, too.
Signed-off-by Thomas Huth <[email protected]>---
v2:
- Rebased to current version from master branch / adjusted version info
- Dropped the descrpition inhw/i386/pc.c(already done via another patch)
Quoted 8 lines
Note: The "hpet" property should now show up in the output of the "query-command-line-options" QMP command since commit
2f129fc107b4a, so it should be feasible for libvirt now to properly probe for the property .docs/about/deprecated.rst | 6 ++++++ softmmu/vl.c | 1 + qemu-options.hx | 2 +- 3 files changed, 8 insertions(+), 1 deletion(-)
Libvirt currently still uses '-no-hpet' but adapting to configure it via machine should be straightforward. I'll post the patches soon hopefully.
Quoted 10 lines · Thomas Huth
The HPET setting has been turned into a machine property a while ago already, so we should finally do the next step and deprecate the legacy CLI option, too.
Signed-off-by Thomas Huth <[email protected]>---
v2:
- Rebased to current version from master branch / adjusted version info
- Dropped the descrpition inhw/i386/pc.c(already done via another patch)
Quoted 9 lines
Note: The "hpet" property should now show up in the output of the "query-command-line-options" QMP command since commit
2f129fc107b4a, so it should be feasible for libvirt now to properly probe for the property .docs/about/deprecated.rst | 6 ++++++ softmmu/vl.c | 1 + qemu-options.hx | 2 +- 3 files changed, 8 insertions(+), 1 deletion(-)
Jano