ARM: dts: dove.dtsi: Move ethphy to fix schema error
PATCH v3 1/1 ARM: dts: dove.dtsi: Move ethphy to fix schema error
Running 'make dtbs_check' with schema in net/marvell,orion-mdio.yaml gives following warnings:
mdio-bus@72004: Unevaluated properties are not allowed ('ethernet-phy' was unexpected)
arch/arm/boot/dts/dove-cubox.dtb arch/arm/boot/dts/dove-cubox-es.dtb arch/arm/boot/dts/dove-d2plug.dtb arch/arm/boot/dts/dove-d2plug.dtb arch/arm/boot/dts/dove-dove-db.dtb arch/arm/boot/dts/dove-d3plug.dtb arch/arm/boot/dts/dove-sbc-a510.dtb
As every subnode of mdio is expected to have an @X, ethernet-phy subnode in dove.dtsi doesn't have one. Fix these errors by moving ethernet-phy into relevant .dts files with correct @<reg address>.
---
Changelog:v2->v3
- edit commit message according to
https://lore.kernel.org/all/[email protected]/
v1->v2
- remove patternProperties: from .yaml
- move ethphy from dove.dtsi into relevant .dts files
arch/arm/boot/dts/dove-cm-a510.dtsi | 14 +++++++++++--- arch/arm/boot/dts/dove-cubox.dts | 15 +++++++++++---- arch/arm/boot/dts/dove.dtsi | 5 ----- 3 files changed, 22 insertions(+), 12 deletions(-)
arch/arm/boot/dts/dove-cm-a510.dtsi +11 -3
@@ -124,9 +124,17 @@ wifi_power: regulator@1 { }; /* Optional RTL8211D GbE PHY on SMI address 0x03 */ -ðphy { - reg = <3>; - status = "disabled"; +&mdio { + ethphy: ethernet-phy@3 { + reg = <3>; + status = "disabled"; + }; +}; + +ð { + ethernet-port@0 { + phy-handle = <ðphy>; + }; }; &i2c0 {
arch/arm/boot/dts/dove-cubox.dts +11 -4
@@ -72,11 +72,18 @@ gpu-subsystem { &uart0 { status = "okay"; }; &sata0 { status = "okay"; }; &mdio { status = "okay"; }; -ð { status = "okay"; }; +ð { + status = "okay"; + ethernet-port@0 { + phy-handle = <ðphy>; + }; +}; -ðphy { - compatible = "marvell,88e1310"; - reg = <1>; +&mdio { + ethphy: ethernet-phy@1 { + compatible = "marvell,88e1310"; + reg = <1>; + }; }; &gpu {
arch/arm/boot/dts/dove.dtsi +0 -5
@@ -382,7 +382,6 @@ ethernet-port@0 { interrupts = <29>; /* overwrite MAC address in bootloader */ local-mac-address = [00 00 00 00 00 00]; - phy-handle = <ðphy>; }; };
@@ -394,10 +393,6 @@ mdio: mdio-bus@72004 { interrupts = <30>; clocks = <&gate_clk 2>; status = "disabled"; - - ethphy: ethernet-phy { - /* set phy address in board file */ - }; }; sdio0: sdio-host@92000 {
Signature · 1 line
2.34.1
Quoted 11 lines · Michał Grzelak
Running 'make
dtbs_check' with schema innet/marvell,orion-mdio.yamlgives following warnings:
mdio-bus@72004: Unevaluated properties are not allowed ('ethernet-phy' was unexpected)arch/arm/boot/dts/dove-cubox.dtb arch/arm/boot/dts/dove-cubox-es.dtb arch/arm/boot/dts/dove-d2plug.dtb arch/arm/boot/dts/dove-d2plug.dtb arch/arm/boot/dts/dove-dove-db.dtb arch/arm/boot/dts/dove-d3plug.dtb arch/arm/boot/dts/dove-sbc-a510.dtb
Quoted 5 lines
As every subnode of mdio is expected to have an @X, ethernet-phy subnode in
dove.dtsidoesn't have one. Fix these errors by moving ethernet-phy into relevant .dts files with correct @<reg address>.Signed-off-by Michał Grzelak <[email protected]>
Andrew
Quoted 11 lines · Michał Grzelak
Running 'make
dtbs_check' with schema innet/marvell,orion-mdio.yamlgives following warnings:
mdio-bus@72004: Unevaluated properties are not allowed ('ethernet-phy' was unexpected)arch/arm/boot/dts/dove-cubox.dtb arch/arm/boot/dts/dove-cubox-es.dtb arch/arm/boot/dts/dove-d2plug.dtb arch/arm/boot/dts/dove-d2plug.dtb arch/arm/boot/dts/dove-dove-db.dtb arch/arm/boot/dts/dove-d3plug.dtb arch/arm/boot/dts/dove-sbc-a510.dtb
Quoted 5 lines
As every subnode of mdio is expected to have an @X, ethernet-phy subnode in
dove.dtsidoesn't have one. Fix these errors by moving ethernet-phy into relevant .dts files with correct @<reg address>.Signed-off-by Michał Grzelak <[email protected]>
Applied on mvebu/dt
Thanks,
Gregory
Quoted 93 lines
---
Changelog:v2->v3
- edit commit message according to
https://lore.kernel.org/all/[email protected]/
v1->v2
- remove patternProperties: from .yaml
- move ethphy fromdove.dtsiinto relevant .dts filesarch/arm/boot/dts/dove-cm-a510.dtsi | 14 +++++++++++--- arch/arm/boot/dts/dove-cubox.dts | 15 +++++++++++---- arch/arm/boot/dts/dove.dtsi | 5 ----- 3 files changed, 22 insertions(+), 12 deletions(-)arch/arm/boot/dts/dove-cm-a510.dtsi +11
-3@@ -124,9 +124,17 @@ wifi_power: regulator@1 { }; /* Optional RTL8211D GbE PHY on SMI address 0x03 */ -ðphy { - reg = <3>; - status = "disabled"; +&mdio { + ethphy: ethernet-phy@3 { + reg = <3>; + status = "disabled"; + }; +}; + +ð { + ethernet-port@0 { + phy-handle = <ðphy>; + }; }; &i2c0 {arch/arm/boot/dts/dove-cubox.dts +11
-4@@ -72,11 +72,18 @@ gpu-subsystem { &uart0 { status = "okay"; }; &sata0 { status = "okay"; }; &mdio { status = "okay"; }; -ð { status = "okay"; }; +ð { + status = "okay"; + ethernet-port@0 { + phy-handle = <ðphy>; + }; +}; -ðphy { - compatible = "marvell,88e1310"; - reg = <1>; +&mdio { + ethphy: ethernet-phy@1 { + compatible = "marvell,88e1310"; + reg = <1>; + }; }; &gpu {arch/arm/boot/dts/dove.dtsi +0
-5@@ -382,7 +382,6 @@ ethernet-port@0 { interrupts = <29>; /* overwrite MAC address in bootloader */ local-mac-address = [00 00 00 00 00 00]; - phy-handle = <ðphy>; }; };@@ -394,10 +393,6 @@ mdio: mdio-bus@72004 { interrupts = <30>; clocks = <&gate_clk 2>; status = "disabled"; - - ethphy: ethernet-phy { - /* set phy address in board file */ - }; }; sdio0: sdio-host@92000 {Signature · 1 line
2.34.1
Signature · 3 lines
Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com