Skip to contentSkip to conversation

Revert patch to fix sound sudden dissapearance

PATCH New [email protected] 3 participants 4 messages Dec 30, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover Revert patch to fix sound sudden dissapearance

Update to 5.10.157 causes sudden sound dissapearance regression for some laptops

[PATCH 1/1] Revert "ASoC: soc-pcm: Don't zero TDM masks in

#1 lore raw

PATCH 1/1 Revert "ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()"

From: Nikolai Kostrigin <[email protected]>

This reverts commit c34db0d6b88b1da95e7ab3353e674f4f574cccee.

Sudden sound disappearance was reported for some laptops, e.g. Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz

lspci
0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20)
Subsystem: Acer Incorporated [ALI] Device 148c
Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12
Memory at 601f270000 (64-bit, non-prefetchable) [size=16K]
Memory at 601f000000 (64-bit, non-prefetchable) [size=1M]
Capabilities: [50] Power Management version 3
Capabilities: [80] Vendor Specific Information: Len=14 <?>
Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+
Kernel driver in use: sof-audio-pci

Bisection revealed the commit being reverted.

---
 sound/soc/soc-pcm.c | 5 +++++
 1 file changed, 5 insertions(+)
sound/soc/soc-pcm.c +5 -0
index 0e2261ee07b67..8b8a9aca2912f 100644
@@ -723,6 +723,11 @@ static int soc_pcm_open(struct snd_pcm_substream *substream)
 		ret = snd_soc_dai_startup(dai, substream);
 		if (ret < 0)
 			goto err;
+
+		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+			dai->tx_mask = 0;
+		else
+			dai->rx_mask = 0;
 	}
 
 	/* Dynamic PCM DAI links compat checks use dynamic capabilities */
Signature · 1 line
2.33.5
#2 lore raw

Re: [PATCH] Revert "ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()"

Quoted 20 lines · On Fri, Dec 30, 2022 at 12:30:53PM +0300, [email protected] wrote:

From: Nikolai Kostrigin <[email protected]>

This reverts commit c34db0d6b88b1da95e7ab3353e674f4f574cccee.

Sudden sound disappearance was reported for some laptops, e.g. Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz

lspci
0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20)
Subsystem: Acer Incorporated [ALI] Device 148c
Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12
Memory at 601f270000 (64-bit, non-prefetchable) [size=16K]
Memory at 601f000000 (64-bit, non-prefetchable) [size=1M]
Capabilities: [50] Power Management version 3
Capabilities: [80] Vendor Specific Information: Len=14 <?>
Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+
Kernel driver in use: sof-audio-pci

Bisection revealed the commit being reverted.

Quoted 7 lines
---
 sound/soc/soc-pcm.c | 5 +++++
 1 file changed, 5 insertions(+)

<formletter>

This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

#3 lore raw

Re: [PATCH] Revert "ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()"

Quoted 29 lines · Greg KH
Quoted 20 lines · On Fri, Dec 30, 2022 at 12:30:53PM +0300, [email protected] wrote:

From: Nikolai Kostrigin <[email protected]>

This reverts commit c34db0d6b88b1da95e7ab3353e674f4f574cccee.

Sudden sound disappearance was reported for some laptops, e.g. Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz

lspci
0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20)
Subsystem: Acer Incorporated [ALI] Device 148c
Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12
Memory at 601f270000 (64-bit, non-prefetchable) [size=16K]
Memory at 601f000000 (64-bit, non-prefetchable) [size=1M]
Capabilities: [50] Power Management version 3
Capabilities: [80] Vendor Specific Information: Len=14 <?>
Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+
Kernel driver in use: sof-audio-pci

Bisection revealed the commit being reverted.

Quoted 7 lines
---
 sound/soc/soc-pcm.c | 5 +++++
 1 file changed, 5 insertions(+)
Quoted 8 lines

<formletter>

This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

Also FWIW & FYI: I earlier today brought the regression in question to the attention of the people that are responsible to fix this issue:
https://lore.kernel.org/all/[email protected]/

With a bit of luck they will soon look into this and fix it, but given the time of year it might take a day or two longer than usual...

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

P.S.: As the Linux kernel's regression tracker I deal with a lot of reports and sometimes miss something important when writing mails like this. If that's the case here, don't hesitate to tell me in a public reply, it's in everyone's interest to set the public record straight.