ext4: remove dead code in updating backup sb
PATCH 1/1 ext4: remove dead code in updating backup sb
ext4_update_backup_sb checks for err having some value after unlocking buffer. But err has not been updated till that point in any code which will lead execution of the code in question.
Signed-off-by Tanmay Bhushan <[email protected]>
--- fs/ext4/ioctl.c | 3 --- 1 file changed, 3 deletions(-)
fs/ext4/ioctl.c +0 -3
@@ -155,9 +155,6 @@ static int ext4_update_backup_sb(struct super_block *sb,set_buffer_uptodate (bh);unlock_buffer (bh); -if (err) - goto out_bh; -if (handle) { err =ext4_handle_dirty_metadata (handle,NULL , bh);if (err)
Signature · 1 line
2.34.1
Quoted 6 lines · Tanmay Bhushan
ext4_update_backup_sbchecks for err having some value after unlocking buffer. But err has not been updated till that point in any code which will lead execution of the code in question.Signed-off-by Tanmay Bhushan <[email protected]>
Looks good to me. Feel free to add:
Reviewed-by Jan Kara <[email protected]>
Honza
Quoted 21 lines
--- fs/ext4/ioctl.c | 3 --- 1 file changed, 3 deletions(-)fs/ext4/ioctl.c +0
-3@@ -155,9 +155,6 @@ static int ext4_update_backup_sb(struct super_block *sb,set_buffer_uptodate (bh);unlock_buffer (bh); -if (err) - goto out_bh; -if (handle) { err =ext4_handle_dirty_metadata (handle,NULL , bh);if (err)Signature · 1 line
2.34.1
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Quoted 6 lines · Tanmay Bhushan
ext4_update_backup_sbchecks for err having some value after unlocking buffer. But err has not been updated till that point in any code which will lead execution of the code in question.
Applied, thanks!
[1/1] ext4: remove dead code in updating backup sb
commit: 08abd0466ec9113908e674d042ec2a36dfc2875c
Best regards,
Signature · 1 line
Theodore Ts'o <[email protected]>