Skip to contentSkip to conversation

net: Increase L2TPv3 buffer to fit jumboframes

PATCH In review Christian Svensson 2 participants 3 messages Dec 30, 2022 – Jan 9, 2023 Networking

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: Increase L2TPv3 buffer to fit jumboframes

Increase the allocated buffer size to fit larger packets.
Given that jumboframes can commonly be up to 9000 bytes the closest suitable value seems to be 16 KiB.

Tested by running qemu towards a Linux L2TPv3 endpoint and pushing jumboframe traffic through the interfaces.

---
 net/l2tpv3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/l2tpv3.c +1 -1
index 5852e42738..3d5c6d11d3 100644
@@ -42,7 +42,7 @@
  */
 
 #define BUFFER_ALIGN sysconf(_SC_PAGESIZE)
-#define BUFFER_SIZE 2048
+#define BUFFER_SIZE 16384
 #define IOVSIZE 2
 #define MAX_L2TPV3_MSGCNT 64
 #define MAX_L2TPV3_IOVCNT (MAX_L2TPV3_MSGCNT * IOVSIZE)
Signature · 1 line
2.36.2
#1 lore raw

+qemu-trivial

Quoted 30 lines · On Fri, Dec 30, 2022, 21:27 Christian Svensson <[email protected]> wrote:

Increase the allocated buffer size to fit larger packets. Given that jumboframes can commonly be up to 9000 bytes the closest suitable
value seems to be 16 KiB.

Tested by running qemu towards a Linux L2TPv3 endpoint and pushing jumboframe traffic through the interfaces.

---
 net/l2tpv3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/l2tpv3.c +1 -2
index 5852e42738..3d5c6d11d3 100644
@@ -42,7 +42,7 @@
  */
 
 #define BUFFER_ALIGN sysconf(_SC_PAGESIZE)
-#define BUFFER_SIZE 2048
+#define BUFFER_SIZE 16384
 #define IOVSIZE 2
 #define MAX_L2TPV3_MSGCNT 64
 #define MAX_L2TPV3_IOVCNT (MAX_L2TPV3_MSGCNT * IOVSIZE)
--

2.36.2

#2 lore raw
In reply to Christian Svensson
Quoted 9 lines · Christian Svensson

Increase the allocated buffer size to fit larger packets.
Given that jumboframes can commonly be up to 9000 bytes the closest suitable value seems to be 16 KiB.

Tested by running qemu towards a Linux L2TPv3 endpoint and pushing jumboframe traffic through the interfaces.

Queued.

Thanks

Quoted 20 lines
---
 net/l2tpv3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/l2tpv3.c +1 -2
index 5852e42738..3d5c6d11d3 100644
@@ -42,7 +42,7 @@
  */
 
 #define BUFFER_ALIGN sysconf(_SC_PAGESIZE)
-#define BUFFER_SIZE 2048
+#define BUFFER_SIZE 16384
 #define IOVSIZE 2
 #define MAX_L2TPV3_MSGCNT 64
 #define MAX_L2TPV3_IOVCNT (MAX_L2TPV3_MSGCNT * IOVSIZE)
--

2.36.2