Skip to contentSkip to conversation

Unify USB Over Current Settings on Toradex Boards

PATCH Applied Philippe Schenker 2 participants 7 messages Nov 22, 2022 – Dec 31, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover Unify USB Over Current Settings on Toradex Boards

From: Philippe Schenker <[email protected]>

This patchset intends to disable the USB Over Current for Toradex i.MX boards using the USB chipidea driver.

We do this on the Carrier-Board device-trees due to the reason, that if a customer of us inheriting the module-level device-tree (named -.dtsi) does not inherit settings from us that may be incorrect for his use-case.

Philippe Schenker (5):
ARM: dts: apalis-imx6: Disable usb over-current
ARM: dts: colibri-imx6: Disable usb over-current
ARM: dts: colibri-imx6ull: Disable usb over-current
ARM: dts: colibri-imx7: Disable usb over-current
arm64: dts: verdin-imx8mm: Disable usb over-current

 arch/arm/boot/dts/imx6dl-colibri-aster.dts              | 2 ++
 arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts            | 2 ++
 arch/arm/boot/dts/imx6dl-colibri-iris.dts               | 2 ++
 arch/arm/boot/dts/imx6q-apalis-eval.dts                 | 2 ++
 arch/arm/boot/dts/imx6q-apalis-ixora-v1.2.dts           | 2 ++
 arch/arm/boot/dts/imx6q-apalis-ixora.dts                | 2 ++
 arch/arm/boot/dts/imx6qdl-apalis.dtsi                   | 1 -
 arch/arm/boot/dts/imx6qdl-colibri.dtsi                  | 1 -
 arch/arm/boot/dts/imx6ull-colibri-aster.dtsi            | 2 ++
 arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi          | 2 ++
 arch/arm/boot/dts/imx6ull-colibri-iris.dtsi             | 2 ++
 arch/arm/boot/dts/imx7-colibri-aster.dtsi               | 1 +
 arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi             | 1 +
 arch/arm/boot/dts/imx7-colibri-iris-v2.dtsi             | 1 +
 arch/arm/boot/dts/imx7-colibri-iris.dtsi                | 1 +
 arch/arm/boot/dts/imx7d-colibri-aster.dts               | 1 +
 arch/arm/boot/dts/imx7d-colibri-emmc-aster.dts          | 1 +
 arch/arm/boot/dts/imx7d-colibri-emmc-eval-v3.dts        | 1 +
 arch/arm/boot/dts/imx7d-colibri-emmc-iris-v2.dts        | 1 +
 arch/arm/boot/dts/imx7d-colibri-emmc-iris.dts           | 1 +
 arch/arm/boot/dts/imx7d-colibri-emmc.dtsi               | 1 +
 arch/arm/boot/dts/imx7d-colibri-eval-v3.dts             | 1 +
 arch/arm/boot/dts/imx7d-colibri-iris-v2.dts             | 1 +
 arch/arm/boot/dts/imx7d-colibri-iris.dts                | 1 +
 arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi | 2 ++
 arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi        | 2 --
 26 files changed, 33 insertions(+), 4 deletions(-)
Signature · 7 lines
2.38.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw

PATCH 1/5 ARM: dts: apalis-imx6: Disable usb over-current

From: Philippe Schenker <[email protected]>

Disable usb over-current of the chipidea driver on all Carrier-Boards used by Toradex. Do this as we don't want to use this functionality on our Carrier Boards and to leave it open to someone who includes our module-level device-trees.

Remove the now obsolete disable-over-current flag from module-level device-tree imx6qdl-apalis.dtsi and leave it as already mentioned to the people actually implementing the carrier-board to implement this.

This will prevent the warning "No over current polarity defined" from being printed on boot.

---

 arch/arm/boot/dts/imx6q-apalis-eval.dts       | 2 ++
 arch/arm/boot/dts/imx6q-apalis-ixora-v1.2.dts | 2 ++
 arch/arm/boot/dts/imx6q-apalis-ixora.dts      | 2 ++
 arch/arm/boot/dts/imx6qdl-apalis.dtsi         | 1 -
 4 files changed, 6 insertions(+), 1 deletion(-)
arch/arm/boot/dts/imx6q-apalis-eval.dts +2 -0
index fa160a389870..3fc079dfd61e 100644
@@ -147,11 +147,13 @@ &uart5 {
 };
 
 &usbh1 {
+	disable-over-current;
 	vbus-supply = <&reg_usb_host_vbus>;
 	status = "okay";
 };
 
 &usbotg {
+	disable-over-current;
 	vbus-supply = <&reg_usb_otg_vbus>;
 	status = "okay";
 };
arch/arm/boot/dts/imx6q-apalis-ixora-v1.2.dts +2 -0
index f9f7d99bd4db..717decda0ceb 100644
@@ -202,11 +202,13 @@ &uart5 {
 };
 
 &usbh1 {
+	disable-over-current;
 	vbus-supply = <&reg_usb_host_vbus>;
 	status = "okay";
 };
 
 &usbotg {
+	disable-over-current;
 	vbus-supply = <&reg_usb_otg_vbus>;
 	status = "okay";
 };
arch/arm/boot/dts/imx6q-apalis-ixora.dts +2 -0
index ce39c6a3f640..f338be435277 100644
@@ -151,11 +151,13 @@ &uart5 {
 };
 
 &usbh1 {
+	disable-over-current;
 	vbus-supply = <&reg_usb_host_vbus>;
 	status = "okay";
 };
 
 &usbotg {
+	disable-over-current;
 	vbus-supply = <&reg_usb_otg_vbus>;
 	status = "okay";
 };
arch/arm/boot/dts/imx6qdl-apalis.dtsi +0 -1
index 7c17b91f0965..f912697bfdb3 100644
@@ -824,7 +824,6 @@ &uart5 {
 };
 
 &usbotg {
-	disable-over-current;
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_usbotg>;
 	status = "disabled";
Signature · 7 lines
2.38.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#2 lore raw

PATCH 2/5 ARM: dts: colibri-imx6: Disable usb over-current

In reply to Philippe Schenker

From: Philippe Schenker <[email protected]>

Disable usb over-current of the chipidea driver on all Carrier-Boards used by Toradex. Do this as we don't want to use this functionality on our Carrier Boards and to leave it open to someone who includes our module-level device-trees.

Remove the now obsolete disable-over-current flag from module-level device-tree imx6qdl-colibri.dtsi and leave it as already mentioned to the people actually implementing the carrier-board to implement this.

This will prevent the warning "No over current polarity defined" from being printed on boot.

---

 arch/arm/boot/dts/imx6dl-colibri-aster.dts   | 2 ++
 arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts | 2 ++
 arch/arm/boot/dts/imx6dl-colibri-iris.dts    | 2 ++
 arch/arm/boot/dts/imx6qdl-colibri.dtsi       | 1 -
 4 files changed, 6 insertions(+), 1 deletion(-)
arch/arm/boot/dts/imx6dl-colibri-aster.dts +2 -0
index a28e083f29d5..82a0d1a28d12 100644
@@ -99,10 +99,12 @@ &uart3 {
 };
 
 &usbh1 {
+	disable-over-current;
 	status = "okay";
 };
 
 &usbotg {
+	disable-over-current;
 	status = "okay";
 };
 
arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts +2 -0
index a02981d4a3fc..f50a26dd34c0 100644
@@ -111,10 +111,12 @@ &uart3 {
 };
 
 &usbh1 {
+	disable-over-current;
 	status = "okay";
 };
 
 &usbotg {
+	disable-over-current;
 	status = "okay";
 };
 
arch/arm/boot/dts/imx6dl-colibri-iris.dts +2 -0
index c5797ff35b71..4303c88bb2a9 100644
@@ -138,10 +138,12 @@ &uart3 {
 };
 
 &usbh1 {
+	disable-over-current;
 	status = "okay";
 };
 
 &usbotg {
+	disable-over-current;
 	status = "okay";
 };
 
arch/arm/boot/dts/imx6qdl-colibri.dtsi +0 -1
index d8f985f297e4..f894d6907604 100644
@@ -684,7 +684,6 @@ &usbh1 {
 
 /* Colibri USBC */
 &usbotg {
-	disable-over-current;
 	dr_mode = "otg";
 	extcon = <0>, <&extcon_usbc_det>;
 	status = "disabled";
Signature · 7 lines
2.38.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#3 lore raw

PATCH 3/5 ARM: dts: colibri-imx6ull: Disable usb over-current

In reply to Philippe Schenker

From: Philippe Schenker <[email protected]>

Disable usb over-current of the chipidea driver on all Carrier-Boards used by Toradex. Do this as we don't want to use this functionality on our Carrier Boards and to leave it open to someone who includes our module-level device-trees.

This will prevent the warning "No over current polarity defined" from being printed on boot.

---

 arch/arm/boot/dts/imx6ull-colibri-aster.dtsi   | 2 ++
 arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi | 2 ++
 arch/arm/boot/dts/imx6ull-colibri-iris.dtsi    | 2 ++
 3 files changed, 6 insertions(+)
arch/arm/boot/dts/imx6ull-colibri-aster.dtsi +2 -0
index c9133ba2d705..de4dc7c1a03a 100644
@@ -130,11 +130,13 @@ &uart5 {
 };
 
 &usbotg1 {
+	disable-over-current;
 	vbus-supply = <&reg_usbh_vbus>;
 	status = "okay";
 };
 
 &usbotg2 {
+	disable-over-current;
 	vbus-supply = <&reg_usbh_vbus>;
 	status = "okay";
 };
arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi +2 -0
index e29907428c20..692ef26fbab3 100644
@@ -106,11 +106,13 @@ &uart5 {
 };
 
 &usbotg1 {
+	disable-over-current;
 	vbus-supply = <&reg_usbh_vbus>;
 	status = "okay";
 };
 
 &usbotg2 {
+	disable-over-current;
 	vbus-supply = <&reg_usbh_vbus>;
 	status = "okay";
 };
arch/arm/boot/dts/imx6ull-colibri-iris.dtsi +2 -0
index 166a0aefc869..f52f8b5ad8a6 100644
@@ -117,11 +117,13 @@ &uart5 {
 };
 
 &usbotg1 {
+	disable-over-current;
 	vbus-supply = <&reg_usbh_vbus>;
 	status = "okay";
 };
 
 &usbotg2 {
+	disable-over-current;
 	vbus-supply = <&reg_usbh_vbus>;
 	status = "okay";
 };
Signature · 7 lines
2.38.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#4 lore raw

PATCH 4/5 ARM: dts: colibri-imx7: Disable usb over-current

In reply to Philippe Schenker

From: Philippe Schenker <[email protected]>

Disable usb over-current of the chipidea driver on all Carrier-Boards used by Toradex. Do this as we don't want to use this functionality on our Carrier Boards and to leave it open to someone who includes our module-level device-trees.

This will prevent the warning "No over current polarity defined" from being printed on boot.

---

 arch/arm/boot/dts/imx7-colibri-aster.dtsi        | 1 +
 arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi      | 1 +
 arch/arm/boot/dts/imx7-colibri-iris-v2.dtsi      | 1 +
 arch/arm/boot/dts/imx7-colibri-iris.dtsi         | 1 +
 arch/arm/boot/dts/imx7d-colibri-aster.dts        | 1 +
 arch/arm/boot/dts/imx7d-colibri-emmc-aster.dts   | 1 +
 arch/arm/boot/dts/imx7d-colibri-emmc-eval-v3.dts | 1 +
 arch/arm/boot/dts/imx7d-colibri-emmc-iris-v2.dts | 1 +
 arch/arm/boot/dts/imx7d-colibri-emmc-iris.dts    | 1 +
 arch/arm/boot/dts/imx7d-colibri-emmc.dtsi        | 1 +
 arch/arm/boot/dts/imx7d-colibri-eval-v3.dts      | 1 +
 arch/arm/boot/dts/imx7d-colibri-iris-v2.dts      | 1 +
 arch/arm/boot/dts/imx7d-colibri-iris.dts         | 1 +
 13 files changed, 13 insertions(+)
arch/arm/boot/dts/imx7-colibri-aster.dtsi +1 -0
index fa488a6de0d4..01612741f792 100644
@@ -70,6 +70,7 @@ &uart3 {
 
 /* Colibri USBC */
 &usbotg1 {
+	disable-over-current;
 	status = "okay";
 };
 
arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi +1 -0
index 826f13da5b81..326440f2b4f4 100644
@@ -101,6 +101,7 @@ &uart3 {
 
 /* Colibri USBC */
 &usbotg1 {
+	disable-over-current;
 	status = "okay";
 };
 
arch/arm/boot/dts/imx7-colibri-iris-v2.dtsi +1 -0
index 6e199613583c..b687727f956a 100644
@@ -99,6 +99,7 @@ &uart3 {
 
 /* Colibri USBC */
 &usbotg1 {
+	disable-over-current;
 	status = "okay";
 };
 
arch/arm/boot/dts/imx7-colibri-iris.dtsi +1 -0
index 175c5d478d2e..6a9e5ab59691 100644
@@ -99,6 +99,7 @@ &uart3 {
 
 /* Colibri USBC */
 &usbotg1 {
+	disable-over-current;
 	status = "okay";
 };
 
arch/arm/boot/dts/imx7d-colibri-aster.dts +1 -0
index 90aaeddfb4f6..00ab92e56da4 100644
@@ -36,5 +36,6 @@ &panel_dpi {
 
 /* Colibri USBH */
 &usbotg2 {
+	disable-over-current;
 	status = "okay";
 };
arch/arm/boot/dts/imx7d-colibri-emmc-aster.dts +1 -0
index 3ec9ef6baaa4..d9c7045a55ba 100644
@@ -18,5 +18,6 @@ / {
 
 /* Colibri USBH */
 &usbotg2 {
+	disable-over-current;
 	status = "okay";
 };
arch/arm/boot/dts/imx7d-colibri-emmc-eval-v3.dts +1 -0
index 6d505cb02aad..96b599439dde 100644
@@ -17,5 +17,6 @@ / {
 
 /* Colibri USBH */
 &usbotg2 {
+	disable-over-current;
 	status = "okay";
 };
arch/arm/boot/dts/imx7d-colibri-emmc-iris-v2.dts +1 -0
index 7347659557f3..5eccb837b158 100644
@@ -17,5 +17,6 @@ / {
 
 /* Colibri USBH */
 &usbotg2 {
+	disable-over-current;
 	status = "okay";
 };
arch/arm/boot/dts/imx7d-colibri-emmc-iris.dts +1 -0
index 5324c92e368d..ae10e8a66ff1 100644
@@ -17,5 +17,6 @@ / {
 
 /* Colibri USBH */
 &usbotg2 {
+	disable-over-current;
 	status = "okay";
 };
arch/arm/boot/dts/imx7d-colibri-emmc.dtsi +1 -0
index 2fb4d2133a1b..3740e34ef99f 100644
@@ -51,6 +51,7 @@ &gpio6 {
 
 /* Colibri USBH */
 &usbotg2 {
+	disable-over-current;
 	dr_mode = "host";
 	vbus-supply = <&reg_usbh_vbus>;
 };
arch/arm/boot/dts/imx7d-colibri-eval-v3.dts +1 -0
index c7a8b5aa2408..33d787617db0 100644
@@ -52,5 +52,6 @@ &pwm3 {
 
 /* Colibri USBH */
 &usbotg2 {
+	disable-over-current;
 	status = "okay";
 };
arch/arm/boot/dts/imx7d-colibri-iris-v2.dts +1 -0
index 5762f51d5f0f..afdb1d06c7f6 100644
@@ -79,5 +79,6 @@ &panel_dpi {
 
 /* Colibri USBH */
 &usbotg2 {
+	disable-over-current;
 	status = "okay";
 };
arch/arm/boot/dts/imx7d-colibri-iris.dts +1 -0
index 9c63cb9d9a64..531b0b99bd5a 100644
@@ -52,5 +52,6 @@ &pwm3 {
 
 /* Colibri USBH */
 &usbotg2 {
+	disable-over-current;
 	status = "okay";
 };
Signature · 7 lines
2.38.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#5 lore raw

PATCH 5/5 arm64: dts: verdin-imx8mm: Disable usb over-current

In reply to Philippe Schenker

From: Philippe Schenker <[email protected]>

Disable usb over-current of the chipidea driver on all Carrier-Boards used by Toradex. Do this as we don't want to use this functionality on our Carrier Boards and to leave it open to someone who includes our module-level device-trees.

Remove the now obsolete disable-over-current flag from module-level device-tree imx8mm-verdin.dtsi and leave it as already mentioned to the people actually implementing the carrier-board to implement this.

This will prevent the warning "No over current polarity defined" from being printed on boot.

---

 arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi | 2 ++
 arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi        | 2 --
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi +2 -0
index c2a5c2f7b204..0360f6a08d30 100644
@@ -136,11 +136,13 @@ &uart3 {
 
 /* Verdin USB_1 */
 &usbotg1 {
+	disable-over-current;
 	status = "okay";
 };
 
 /* Verdin USB_2 */
 &usbotg2 {
+	disable-over-current;
 	status = "okay";
 };
 
arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi +0 -2
index 0d454e0e2f7c..0680cee9aeb0 100644
@@ -741,7 +741,6 @@ &usbotg1 {
 	adp-disable;
 	dr_mode = "otg";
 	hnp-disable;
-	over-current-active-low;
 	samsung,picophy-dc-vol-level-adjust = <7>;
 	samsung,picophy-pre-emp-curr-control = <3>;
 	srp-disable;
@@ -751,7 +750,6 @@ &usbotg1 {
 /* Verdin USB_2 */
 &usbotg2 {
 	dr_mode = "host";
-	over-current-active-low;
 	samsung,picophy-dc-vol-level-adjust = <7>;
 	samsung,picophy-pre-emp-curr-control = <3>;
 	vbus-supply = <&reg_usb_otg2_vbus>;
Signature · 7 lines
2.38.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Applied
#6 lore raw
In reply to Philippe Schenker
Quoted 12 lines · Philippe Schenker

From: Philippe Schenker <[email protected]>

This patchset intends to disable the USB Over Current for Toradex i.MX boards using the USB chipidea driver.

We do this on the Carrier-Board device-trees due to the reason, that if a customer of us inheriting the module-level device-tree (named -.dtsi) does not inherit settings from us that may be incorrect for his use-case.

Quoted 6 lines

Philippe Schenker (5):
ARM: dts: apalis-imx6: Disable usb over-current
ARM: dts: colibri-imx6: Disable usb over-current
ARM: dts: colibri-imx6ull: Disable usb over-current
ARM: dts: colibri-imx7: Disable usb over-current
arm64: dts: verdin-imx8mm: Disable usb over-current

Applied all, thanks!