Skip to contentSkip to conversation

soc: imx8m: Fix incorrect check for of_clk_get_by_name()

PATCH New Miaoqian Lin 1 participant 1 message Dec 31, 2022 Arm i.MX and Layerscape

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc: imx8m: Fix incorrect check for of_clk_get_by_name()

of_clk_get_by_name() returns error pointers instead of NULL. Use IS_ERR() checks the return value to catch errors.

Fixes 836fb30949d9 ("soc: imx8m: Enable OCOTP clock before reading the register")
---
 drivers/soc/imx/soc-imx8m.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/soc/imx/soc-imx8m.c +2 -2
index 28144c699b0c..32ed9dc88e45 100644
@@ -66,8 +66,8 @@ static u32 __init imx8mq_soc_revision(void)
 	ocotp_base = of_iomap(np, 0);
 	WARN_ON(!ocotp_base);
 	clk = of_clk_get_by_name(np, NULL);
-	if (!clk) {
-		WARN_ON(!clk);
+	if (IS_ERR(clk)) {
+		WARN_ON(IS_ERR(clk));
 		return 0;
 	}
 
Signature · 1 line
2.25.1