Skip to contentSkip to conversation

package/qemu: allow building only the tools

PATCH Applied [email protected] 2 participants 2 messages Dec 31, 2022 – Jan 1, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/qemu: allow building only the tools

From: Carlos Santos <[email protected]>

Commit 44be514b21fd94096702b80c62d46c31d72f15a5 mistakenly forced to always build at least user or system emulation but it must be possible to choose only the tools (e.g. for a guest VM image).

---
 package/qemu/Config.in | 1 -
 1 file changed, 1 deletion(-)
package/qemu/Config.in +0 -1
index 0f9e353510..435e92781c 100644
@@ -27,7 +27,6 @@ menuconfig BR2_PACKAGE_QEMU
 	select BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_PIXMAN
 	select BR2_PACKAGE_ZLIB
-	select BR2_PACKAGE_QEMU_SYSTEM if !BR2_PACKAGE_QEMU_LINUX_USER
 	help
 	  QEMU is a generic and open source machine emulator and
 	  virtualizer.
Signature · 6 lines
2.31.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

On 2022-12-31 17:17 -0300, [email protected] spake thusly:

Quoted 16 lines

From: Carlos Santos <[email protected]>

Commit 44be514b21fd94096702b80c62d46c31d72f15a5 mistakenly forced to always build at least user or system emulation but it must be possible to choose only the tools (e.g. for a guest VM image).

---
 package/qemu/Config.in | 1 -
 1 file changed, 1 deletion(-)
package/qemu/Config.in +0 -0
index 0f9e353510..435e92781c 100644

package/qemu/Config.in menuconfig BR2_PACKAGE_QEMU · line 30

Quoted 4 lines
package/qemu/Config.in +0 -1
@@ -27,7 +27,6 @@ menuconfig BR2_PACKAGE_QEMU
 	select BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_PIXMAN
 	select BR2_PACKAGE_ZLIB
-	select BR2_PACKAGE_QEMU_SYSTEM if !BR2_PACKAGE_QEMU_LINUX_USER

But then, we're back to a situation where we can have qemu enabled, but we're building neither the the system nor user emulation, nor the tools, which does not make sense.

So, I've changed that to force the tools if neither system nor user emulation is enabled.

Applied to master, thanks.

Note: in fact, even with all disabled, qemu still installs its binary blobs, which does not make much sense, so that does not count. Also, I was pretty sure we had an option for that, but it turns out that my commit [0] did not make it when I initially worked on this, 10 years ago [1]... Funny how memory can be flaky. :-) And of course, the option has changed since then. Sigh... I guess I'll have to respin this...

[0] https://gitlab.com/ymorin/buildroot/-/commit/1b87393f67d7fad5dcd1e2390e4f65cd2d865cab
[1] https://lore.kernel.org/buildroot/?q=s%3A%22add+option+to+not+install+blobs%22

Regards,
Yann E. MORIN.

Quoted 10 lines
package/qemu/Config.in +0 -0
 	help
 	  QEMU is a generic and open source machine emulator and
 	  virtualizer.
Signature · 6 lines
2.31.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot