Skip to contentSkip to conversation

m25p80: Add the is25wp256 SFPD table

PATCH In review Guenter Roeck 5 participants 10 messages Dec 21, 2022 – Jan 2, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 m25p80: Add the is25wp256 SFPD table

Generated from hardware using the following command and then padding with 0xff to fill out a power-of-2:

	xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
Cc Michael Walle <[email protected]>
Cc Tudor Ambarus <[email protected]>
---
 hw/block/m25p80.c      |  3 ++-
 hw/block/m25p80_sfdp.c | 40 ++++++++++++++++++++++++++++++++++++++++
 hw/block/m25p80_sfdp.h |  2 ++
 3 files changed, 44 insertions(+), 1 deletion(-)
hw/block/m25p80.c +2 -1
index 02adc87527..802d2eb021 100644
@@ -221,7 +221,8 @@ static const FlashPartInfo known_devices[] = {
     { INFO("is25wp032",   0x9d7016,      0,  64 << 10,  64, ER_4K) },
     { INFO("is25wp064",   0x9d7017,      0,  64 << 10, 128, ER_4K) },
     { INFO("is25wp128",   0x9d7018,      0,  64 << 10, 256, ER_4K) },
-    { INFO("is25wp256",   0x9d7019,      0,  64 << 10, 512, ER_4K) },
+    { INFO("is25wp256",   0x9d7019,      0,  64 << 10, 512, ER_4K),
+      .sfdp_read = m25p80_sfdp_is25wp256 },
 
     /* Macronix */
     { INFO("mx25l2005a",  0xc22012,      0,  64 << 10,   4, ER_4K) },
hw/block/m25p80_sfdp.c +40 -0
index 77615fa29e..b33811a4f5 100644
@@ -330,3 +330,43 @@ static const uint8_t sfdp_w25q01jvq[] = {
     0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
 };
 define_sfdp_read(w25q01jvq);
+
+/*
+ * Integrated Silicon Solution (ISSI)
+ */
+
+static const uint8_t sfdp_is25wp256[] = {
+    0x53, 0x46, 0x44, 0x50, 0x06, 0x01, 0x01, 0xff,
+    0x00, 0x06, 0x01, 0x10, 0x30, 0x00, 0x00, 0xff,
+    0x9d, 0x05, 0x01, 0x03, 0x80, 0x00, 0x00, 0x02,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xe5, 0x20, 0xf9, 0xff, 0xff, 0xff, 0xff, 0x0f,
+    0x44, 0xeb, 0x08, 0x6b, 0x08, 0x3b, 0x80, 0xbb,
+    0xfe, 0xff, 0xff, 0xff, 0xff, 0xff, 0x00, 0xff,
+    0xff, 0xff, 0x44, 0xeb, 0x0c, 0x20, 0x0f, 0x52,
+    0x10, 0xd8, 0x00, 0xff, 0x23, 0x4a, 0xc9, 0x00,
+    0x82, 0xd8, 0x11, 0xce, 0xcc, 0xcd, 0x68, 0x46,
+    0x7a, 0x75, 0x7a, 0x75, 0xf7, 0xae, 0xd5, 0x5c,
+    0x4a, 0x42, 0x2c, 0xff, 0xf0, 0x30, 0xfa, 0xa9,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0x50, 0x19, 0x50, 0x16, 0x9f, 0xf9, 0xc0, 0x64,
+    0x8f, 0xef, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+};
+define_sfdp_read(is25wp256);
hw/block/m25p80_sfdp.h +2 -0
index df7adfb5ce..011a880f66 100644
@@ -26,4 +26,6 @@ uint8_t m25p80_sfdp_w25q512jv(uint32_t addr);
 
 uint8_t m25p80_sfdp_w25q01jvq(uint32_t addr);
 
+uint8_t m25p80_sfdp_is25wp256(uint32_t addr);
+
 #endif
Signature · 1 line
2.36.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Guenter Roeck

Generated from hardware using the following command and then padding with 0xff to fill out a power-of-2:

	xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
Cc Michael Walle <[email protected]>
Cc Tudor Ambarus <[email protected]>

Thanks,

C.

Quoted 79 lines
---
  hw/block/m25p80.c      |  3 ++-
  hw/block/m25p80_sfdp.c | 40 ++++++++++++++++++++++++++++++++++++++++
  hw/block/m25p80_sfdp.h |  2 ++
  3 files changed, 44 insertions(+), 1 deletion(-)
hw/block/m25p80.c +2 -1
index 02adc87527..802d2eb021 100644
@@ -221,7 +221,8 @@ static const FlashPartInfo known_devices[] = {
      { INFO("is25wp032",   0x9d7016,      0,  64 << 10,  64, ER_4K) },
      { INFO("is25wp064",   0x9d7017,      0,  64 << 10, 128, ER_4K) },
      { INFO("is25wp128",   0x9d7018,      0,  64 << 10, 256, ER_4K) },
-    { INFO("is25wp256",   0x9d7019,      0,  64 << 10, 512, ER_4K) },
+    { INFO("is25wp256",   0x9d7019,      0,  64 << 10, 512, ER_4K),
+      .sfdp_read = m25p80_sfdp_is25wp256 },
 
      /* Macronix */
      { INFO("mx25l2005a",  0xc22012,      0,  64 << 10,   4, ER_4K) },
hw/block/m25p80_sfdp.c +40 -0
index 77615fa29e..b33811a4f5 100644
@@ -330,3 +330,43 @@ static const uint8_t sfdp_w25q01jvq[] = {
      0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
  };
  define_sfdp_read(w25q01jvq);
+
+/*
+ * Integrated Silicon Solution (ISSI)
+ */
+
+static const uint8_t sfdp_is25wp256[] = {
+    0x53, 0x46, 0x44, 0x50, 0x06, 0x01, 0x01, 0xff,
+    0x00, 0x06, 0x01, 0x10, 0x30, 0x00, 0x00, 0xff,
+    0x9d, 0x05, 0x01, 0x03, 0x80, 0x00, 0x00, 0x02,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xe5, 0x20, 0xf9, 0xff, 0xff, 0xff, 0xff, 0x0f,
+    0x44, 0xeb, 0x08, 0x6b, 0x08, 0x3b, 0x80, 0xbb,
+    0xfe, 0xff, 0xff, 0xff, 0xff, 0xff, 0x00, 0xff,
+    0xff, 0xff, 0x44, 0xeb, 0x0c, 0x20, 0x0f, 0x52,
+    0x10, 0xd8, 0x00, 0xff, 0x23, 0x4a, 0xc9, 0x00,
+    0x82, 0xd8, 0x11, 0xce, 0xcc, 0xcd, 0x68, 0x46,
+    0x7a, 0x75, 0x7a, 0x75, 0xf7, 0xae, 0xd5, 0x5c,
+    0x4a, 0x42, 0x2c, 0xff, 0xf0, 0x30, 0xfa, 0xa9,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0x50, 0x19, 0x50, 0x16, 0x9f, 0xf9, 0xc0, 0x64,
+    0x8f, 0xef, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+};
+define_sfdp_read(is25wp256);
hw/block/m25p80_sfdp.h +2 -0
index df7adfb5ce..011a880f66 100644
@@ -26,4 +26,6 @@ uint8_t m25p80_sfdp_w25q512jv(uint32_t addr);
 
  uint8_t m25p80_sfdp_w25q01jvq(uint32_t addr);
 
+uint8_t m25p80_sfdp_is25wp256(uint32_t addr);
+
  #endif
#2 lore raw
Quoted 10 lines · Cédric Le Goater
Quoted 7 lines · Guenter Roeck

Generated from hardware using the following command and then padding with 0xff to fill out a power-of-2:

	xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
Cc Michael Walle <[email protected]>
Cc Tudor Ambarus <[email protected]>

If SFDP is a standard, couldn't we have an function to generate it from the flash parameters?

Signature · 3 lines
Ben Dooks, [email protected], http://www.fluff.org/ben/

Large Hadron Colada: A large Pina Colada that makes the universe disappear.
#3 lore raw
Quoted 6 lines · Ben Dooks
Quoted 5 lines · Cédric Le Goater
Quoted 4 lines · Guenter Roeck

Generated from hardware using the following command and then padding with 0xff to fill out a power-of-2:

	xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
Quoted 9 lines
Quoted 5 lines
Quoted 3 lines
Cc Michael Walle <[email protected]>
Cc Tudor Ambarus <[email protected]>

If SFDP is a standard, couldn't we have an function to generate it from the flash parameters?

No, it's not practical as you have to specify all the flash parameters at flash declaration.

#4 lore raw
Quoted 13 lines · Tudor Ambarus
Quoted 10 lines · Ben Dooks
Quoted 9 lines · Cédric Le Goater
Quoted 7 lines · Guenter Roeck

Generated from hardware using the following command and then padding with 0xff to fill out a power-of-2:
    xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp

Cc Michael Walle <[email protected]>
Cc Tudor Ambarus <[email protected]>
Quoted 8 lines
Quoted 5 lines
Quoted 1 line

If SFDP is a standard, couldn't we have an function to generate it from the flash parameters?

No, it's not practical as you have to specify all the flash parameters at flash declaration.

Indeed and the definition of flash models in QEMU is far to cover all the SFDP features. The known_devices array of m25p80 would be huge ! However, we could generate some of the SFDP tables if no raw data is provided. It could be useful for testing drivers.

Thanks,

C.

#5 lore raw

Am 2023-01-02 14:53, schrieb Cédric Le Goater:

Quoted 20 lines · Tudor Ambarus
Quoted 19 lines · Ben Dooks
Quoted 15 lines · Cédric Le Goater
Quoted 10 lines · Guenter Roeck
Quoted 7 lines

Generated from hardware using the following command and then padding with 0xff to fill out a power-of-2:
    xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp

Cc Michael Walle <[email protected]>
Cc Tudor Ambarus <[email protected]>

If SFDP is a standard, couldn't we have an function to generate it from the flash parameters?

Quoted 7 lines
Quoted 2 lines

No, it's not practical as you have to specify all the flash parameters at flash declaration.

Indeed and the definition of flash models in QEMU is far to cover all the SFDP features. The known_devices array of m25p80 would be huge ! However, we could generate some of the SFDP tables if no raw data is provided. It could be useful for testing drivers.

I don't think adding (incomplete) SFDP tables makes sense for any real devices. E.g. sometimes our linux driver will look at specific bits in SFDP to figure out what particular flash device is attached. For example when there are different flashes with the same jedec id.

But since the last released kernel, we support a generic SFDP driver, which is used when there is no matching driver for the flash's jedec id. Theoretically, you can build your own flash device (with a unique id) and generate the sfdp tables for that one.

-michael

#6 lore raw
Quoted 39 lines · Michael Walle

Am 2023-01-02 14:53, schrieb Cédric Le Goater:

Quoted 25 lines · Tudor Ambarus
Quoted 16 lines · Ben Dooks
Quoted 13 lines · Cédric Le Goater
Quoted 11 lines · Guenter Roeck
Quoted 8 lines

Generated from hardware using the following command and then padding
with 0xff to fill out a power-of-2:
    xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp

Cc Michael Walle <[email protected]>
Cc Tudor Ambarus <[email protected]>
Quoted 7 lines
Quoted 4 lines

If SFDP is a standard, couldn't we have an function to generate it from
the flash parameters?

No, it's not practical as you have to specify all the flash parameters at flash declaration.

Quoted 7 lines

Indeed and the definition of flash models in QEMU is far to cover all the SFDP
features. The known_devices array of m25p80 would be huge ! However, we could
generate some of the SFDP tables if no raw data is provided. It could be useful
for testing drivers.

I don't think adding (incomplete) SFDP tables makes sense for any real devices. E.g. sometimes our linux driver will look at specific bits in SFDP to figure out what particular flash device is attached. For example when there are different flashes with the same jedec id.

Quoted 5 lines

But since the last released kernel, we support a generic SFDP driver, which is used when there is no matching driver for the flash's jedec id. Theoretically, you can build your own flash device (with a unique id) and generate the sfdp tables for that one.

How about older kernels versions ? Would those still support such (virtual ?) flash devices ?

Thanks,
Guenter

#7 lore raw

Am 2023-01-02 17:23, schrieb Guenter Roeck:

Quoted 40 lines · Michael Walle
Quoted 39 lines

Am 2023-01-02 14:53, schrieb Cédric Le Goater:

Quoted 25 lines · Tudor Ambarus
Quoted 16 lines · Ben Dooks
Quoted 13 lines · Cédric Le Goater
Quoted 11 lines · Guenter Roeck
Quoted 8 lines

Generated from hardware using the following command and then padding
with 0xff to fill out a power-of-2:
    xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp

Cc Michael Walle <[email protected]>
Cc Tudor Ambarus <[email protected]>
Quoted 7 lines
Quoted 4 lines

If SFDP is a standard, couldn't we have an function to generate it from
the flash parameters?

No, it's not practical as you have to specify all the flash parameters at flash declaration.

Quoted 7 lines

Indeed and the definition of flash models in QEMU is far to cover all the SFDP
features. The known_devices array of m25p80 would be huge ! However, we could
generate some of the SFDP tables if no raw data is provided. It could be useful
for testing drivers.

I don't think adding (incomplete) SFDP tables makes sense for any real devices. E.g. sometimes our linux driver will look at specific bits in SFDP to figure out what particular flash device is attached. For example when there are different flashes with the same jedec id.

Quoted 7 lines
Quoted 5 lines

But since the last released kernel, we support a generic SFDP driver, which is used when there is no matching driver for the flash's jedec id. Theoretically, you can build your own flash device (with a unique id) and generate the sfdp tables for that one.

How about older kernels versions ? Would those still support such (virtual ?) flash devices ?

No with older kernels you'd be out of luck. They will just print "unknown flash id" and skip the device.

-michael

#8 lore raw
Quoted 49 lines · Michael Walle

Am 2023-01-02 17:23, schrieb Guenter Roeck:

Quoted 48 lines · Michael Walle
Quoted 47 lines

Am 2023-01-02 14:53, schrieb Cédric Le Goater:

Quoted 25 lines · Tudor Ambarus
Quoted 16 lines · Ben Dooks
Quoted 13 lines · Cédric Le Goater
Quoted 11 lines · Guenter Roeck
Quoted 8 lines

Generated from hardware using the following command and then padding
with 0xff to fill out a power-of-2:
    xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp

Cc Michael Walle <[email protected]>
Cc Tudor Ambarus <[email protected]>
Quoted 7 lines
Quoted 4 lines

If SFDP is a standard, couldn't we have an function to generate it from
the flash parameters?

No, it's not practical as you have to specify all the flash parameters at flash declaration.

Quoted 7 lines

Indeed and the definition of flash models in QEMU is far to cover all the SFDP
features. The known_devices array of m25p80 would be huge ! However, we could
generate some of the SFDP tables if no raw data is provided. It could be useful
for testing drivers.

I don't think adding (incomplete) SFDP tables makes sense for any real devices. E.g. sometimes our linux driver will look at specific bits in SFDP to figure out what particular flash device is attached. For example
when there are different flashes with the same jedec id.

But since the last released kernel, we support a generic SFDP driver, which
is used when there is no matching driver for the flash's jedec id. Theoretically, you can build your own flash device (with a unique id) and
generate the sfdp tables for that one.

Quoted 7 lines
Quoted 3 lines

How about older kernels versions ? Would those still support such (virtual ?)
flash devices ?

No with older kernels you'd be out of luck. They will just print "unknown flash
id" and skip the device.

That would mean that qemu versions including this change could no longer be used to test flash support on older kernel versions. That would be extremely undesirable. I'd rather live with the current code and still be able to test older kernels.

Thanks,
Guenter

#9 lore raw

Am 2023-01-02 19:49, schrieb Guenter Roeck:

Quoted 54 lines · Michael Walle
Quoted 53 lines

Am 2023-01-02 17:23, schrieb Guenter Roeck:

Quoted 51 lines · Michael Walle
Quoted 40 lines

Am 2023-01-02 14:53, schrieb Cédric Le Goater:

Quoted 25 lines · Tudor Ambarus
Quoted 16 lines · Ben Dooks
Quoted 13 lines · Cédric Le Goater
Quoted 11 lines · Guenter Roeck
Quoted 8 lines

Generated from hardware using the following command and then padding
with 0xff to fill out a power-of-2:
    xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp

Cc Michael Walle <[email protected]>
Cc Tudor Ambarus <[email protected]>
Quoted 7 lines
Quoted 4 lines

If SFDP is a standard, couldn't we have an function to generate it from
the flash parameters?

No, it's not practical as you have to specify all the flash parameters at flash declaration.

Quoted 7 lines

Indeed and the definition of flash models in QEMU is far to cover all the SFDP
features. The known_devices array of m25p80 would be huge ! However, we could
generate some of the SFDP tables if no raw data is provided. It could be useful
for testing drivers.

I don't think adding (incomplete) SFDP tables makes sense for any real devices. E.g. sometimes our linux driver will look at specific bits in SFDP to figure out what particular flash device is attached. For example
when there are different flashes with the same jedec id.

Quoted 7 lines

But since the last released kernel, we support a generic SFDP driver, which
is used when there is no matching driver for the flash's jedec id. Theoretically, you can build your own flash device (with a unique id) and
generate the sfdp tables for that one.

How about older kernels versions ? Would those still support such (virtual ?)
flash devices ?

Quoted 8 lines
Quoted 3 lines

No with older kernels you'd be out of luck. They will just print "unknown flash
id" and skip the device.

That would mean that qemu versions including this change could no longer be used to test flash support on older kernel versions. That would be extremely undesirable. I'd rather live with the current code and still be able to test older kernels.

Your board wouldn't need to use it. I don't think that emulating a real spi flash device would go away. But it might still make sense to have such a flash device, one example already mentioned is for testing drivers.

-michael