drm/mipi-dsi: Fix mipi_dsi_dcs_write_seq() macro definition format
Subsystems (2)
PATCH v2 1/2 drm/mipi-dsi: Fix mipi_dsi_dcs_write_seq() macro definition format
Change made using a clang-format -i include/drm/drm_mipi_dsi.h command.
---
Changes in v2:
- New patch in v2.
include/drm/drm_mipi_dsi.h | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-)
include/drm/drm_mipi_dsi.h +12 -9
@@ -303,15 +303,18 @@ int mipi_dsi_dcs_get_display_brightness(struct mipi_dsi_device *dsi,* @cmd: Command * @seq: buffer containing data to be transmitted */ -#define mipi_dsi_dcs_write_seq(dsi, cmd, seq...) do { \ - static const u8 d[] = { cmd, seq }; \ - struct device *dev = &dsi->dev; \ - int ret; \ - ret = mipi_dsi_dcs_write_buffer(dsi, d, ARRAY_SIZE(d)); \ - if (ret < 0) { \ - dev_err_ratelimited(dev, "sending command %#02x failed: %d\n", cmd, ret); \ - return ret; \ - } \ +#define mipi_dsi_dcs_write_seq(dsi, cmd, seq...) \ + do { \ + static const u8 d[] = { cmd, seq }; \ + struct device *dev = &dsi->dev; \ + int ret; \ + ret = mipi_dsi_dcs_write_buffer(dsi, d, ARRAY_SIZE(d)); \ + if (ret < 0) { \ + dev_err_ratelimited( \ + dev, "sending command %#02x failed: %d\n", \ + cmd, ret); \ + return ret; \ + } \ } while (0)/**
Signature · 1 line
2.38.1
PATCH v2 2/2 drm/mipi-dsi: Add a mipi_dsi_dcs_write_seq() macro
Many panel drivers define dsi_dcs_write_seq() and dsi_generic_write_seq() macros to send DCS commands and generic write packets respectively, with the payload specified as a list of parameters instead of using arrays.
There's already a macro for the former, introduced by commit 2a9e9daf75231 ("drm/mipi-dsi: Introduce mipi_dsi_dcs_write_seq macro") so drivers can be changed to use that. But there isn't one yet for the latter, let's add it.
---
Changes in v2:
- Fix kernel-doc macro name (kernel test robot, Sam Ravnborg)
- Add Sam Ravnborg's Reviewed-by tag.
include/drm/drm_mipi_dsi.h | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
include/drm/drm_mipi_dsi.h +18 -0
@@ -297,6 +297,24 @@ int mipi_dsi_dcs_set_display_brightness(struct mipi_dsi_device *dsi,int mipi_dsi_dcs_get_display_brightness (struct mipi_dsi_device *dsi,u16 *brightness); +/** +* mipi_dsi_generic_write_seq - transmit data using a generic write packet +* @dsi: DSI peripheral device +* @seq: buffer containing the payload +*/ +#define mipi_dsi_generic_write_seq(dsi, seq...) \ + do { \ + static const u8 d[] = { seq }; \ + struct device *dev = &dsi->dev; \ + int ret; \ + ret = mipi_dsi_generic_write(dsi, d, ARRAY_SIZE(d)); \ + if (ret < 0) { \ + dev_err_ratelimited(dev, "transmit data failed: %d\n", \ + ret); \ + return ret; \ + } \ + } while (0) +/** * mipi_dsi_dcs_write_seq - transmit a DCS command with payload * @dsi: DSI peripheral device
Signature · 1 line
2.38.1
Javier Martinez Canillas
AppliedRe: [PATCH v2 2/2] drm/mipi-dsi: Add a mipi_dsi_dcs_write_seq() macro
Quoted 11 lines · Javier Martinez Canillas
Many panel drivers define
dsi_dcs_write_seq()anddsi_generic_write_seq()macros to send DCS commands and generic write packets respectively, with the payload specified as a list of parameters instead of using arrays.There's already a macro for the former, introduced by commit
2a9e9daf75231("drm/mipi-dsi: Introducemipi_dsi_dcs_write_seqmacro") so drivers can be changed to use that. But there isn't one yet for the latter, let's add it.Signed-off-by Javier Martinez Canillas <[email protected]>Reviewed-by Sam Ravnborg <[email protected]>---
Pushed to drm-misc (drm-misc-next). Thanks!
Signature · 5 lines
Best regards, Javier Martinez Canillas Core Platforms Red Hat
Quoted 4 lines · Javier Martinez Canillas
Change made using a
clang-format -i include/drm/drm_mipi_dsi.hcommand.Suggested-by Sam Ravnborg <[email protected]>Signed-off-by Javier Martinez Canillas <[email protected]>
Thanks,
Quoted 42 lines
---
Changes in v2:
- New patch in v2.include/drm/drm_mipi_dsi.h | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-)include/drm/drm_mipi_dsi.h +12
-9@@ -303,15 +303,18 @@ int mipi_dsi_dcs_get_display_brightness(struct mipi_dsi_device *dsi,* @cmd: Command * @seq: buffer containing data to be transmitted */ -#define mipi_dsi_dcs_write_seq(dsi, cmd, seq...) do { \ - static const u8 d[] = { cmd, seq }; \ - struct device *dev = &dsi->dev; \ - int ret; \ - ret = mipi_dsi_dcs_write_buffer(dsi, d, ARRAY_SIZE(d)); \ - if (ret < 0) { \ - dev_err_ratelimited(dev, "sending command %#02x failed: %d\n", cmd, ret); \ - return ret; \ - } \ +#define mipi_dsi_dcs_write_seq(dsi, cmd, seq...) \ + do { \ + static const u8 d[] = { cmd, seq }; \ + struct device *dev = &dsi->dev; \ + int ret; \ + ret = mipi_dsi_dcs_write_buffer(dsi, d, ARRAY_SIZE(d)); \ + if (ret < 0) { \ + dev_err_ratelimited( \ + dev, "sending command %#02x failed: %d\n", \ + cmd, ret); \ + return ret; \ + } \ } while (0)/** Signature · 1 line
2.38.1
Javier Martinez Canillas
AppliedQuoted 10 lines · Sam Ravnborg
Quoted 4 lines · Javier Martinez Canillas
Change made using a
clang-format -i include/drm/drm_mipi_dsi.hcommand.Suggested-by Sam Ravnborg <[email protected]>Signed-off-by Javier Martinez Canillas <[email protected]>Thanks,
Reviewed-by Sam Ravnborg <[email protected]>Quoted 1 line
---
Pushed to drm-misc (drm-misc-next). Thanks!
Signature · 5 lines
Best regards, Javier Martinez Canillas Core Platforms Red Hat