Skip to contentSkip to conversation

riscv: ae350: support openSBI 1.0+ which enable FW_PIC

PATCH Superseded Rick Chen 3 participants 3 messages Jan 3, 2023 – Jan 4, 2023

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Rick Chen

author
#0 lore raw

PATCH v2 1/1 riscv: ae350: support openSBI 1.0+ which enable FW_PIC

Original openSBI (without FW_PIC) will relocate itselt from 0x1000000 to 0x0. After openSBI added FW_PIC codes, it will not relocate any more and alaways run at 0x1000000. Hence, it may overlap with Kernel memory region. So it is necessary to change openSBI address from 0x1000000 to 0x0.

More details can refer to commit cb052d771200
("riscv: qemu: spl: Fix booting Linux kernel with OpenSBI 1.0+")

---

Changes in v2
- fix typo
- describe why is this change a must have

---

 board/AndesTech/ax25-ae350/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/AndesTech/ax25-ae350/Kconfig +1 -1
index 36b67f0b52..4bb33b0793 100644
@@ -25,7 +25,7 @@ config SPL_TEXT_BASE
 	default 0x800000
 
 config SPL_OPENSBI_LOAD_ADDR
-	default 0x01000000
+	default 0x00000000
 
 config SYS_FDT_BASE
 	hex

--
2.17.1

Reviewed-by on v2 1/1
#1 lore raw
Quoted 1 line · Rick Chen

Original openSBI (without FW_PIC) will relocate itselt

typo: itself

Quoted 2 lines

from 0x1000000 to 0x0. After openSBI added FW_PIC codes, it will not relocate any more and alaways run at 0x1000000.

typo: always

Quoted 7 lines

Hence, it may overlap with Kernel memory region. So it is necessary to change openSBI address from 0x1000000 to 0x0.

More details can refer to commit cb052d771200
("riscv: qemu: spl: Fix booting Linux kernel with OpenSBI 1.0+")

Quoted 27 lines

---

Changes in v2
- fix typo
- describe why is this change a must have

---

 board/AndesTech/ax25-ae350/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/AndesTech/ax25-ae350/Kconfig +1 -2
index 36b67f0b52..4bb33b0793 100644
@@ -25,7 +25,7 @@ config SPL_TEXT_BASE
 	default 0x800000
 
 config SPL_OPENSBI_LOAD_ADDR
-	default 0x01000000
+	default 0x00000000
 
 config SYS_FDT_BASE
 	hex
--

2.17.1

#2 lore raw

Hi Samuel

Quoted 4 lines · Rick Chen
Quoted 1 line

Original openSBI (without FW_PIC) will relocate itselt

typo: itself

OK, I will fix it.

Quoted 5 lines
Quoted 3 lines

from 0x1000000 to 0x0. After openSBI added FW_PIC codes, it will not relocate any more and alaways run at 0x1000000.

typo: always

OK, I will fix it.

Quoted 10 lines
Quoted 8 lines

Hence, it may overlap with Kernel memory region. So it is necessary to change openSBI address from 0x1000000 to 0x0.

More details can refer to commit cb052d771200
("riscv: qemu: spl: Fix booting Linux kernel with OpenSBI 1.0+")

Thank you for reviewing.

Best Regards,
Rick

Quoted 29 lines
Quoted 28 lines

---

Changes in v2
- fix typo
- describe why is this change a must have

---

 board/AndesTech/ax25-ae350/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/AndesTech/ax25-ae350/Kconfig +1 -2
index 36b67f0b52..4bb33b0793 100644
@@ -25,7 +25,7 @@ config SPL_TEXT_BASE
      default 0x800000
 
 config SPL_OPENSBI_LOAD_ADDR
-     default 0x01000000
+     default 0x00000000
 
 config SYS_FDT_BASE
      hex
--

2.17.1