Skip to contentSkip to conversation

gpudev: fix deadlocks when registering callback

PATCH Applied David Marchand 2 participants 3 messages Jan 3, 2023 – Jan 31, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpudev: fix deadlocks when registering callback

gpu_callback_lock was not released in some branches of the register helper.
While at it, set rte_errno in one branch.

Fixes 18cb07563165 ("gpudev: add event notification")
---
 lib/gpudev/gpudev.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
lib/gpudev/gpudev.c +4 -1
index 805719d00c..8f12abef23 100644
@@ -408,6 +408,7 @@ rte_gpu_callback_register(int16_t dev_id, enum rte_gpu_event event,
 					callback->function == function &&
 					callback->user_data == user_data) {
 				GPU_LOG(INFO, "callback already registered");
+				rte_rwlock_write_unlock(&gpu_callback_lock);
 				return 0;
 			}
 		}
@@ -415,7 +416,9 @@ rte_gpu_callback_register(int16_t dev_id, enum rte_gpu_event event,
 		callback = malloc(sizeof(*callback));
 		if (callback == NULL) {
 			GPU_LOG(ERR, "cannot allocate callback");
-			return -ENOMEM;
+			rte_rwlock_write_unlock(&gpu_callback_lock);
+			rte_errno = ENOMEM;
+			return -rte_errno;
 		}
 		callback->function = function;
 		callback->user_data = user_data;
Signature · 1 line
2.39.0
#1 lore raw

PATCH 1/1 gpudev: fix deadlocks when registering callback

Agree with the patch.
Thanks!