Skip to contentSkip to conversation

net/mlx5: fix irrelevant send skew devarg warning

PATCH In review Viacheslav Ovsiienko 2 participants 2 messages Jan 3, 2023 – Jan 8, 2023 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/mlx5: fix irrelevant send skew devarg warning

Since ConnectX-7 hardware supports the send scheduling on explicitly specified timestamp, if this feature support is detected by PMD the tx_skew devarg becomes applicable and appropriate warning should not be emitted.

Fixes 49e8797619e40 ("net/mlx5: support wait on time in Tx")
---
 drivers/net/mlx5/mlx5.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/mlx5/mlx5.c +2 -1
index e55be8720e..3ae35587b6 100644
@@ -1401,7 +1401,8 @@ mlx5_shared_dev_ctx_args_config(struct mlx5_dev_ctx_shared *sh,
 		rte_errno = ENODEV;
 		return -rte_errno;
 	}
-	if (!config->tx_pp && config->tx_skew) {
+	if (!config->tx_pp && config->tx_skew &&
+	    !sh->cdev->config.hca_attr.wait_on_time) {
 		DRV_LOG(WARNING,
 			"\"tx_skew\" doesn't affect without \"tx_pp\".");
 	}
Signature · 1 line
2.18.1
#1 lore raw

Hi,

Quoted 13 lines

-----Original Message-----
From: Slava Ovsiienko <[email protected]>
Sent: Tuesday, January 3, 2023 1:11 PM
To: [email protected]
Cc: Matan Azrad <[email protected]>; Raslan Darawsheh <[email protected]>; Ori Kam <[email protected]>; [email protected]
Subject: [PATCH] net/mlx5: fix irrelevant send skew devarg warning

Since ConnectX-7 hardware supports the send scheduling on explicitly specified timestamp, if this feature support is detected by PMD the tx_skew devarg becomes applicable and appropriate warning should not be emitted.

Quoted 4 lines
Fixes 49e8797619e40 ("net/mlx5: support wait on time in Tx")

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh