Skip to contentSkip to conversation

wifi: rtw89: fix potential leak in rtw89_append_probe_req_ie()

PATCH In review Ping-Ke Shih 2 participants 2 messages Jan 3, 2023 – Jan 16, 2023 Realtek wireless driver (rtw89)

lore
Share & tools
lore

Ping-Ke Shih

author maintainer
#0 lore raw

PATCH 1/1 wifi: rtw89: fix potential leak in rtw89_append_probe_req_ie()

From: Zong-Zhe Yang <[email protected]>

Do kfree_skb(new) before goto out to prevent potential leak.

Fixes 895907779752 ("rtw89: 8852a: add ieee80211_ops::hw_scan")
---
 drivers/net/wireless/realtek/rtw89/fw.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/wireless/realtek/rtw89/fw.c +3 -1
index 0328874a0d10e..466d8273bc2b1 100644
@@ -2676,8 +2676,10 @@ static int rtw89_append_probe_req_ie(struct rtw89_dev *rtwdev,
 
 		list_add_tail(&info->list, &scan_info->pkt_list[band]);
 		ret = rtw89_fw_h2c_add_pkt_offload(rtwdev, &info->id, new);
-		if (ret)
+		if (ret) {
+			kfree_skb(new);
 			goto out;
+		}
 
 		kfree_skb(new);
 	}
Signature · 1 line
2.25.1
#1 lore raw
Quoted 7 lines · Ping-Ke Shih

From: Zong-Zhe Yang <[email protected]>

Do kfree_skb(new) before goto out to prevent potential leak.

Fixes 895907779752 ("rtw89: 8852a: add ieee80211_ops::hw_scan")

Patch applied to wireless-next.git, thanks.

4a0e218cc9c4 wifi: rtw89: fix potential leak in rtw89_append_probe_req_ie()

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches