wifi: rtw89: fix potential leak in rtw89_append_probe_req_ie()
Ping-Ke Shih
maintainerPATCH 1/1 wifi: rtw89: fix potential leak in rtw89_append_probe_req_ie()
From: Zong-Zhe Yang <[email protected]>
Do kfree_skb(new) before goto out to prevent potential leak.
Fixes 895907779752 ("rtw89: 8852a: add ieee80211_ops::hw_scan")
Signed-off-by Zong-Zhe Yang <[email protected]>
Signed-off-by Ping-Ke Shih <[email protected]>
--- drivers/net/wireless/realtek/rtw89/fw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/wireless/realtek/rtw89/fw.c +3 -1
@@ -2676,8 +2676,10 @@ static int rtw89_append_probe_req_ie(struct rtw89_dev *rtwdev,list_add_tail (&info->list, &scan_info->pkt_list[band]); ret =rtw89_fw_h2c_add_pkt_offload (rtwdev, &info->id, new); -if (ret) +if (ret) { +kfree_skb (new); goto out; + }kfree_skb (new); }
Signature · 1 line
2.25.1
Quoted 7 lines · Ping-Ke Shih
From: Zong-Zhe Yang <[email protected]>
Do
kfree_skb(new)beforegoto outto prevent potential leak.Fixes 895907779752 ("rtw89: 8852a: add ieee80211_ops::hw_scan")Signed-off-by Zong-Zhe Yang <[email protected]>Signed-off-by Ping-Ke Shih <[email protected]>
Patch applied to wireless-next.git, thanks.
4a0e218cc9c4 wifi: rtw89: fix potential leak in rtw89_append_probe_req_ie()
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches