Skip to contentSkip to conversation

serial: linflexuart: remove redundant uart type _assignment_

PATCH Superseded lizhe 2 participants 2 messages Jan 3, 2023 TTY layer and serial drivers

v2 of 6 Superseded Latest is v6 →

lore
Share & tools
lore

lizhe

author
#0 lore raw

PATCH v2 1/1 serial: linflexuart: remove redundant uart type _assignment_

in linflex_config_port() the member variable type will be
assigned again. see linflex_connfig_port()

---
 drivers/tty/serial/fsl_linflexuart.c | 1 -
 1 file changed, 1 deletion(-)
drivers/tty/serial/fsl_linflexuart.c +0 -1
index 6fc21b6684e6..34400cc6ac7f 100644
@@ -837,7 +837,6 @@ static int linflex_probe(struct platform_device *pdev)
 		return PTR_ERR(sport->membase);
 
 	sport->dev = &pdev->dev;
-	sport->type = PORT_LINFLEXUART;
 	sport->iotype = UPIO_MEM;
 	sport->irq = platform_get_irq(pdev, 0);
 	sport->ops = &linflex_pops;
Signature · 1 line
2.17.1
#1 lore raw
Quoted 1 line · lizhe

in linflex_config_port() the member variable type will be

Rmoeve these extra spaces and start right from the leftmost column.

And don't include the underscores (_) into the shortlog around assignment. Jiri just used the underscores to highlight for you what he considered important part to be corrected.

Quoted 5 lines

assigned again. see linflex_connfig_port()

---

When sending version xx, please remember to include the list of changes made per version (they go here below the first --- marker, see mailinglist archives for format examples if you don't know that alread).

Signature · 1 line
 i.
Quoted 16 lines
 drivers/tty/serial/fsl_linflexuart.c | 1 -
 1 file changed, 1 deletion(-)
drivers/tty/serial/fsl_linflexuart.c +0 -1
index 6fc21b6684e6..34400cc6ac7f 100644
@@ -837,7 +837,6 @@ static int linflex_probe(struct platform_device *pdev)
 		return PTR_ERR(sport->membase);
 
 	sport->dev = &pdev->dev;
-	sport->type = PORT_LINFLEXUART;
 	sport->iotype = UPIO_MEM;
 	sport->irq = platform_get_irq(pdev, 0);
 	sport->ops = &linflex_pops;