Skip to contentSkip to conversation

Tinker board boot fix and Linux/U-Boot update

PATCH In review Giulio Benetti 2 participants 6 messages Jan 4, 2023 – Feb 10, 2023

lore
Share & tools
lore
#0 lore raw

cover Tinker board boot fix and Linux/U-Boot update

Hello All,

here is a patchset to fix boot of Tinker board and bump Linux/U-boot versions.
I don't know how it happened to have this board not booting up, probably while testing in parallel with vyasa I've skipped the last test before sending the previous patch that bumped Linux to 5.15 and U-Boot to 2022.10. So note that even with Linux 5.15 and U-Boot 2022.10 the board doesn't boot up and [Patch 1/3] should be backported. Probably [Patch 4/4] should be backported too to avoid spending hours on power supply issues. After ~1 year I've totally forgotten that 500mA Usb port is not enough to power this board.

Best regards
Giulio

Giulio Benetti (4):
configs/asus_tinker_rk3288_defconfig: fix boot by prepending tpl to
spl+u-boot
board/asus/tinker: rename label linux-next to linux in extlinux.conf configs/asus_tinker_rk3288_defconfig: bump Linux to 6.1.2 and U-boot

    to 2022.10

board/asus/tinker: add a note to readme.txt for power supply

 board/asus/tinker/extlinux.conf      |  2 +-
 board/asus/tinker/genimage.cfg       | 11 +++++++++--
 board/asus/tinker/post-build.sh      |  4 ++--
 board/asus/tinker/readme.txt         |  5 +++++
 configs/asus_tinker_rk3288_defconfig | 11 +++++------
 5 files changed, 22 insertions(+), 11 deletions(-)
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH 1/4 configs/asus_tinker_rk3288_defconfig: fix boot by prepending tpl to spl+u-boot

During last U-boot version bump it's not been noted that tpl was not prepended to spl anymore preventing the board to boot, so let's copy tpl to image folder and prepend it to u-boot-spl-dtb.bin placing it to 32K offset, where rk3288 bootrom expects to find it. Let's also place u-boot-dtb separated from spl at 8M offset, where spl expects it to find it.

---
 board/asus/tinker/genimage.cfg       | 11 +++++++++--
 board/asus/tinker/post-build.sh      |  4 ++--
 configs/asus_tinker_rk3288_defconfig |  3 +--
 3 files changed, 12 insertions(+), 6 deletions(-)
board/asus/tinker/genimage.cfg +9 -2
index a4b1e8d608..fa7fd734f2 100644
@@ -2,12 +2,19 @@ image sdcard.img {
 	hdimage {
 	}
 
-	partition u-boot-spl-dtb {
+	partition u-boot-tpl-spl-dtb {
 		in-partition-table = "no"
-		image = "u-boot-spl-dtb.img"
+		image = "u-boot-tpl-spl-dtb.img"
 		offset = 32K
 	}
 
+	partition u-boot-dtb {
+		in-partition-table = "no"
+		image = "u-boot-dtb.img"
+		offset = 8M
+		size = 30M
+	}
+
 	partition rootfs {
 		partition-type = 0x83
 		image = "rootfs.ext4"
board/asus/tinker/post-build.sh +2 -2
index 8108ed83ff..ffbbcdeb58 100755
@@ -3,7 +3,7 @@
 MKIMAGE=$HOST_DIR/bin/mkimage
 BOARD_DIR="$(dirname $0)"
 
-$MKIMAGE -n rk3288 -T rksd -d $BINARIES_DIR/u-boot-spl-dtb.bin $BINARIES_DIR/u-boot-spl-dtb.img
-cat $BINARIES_DIR/u-boot-dtb.bin >> $BINARIES_DIR/u-boot-spl-dtb.img
+$MKIMAGE -n rk3288 -T rksd -d $BINARIES_DIR/u-boot-tpl.bin $BINARIES_DIR/u-boot-tpl.img
+cat $BINARIES_DIR/u-boot-tpl.img $BINARIES_DIR/u-boot-spl-dtb.bin > $BINARIES_DIR/u-boot-tpl-spl-dtb.img
 
 install -m 0644 -D $BOARD_DIR/extlinux.conf $TARGET_DIR/boot/extlinux/extlinux.conf
configs/asus_tinker_rk3288_defconfig +1 -2
index 6963fa939f..02b340a7f1 100644
@@ -17,9 +17,8 @@ BR2_TARGET_UBOOT_NEEDS_PYTHON3=y
 BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
 BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
 BR2_TARGET_UBOOT_FORMAT_DTB_IMG=y
-BR2_TARGET_UBOOT_FORMAT_DTB_BIN=y
 BR2_TARGET_UBOOT_SPL=y
-BR2_TARGET_UBOOT_SPL_NAME="spl/u-boot-spl-dtb.bin"
+BR2_TARGET_UBOOT_SPL_NAME="spl/u-boot-spl-dtb.bin tpl/u-boot-tpl.bin"
 
 # Kernel
 BR2_LINUX_KERNEL=y
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

PATCH 2/4 board/asus/tinker: rename label linux-next to linux in extlinux.conf

In reply to Giulio Benetti

We're not using next branch so let's rename label linux-next to linux.

---
 board/asus/tinker/extlinux.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/asus/tinker/extlinux.conf +1 -1
index 136af0debd..bb96ddb893 100644
@@ -1,4 +1,4 @@
-label Tinker linux-next
+label Tinker linux
   kernel /boot/uImage
   devicetree /boot/rk3288-tinker.dtb
   append console=ttyS2,115200n8 root=/dev/mmcblk0p1 rootwait
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#3 lore raw

PATCH 3/4 configs/asus_tinker_rk3288_defconfig: bump Linux to 6.1.2 and U-boot to 2022.10

In reply to Giulio Benetti
---
 configs/asus_tinker_rk3288_defconfig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
configs/asus_tinker_rk3288_defconfig +4 -4
index 02b340a7f1..40f4125880 100644
@@ -3,14 +3,14 @@ BR2_arm=y
 BR2_cortex_a17=y
 BR2_ARM_FPU_NEON_VFPV4=y
 
-# Linux headers same as kernel, a 5.14 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_14=y
+# Linux headers same as kernel, a 6.1 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_1=y
 
 # Bootloader
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
 BR2_TARGET_UBOOT_CUSTOM_VERSION=y
-BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2021.10"
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.10"
 BR2_TARGET_UBOOT_BOARD_DEFCONFIG="tinker-rk3288"
 BR2_TARGET_UBOOT_NEEDS_DTC=y
 BR2_TARGET_UBOOT_NEEDS_PYTHON3=y
@@ -23,7 +23,7 @@ BR2_TARGET_UBOOT_SPL_NAME="spl/u-boot-spl-dtb.bin tpl/u-boot-tpl.bin"
 # Kernel
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.14.13"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="6.1.2"
 BR2_LINUX_KERNEL_DEFCONFIG="multi_v7"
 BR2_LINUX_KERNEL_UIMAGE=y
 BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x02000000"
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#4 lore raw

PATCH 4/4 board/asus/tinker: add a note to readme.txt for power supply

In reply to Giulio Benetti
---
 board/asus/tinker/readme.txt | 5 +++++
 1 file changed, 5 insertions(+)
board/asus/tinker/readme.txt +5 -0
index 7372d29520..9affd6399f 100644
@@ -35,3 +35,8 @@ You can write this image directly to an SD card device (i.e. /dev/xxx):
   $ sudo sync
 
 Finally, you can insert the SD card to the Tinker RK3288 board and boot it.
+
+NOTE:
+Usb power supply requires more than the standard 500mA Usb current, so
+this board must be supplied from a capable port or from an external ac/dc
+adapter. Otherwise it will hang on loading uImage forever.
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#5 lore raw
In reply to Giulio Benetti
Quoted 7 lines · On Wed, 4 Jan 2023 01:21:09 +0100 Giulio Benetti…

Giulio Benetti (4):
configs/asus_tinker_rk3288_defconfig: fix boot by prepending tpl to
spl+u-boot
board/asus/tinker: rename label linux-next to linux in extlinux.conf configs/asus_tinker_rk3288_defconfig: bump Linux to 6.1.2 and U-boot

    to 2022.10

board/asus/tinker: add a note to readme.txt for power supply

Series applied with minor adjustements here and there, nothing major.

Thanks a lot!

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot