Skip to contentSkip to conversation

cryptodev: increase default max nb queue pairs

PATCH In review Anoob Joseph 3 participants 4 messages Jan 4, 2023 – Jan 10, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cryptodev: increase default max nb queue pairs

Increase default maximum number of queue pairs to 64. For sw crypto PMDs, the number of queue pairs can be increased as required. The default value (which is set to 8), prevents usage of sw cryptodev PMDs with larger number of cores.

Application would be allowed to specify the number of queue pairs it wishes to use. Only the upper bound is changed from 8 to 64.

Allow PMDs such as crypto_armv8 to run on larger number of cores.

---
 lib/cryptodev/cryptodev_pmd.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/cryptodev/cryptodev_pmd.h +1 -1
index 0020102eb7..913a8f3623 100644
@@ -29,7 +29,7 @@ extern "C" {
 #include "rte_cryptodev.h"
 
 
-#define RTE_CRYPTODEV_PMD_DEFAULT_MAX_NB_QUEUE_PAIRS	8
+#define RTE_CRYPTODEV_PMD_DEFAULT_MAX_NB_QUEUE_PAIRS	64
 
 #define RTE_CRYPTODEV_PMD_NAME_ARG			("name")
 #define RTE_CRYPTODEV_PMD_MAX_NB_QP_ARG			("max_nb_queue_pairs")
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#1 lore raw
Quoted 20 lines · Anoob Joseph

Increase default maximum number of queue pairs to 64. For sw crypto PMDs, the number of queue pairs can be increased as required. The default value (which is set to 8), prevents usage of sw cryptodev PMDs with larger number of cores.

Application would be allowed to specify the number of queue pairs it wishes to use. Only the upper bound is changed from 8 to 64.

Allow PMDs such as crypto_armv8 to run on larger number of cores.

---
  lib/cryptodev/cryptodev_pmd.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
lib/cryptodev/cryptodev_pmd.h +0 -0
index 0020102eb7..913a8f3623 100644

lib/cryptodev/cryptodev_pmd.h extern "C" { · line 35

Quoted 8 lines
lib/cryptodev/cryptodev_pmd.h +1 -1
@@ -29,7 +29,7 @@ extern "C" {
  #include "rte_cryptodev.h"
 
 
-#define RTE_CRYPTODEV_PMD_DEFAULT_MAX_NB_QUEUE_PAIRS	8
+#define RTE_CRYPTODEV_PMD_DEFAULT_MAX_NB_QUEUE_PAIRS	64
 
  #define RTE_CRYPTODEV_PMD_NAME_ARG			("name")
  #define RTE_CRYPTODEV_PMD_MAX_NB_QP_ARG			("max_nb_queue_pairs")
#2 lore raw
In reply to Anoob Joseph
Quoted 29 lines

-----Original Message-----
From: Anoob Joseph <[email protected]>
Sent: Wednesday, January 4, 2023 3:30 PM
To: Akhil Goyal <[email protected]>; Ruifeng Wang <[email protected]>; Gagandeep Singh <[email protected]>; [email protected]; Kai Ji <[email protected]>; Pablo de Lara <[email protected]>; Matan Azrad <[email protected]>; Zhangfei Gao <[email protected]>; Fan Zhang <[email protected]>
Cc: Ashwin Sekhar T K <[email protected]>; [email protected]; [email protected]
Subject: [PATCH] cryptodev: increase default max nb queue pairs

Increase default maximum number of queue pairs to 64. For sw crypto PMDs, the number of queue pairs can be increased as required. The default value (which is set to 8), prevents usage of sw cryptodev PMDs with larger number of cores.

Application would be allowed to specify the number of queue pairs it wishes to use. Only the upper bound is changed from 8 to 64.

Allow PMDs such as crypto_armv8 to run on larger number of cores.

---
 lib/cryptodev/cryptodev_pmd.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/cryptodev/cryptodev_pmd.h index renamed from lib/cryptodev/cryptodev_pmd.h +0 -0

0020102eb7..913a8f3623 100644

lib/cryptodev/cryptodev_pmd.h extern "C" { · line 35

Quoted 8 lines
lib/cryptodev/cryptodev_pmd.h +1 -1
@@ -29,7 +29,7 @@ extern "C" {
 #include "rte_cryptodev.h"
 
 
-#define RTE_CRYPTODEV_PMD_DEFAULT_MAX_NB_QUEUE_PAIRS	8
+#define RTE_CRYPTODEV_PMD_DEFAULT_MAX_NB_QUEUE_PAIRS	64
 
 #define RTE_CRYPTODEV_PMD_NAME_ARG			("name")
 #define RTE_CRYPTODEV_PMD_MAX_NB_QP_ARG			("max_nb_queue_pairs")

Crypto device has devargs "max_nb_queue_pairs" which can be used to change queue pairs limit at init time. Then no need to increase the default value?

Quoted 2 lines

--
2.25.1

#3 lore raw

Hi Ruifeng,

Quoted 3 lines

Crypto device has devargs "max_nb_queue_pairs" which can be used to change queue pairs limit at init time.
Then no need to increase the default value?

Yes. Thanks for the pointer. This field would suffice for the issue that I'm trying to fix.

Thanks,
Anoob

Quoted 65 lines

-----Original Message-----
From: Ruifeng Wang <[email protected]>
Sent: Tuesday, January 10, 2023 12:12 PM
To: Anoob Joseph <[email protected]>; Akhil Goyal <[email protected]>; Gagandeep Singh <[email protected]>; [email protected]; Kai Ji <[email protected]>; Pablo de Lara <[email protected]>; Matan Azrad <[email protected]>; Zhangfei Gao <[email protected]>; Fan Zhang <[email protected]>
Cc: Ashwin Sekhar T K <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; [email protected]; nd <[email protected]>
Subject: [EXT] RE: [PATCH] cryptodev: increase default max nb queue pairs

External Email

----------------------------------------------------------------------

Quoted 13 lines

-----Original Message-----
From: Anoob Joseph <[email protected]>
Sent: Wednesday, January 4, 2023 3:30 PM
To: Akhil Goyal <[email protected]>; Ruifeng Wang <[email protected]>; Gagandeep Singh <[email protected]>; [email protected]; Kai Ji <[email protected]>; Pablo de Lara <[email protected]>; Matan Azrad <[email protected]>; Zhangfei Gao <[email protected]>; Fan Zhang <[email protected]>
Cc: Ashwin Sekhar T K <[email protected]>; [email protected]; [email protected]
Subject: [PATCH] cryptodev: increase default max nb queue pairs

Quoted 3 lines

Increase default maximum number of queue pairs to 64. For sw crypto PMDs, the number of queue pairs can be increased as required. The default value (which is set to 8), prevents usage of sw cryptodev PMDs with

larger number of cores.

Quoted 17 lines

Application would be allowed to specify the number of queue pairs it wishes to use. Only the upper bound is changed from 8 to 64.

Allow PMDs such as crypto_armv8 to run on larger number of cores.

---
 lib/cryptodev/cryptodev_pmd.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/lib/cryptodev/cryptodev_pmd.h index
0020102eb7..913a8f3623 100644

lib/cryptodev/cryptodev_pmd.h extern "C" { · line 35

Quoted 8 lines
lib/cryptodev/cryptodev_pmd.h +1 -1
@@ -29,7 +29,7 @@ extern "C" {
 #include "rte_cryptodev.h"
 
 
-#define RTE_CRYPTODEV_PMD_DEFAULT_MAX_NB_QUEUE_PAIRS	8
+#define RTE_CRYPTODEV_PMD_DEFAULT_MAX_NB_QUEUE_PAIRS	64
 
 #define RTE_CRYPTODEV_PMD_NAME_ARG			("name")
 #define RTE_CRYPTODEV_PMD_MAX_NB_QP_ARG
	("max_nb_queue_pairs")

Crypto device has devargs "max_nb_queue_pairs" which can be used to change queue pairs limit at init time.
Then no need to increase the default value?

Quoted 2 lines

--
2.25.1