Skip to contentSkip to conversation

media: atomisp: fix videobuf2 Kconfig depenendency

PATCH In review Arnd Bergmann 3 participants 3 messages Jan 4, 2023 – Jan 10, 2023

Subsystems (4)
Media (V4L/DVB) Staging Intel MID (Mobile Internet Device) platform Staging - atomisp driver
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 media: atomisp: fix videobuf2 Kconfig depenendency

From: Arnd Bergmann <[email protected]>

The recent conversion missed the Kconfig bit, so it can now end up in a link error on randconfig builds:

ld.lld: error: undefined symbol: vb2_vmalloc_memops

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

referenced by atomisp_fops.c
drivers/staging/media/atomisp/pci/atomisp_fops.o:(atomisp_open) in archive vmlinux.a

Fixes cb48ae89be3b ("media: atomisp: Convert to videobuf2")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/staging/media/atomisp/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/atomisp/Kconfig +1 -1
index 2c8d7fdcc5f7..c9bff98e5309 100644
@@ -14,7 +14,7 @@ config VIDEO_ATOMISP
 	depends on VIDEO_DEV && INTEL_ATOMISP
 	depends on PMIC_OPREGION
 	select IOSF_MBI
-	select VIDEOBUF_VMALLOC
+	select VIDEOBUF2_VMALLOC
 	select VIDEO_V4L2_SUBDEV_API
 	help
 	  Say Y here if your platform supports Intel Atom SoC
Signature · 1 line
2.39.0
maintainer Tested-by on v1 1/1
#1 lore raw
Quoted 8 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The recent conversion missed the Kconfig bit, so it can now end up in a link error on randconfig builds:

ld.lld: error: undefined symbol: vb2_vmalloc_memops

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

referenced by atomisp_fops.c
drivers/staging/media/atomisp/pci/atomisp_fops.o:(atomisp_open) in archive vmlinux.a

Tested-by Andy Shevchenko <[email protected]>
Quoted 22 lines
Fixes cb48ae89be3b ("media: atomisp: Convert to videobuf2")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/staging/media/atomisp/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/atomisp/Kconfig +1 -1
index 2c8d7fdcc5f7..c9bff98e5309 100644
@@ -14,7 +14,7 @@ config VIDEO_ATOMISP
 	depends on VIDEO_DEV && INTEL_ATOMISP
 	depends on PMIC_OPREGION
 	select IOSF_MBI
-	select VIDEOBUF_VMALLOC
+	select VIDEOBUF2_VMALLOC
 	select VIDEO_V4L2_SUBDEV_API
 	help
 	  Say Y here if your platform supports Intel Atom SoC
Signature · 1 line
2.39.0
Signature · 2 lines
With Best Regards,
Andy Shevchenko
Reviewed-by on v1 1/1
#2 lore raw
In reply to Arnd Bergmann

Hi,

Quoted 11 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The recent conversion missed the Kconfig bit, so it can now end up in a link error on randconfig builds:

ld.lld: error: undefined symbol: vb2_vmalloc_memops

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

referenced by atomisp_fops.c
drivers/staging/media/atomisp/pci/atomisp_fops.o:(atomisp_open) in archive vmlinux.a

Fixes cb48ae89be3b ("media: atomisp: Convert to videobuf2")
Signed-off-by Arnd Bergmann <[email protected]>

Thanks, patch looks good to me:

Reviewed-by Hans de Goede <[email protected]>

Mauro, can you pick this up and send it to Linus as a 6.1 fix?

Regards,

Hans

Quoted 17 lines
---
 drivers/staging/media/atomisp/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/atomisp/Kconfig +1 -1
index 2c8d7fdcc5f7..c9bff98e5309 100644
@@ -14,7 +14,7 @@ config VIDEO_ATOMISP
 	depends on VIDEO_DEV && INTEL_ATOMISP
 	depends on PMIC_OPREGION
 	select IOSF_MBI
-	select VIDEOBUF_VMALLOC
+	select VIDEOBUF2_VMALLOC
 	select VIDEO_V4L2_SUBDEV_API
 	help
 	  Say Y here if your platform supports Intel Atom SoC