arm64: dts: beacon-renesom: Fix gpio expander reference
PATCH 1/4 arm64: dts: beacon-renesom: Fix gpio expander reference
The board used to originally introduce the Beacon Embedded RZ/G2[M/N/H] boards had a GPIO expander with address 20, but this was change when the final board went to production.
The production boards changed both the part itself and the address. With the incorrect address, the LCD cannot come up. If the LCD fails, the rcar-du driver fails to come up, and that also breaks HDMI.
Pre-release board were not shipped to the general public, so it should be safe to push this as a fix. Anyone with a production board would have video fail due to this GPIO expander change.
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +15 -14
@@ -437,20 +437,6 @@ wm8962_endpoint: endpoint { }; }; - /* 0 - lcd_reset */ - /* 1 - lcd_pwr */ - /* 2 - lcd_select */ - /* 3 - backlight-enable */ - /* 4 - Touch_shdwn */ - /* 5 - LCD_H_pol */ - /* 6 - lcd_V_pol */ - gpio_exp1: gpio@20 { - compatible = "onnn,pca9654"; - reg = <0x20>; - gpio-controller; - #gpio-cells = <2>; - }; - touchscreen@26 { compatible = "ilitek,ili2117"; reg = <0x26>;
@@ -482,6 +468,21 @@ hd3ss3220_out_ep: endpoint { }; }; }; + + gpio_exp1: gpio@70 { + compatible = "onnn,pca9654"; + reg = <0x70>; + gpio-controller; + #gpio-cells = <2>; + gpio-line-names = + "lcd_reset", + "lcd_pwr", + "lcd_select", + "backlight-enable", + "Touch_shdwn", + "LCD_H_pol", + "lcd_V_pol"; + }; }; &lvds0 {
Signature · 1 line
2.34.1
PATCH 2/4 Revert "arm64: dts: renesas: Add compatible properties to AR8031 Ethernet PHYs"
This reverts commit 18a2427146bf8a3da8fc7825051d6aadb9c2d8fb.
Due to the part shortage, the AR8031 PHY was replaced with a Micrel KSZ9131. Hard-coding the ID of the PHY makes this new PHY non-operational. Since previous hardware had shipped, it's not as simple as just replacing the ID number as it would break the older hardware. Since the generic mode can correctly identify both versions of hardware, it seems safer to revert this patch.
arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi +0 -2
@@ -59,8 +59,6 @@ &avb { status = "okay"; phy0: ethernet-phy@0 { - compatible = "ethernet-phy-id004d.d074", - "ethernet-phy-ieee802.3-c22"; reg = <0>; interrupt-parent = <&gpio2>; interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
Signature · 1 line
2.34.1
Re: [PATCH 2/4] Revert "arm64: dts: renesas: Add compatible properties to AR8031 Ethernet PHYs"
Hi Adam,
CC Ethernet phy
Quoted 11 lines · Adam Ford
This reverts commit
18a2427146bf8a3da8fc7825051d6aadb9c2d8fb.Due to the part shortage, the AR8031 PHY was replaced with a Micrel KSZ9131. Hard-coding the ID of the PHY makes this new PHY non-operational. Since previous hardware had shipped, it's not as simple as just replacing the ID number as it would break the older hardware. Since the generic mode can correctly identify both versions of hardware, it seems safer to revert this patch.
Signed-off-by Adam Ford <[email protected]>
Thanks for your patch!
arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi &avb { · line 64
Quoted 11 lines
arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi +0
-2@@ -59,8 +59,6 @@ &avb { status = "okay"; phy0: ethernet-phy@0 { - compatible = "ethernet-phy-id004d.d074", - "ethernet-phy-ieee802.3-c22"; reg = <0>; interrupt-parent = <&gpio2>; interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
The next line:
reset-gpios = <&gpio2 10 GPIO_ACTIVE_LOW>;
Unfortunately, removing the compatible value will cause regressions for kexec/kdump and for Ethernet driver unbind, as the PHY reset will be asserted before starting the new kernel, or on driver unbind. Due to a deficiency in the Ethernet PHY subsystem, the PHY will be probed while the reset is still asserted, and thus fail probing[1].
Is there a (new) proper way to handle this?
Perhaps the issue has been fixed in the PHY subsystem meanwhile?
Thanks!
[1] https://lore.kernel.org/all/[email protected]
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH 2/4] Revert "arm64: dts: renesas: Add compatible properties to AR8031 Ethernet PHYs"
Quoted 34 lines · Geert Uytterhoeven
Hi Adam,
CC Ethernet phy
Quoted 11 lines · Adam Ford
This reverts commit
18a2427146bf8a3da8fc7825051d6aadb9c2d8fb.Due to the part shortage, the AR8031 PHY was replaced with a Micrel KSZ9131. Hard-coding the ID of the PHY makes this new PHY non-operational. Since previous hardware had shipped, it's not as simple as just replacing the ID number as it would break the older hardware. Since the generic mode can correctly identify both versions of hardware, it seems safer to revert this patch.
Signed-off-by Adam Ford <[email protected]>Thanks for your patch!
arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi &avb { · line 64
Quoted 11 lines
arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi +0
-2@@ -59,8 +59,6 @@ &avb { status = "okay"; phy0: ethernet-phy@0 { - compatible = "ethernet-phy-id004d.d074", - "ethernet-phy-ieee802.3-c22"; reg = <0>; interrupt-parent = <&gpio2>; interrupts = <11 IRQ_TYPE_LEVEL_LOW>;The next line:
Quoted 7 lines
reset-gpios = <&gpio2 10 GPIO_ACTIVE_LOW>;Unfortunately, removing the compatible value will cause regressions for kexec/kdump and for Ethernet driver unbind, as the PHY reset will be asserted before starting the new kernel, or on driver unbind. Due to a deficiency in the Ethernet PHY subsystem, the PHY will be probed while the reset is still asserted, and thus fail probing[1].
FWIW, the bootloader brings the device out of reset. Would it be sufficient to keep "ethernet-phy-ieee802.3-c22" and drop the hard-coded ID?
thanks,
adam
Quoted 18 lines
Is there a (new) proper way to handle this?
Perhaps the issue has been fixed in the PHY subsystem meanwhile?Thanks!
[1] https://lore.kernel.org/all/[email protected]
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH 2/4] Revert "arm64: dts: renesas: Add compatible properties to AR8031 Ethernet PHYs"
Hi Adam,
Quoted 32 lines · Adam Ford
Quoted 31 lines · Geert Uytterhoeven
Quoted 11 lines · Adam Ford
This reverts commit
18a2427146bf8a3da8fc7825051d6aadb9c2d8fb.Due to the part shortage, the AR8031 PHY was replaced with a Micrel KSZ9131. Hard-coding the ID of the PHY makes this new PHY non-operational. Since previous hardware had shipped, it's not as simple as just replacing the ID number as it would break the older hardware. Since the generic mode can correctly identify both versions of hardware, it seems safer to revert this patch.
Signed-off-by Adam Ford <[email protected]>Thanks for your patch!
arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi &avb { · line 64
Quoted 11 lines
arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi +0
-2@@ -59,8 +59,6 @@ &avb { status = "okay"; phy0: ethernet-phy@0 { - compatible = "ethernet-phy-id004d.d074", - "ethernet-phy-ieee802.3-c22"; reg = <0>; interrupt-parent = <&gpio2>; interrupts = <11 IRQ_TYPE_LEVEL_LOW>;The next line:
reset-gpios = <&gpio2 10 GPIO_ACTIVE_LOW>;
Quoted 7 lines
Quoted 5 lines
Unfortunately, removing the compatible value will cause regressions for kexec/kdump and for Ethernet driver unbind, as the PHY reset will be asserted before starting the new kernel, or on driver unbind. Due to a deficiency in the Ethernet PHY subsystem, the PHY will be probed while the reset is still asserted, and thus fail probing[1].
FWIW, the bootloader brings the device out of reset. Would it be
The bootloader is not involved when using kexec/kdump, or when unbinding the Ethernet driver.
Quoted 2 lines
sufficient to keep "ethernet-phy-ieee802.3-c22" and drop the hard-coded ID?
I am afraid not, as that still requires actual probing to determine the PHY ID.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH 2/4] Revert "arm64: dts: renesas: Add compatible properties to AR8031 Ethernet PHYs"
Quoted 44 lines · Geert Uytterhoeven
Hi Adam,
Quoted 32 lines · Adam Ford
Quoted 31 lines · Geert Uytterhoeven
Quoted 11 lines · Adam Ford
This reverts commit
18a2427146bf8a3da8fc7825051d6aadb9c2d8fb.Due to the part shortage, the AR8031 PHY was replaced with a Micrel KSZ9131. Hard-coding the ID of the PHY makes this new PHY non-operational. Since previous hardware had shipped, it's not as simple as just replacing the ID number as it would break the older hardware. Since the generic mode can correctly identify both versions of hardware, it seems safer to revert this patch.
Signed-off-by Adam Ford <[email protected]>Thanks for your patch!
arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi &avb { · line 64
Quoted 11 lines
arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi +0
-2@@ -59,8 +59,6 @@ &avb { status = "okay"; phy0: ethernet-phy@0 { - compatible = "ethernet-phy-id004d.d074", - "ethernet-phy-ieee802.3-c22"; reg = <0>; interrupt-parent = <&gpio2>; interrupts = <11 IRQ_TYPE_LEVEL_LOW>;The next line:
reset-gpios = <&gpio2 10 GPIO_ACTIVE_LOW>;Quoted 7 lines
Quoted 5 lines
Unfortunately, removing the compatible value will cause regressions for kexec/kdump and for Ethernet driver unbind, as the PHY reset will be asserted before starting the new kernel, or on driver unbind. Due to a deficiency in the Ethernet PHY subsystem, the PHY will be probed while the reset is still asserted, and thus fail probing[1].
FWIW, the bootloader brings the device out of reset. Would it be
Quoted 8 lines
The bootloader is not involved when using kexec/kdump, or when unbinding the Ethernet driver.
Quoted 2 lines
sufficient to keep "ethernet-phy-ieee802.3-c22" and drop the hard-coded ID?
I am afraid not, as that still requires actual probing to determine the PHY ID.
OK. I'll try to find out how many of the older versions of the board shipped. I don't really want to maintain two device trees for a small population of boards. Even those customers with early hardware won't be getting the same versions going forward and Qualcomm/Atheros told us it's an EOL part and cancelled our orders. If there are no objections, I might just change the ID to the new PHY. The customers who received the older hardware should have already been notified of the hardware change and the fact they won't get any more with that PHY.
adam
Quoted 11 lines
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
PATCH 3/4 arm64: dts: renesas: r8a774[a/b/e]1-beacon: Update corporate name
In reply to Adam FordAt the end of 2021, Beacon EmbeddedWorks was sold off from Compass. Its legal name is now 'Logic PD, Inc. dba Beacon EmbeddedWorks" and as far as I know Compass Electronics doesn't exist anymore.
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +1 -1
@@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 /* - * Copyright 2020, Compass Electronics Group, LLC + * Copyright 2020, Logic PD, Inc. dba Beacon EmbeddedWorks */ #include <dt-bindings/gpio/gpio.h>
arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi +1 -1
@@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 /* - * Copyright 2020, Compass Electronics Group, LLC + * Copyright 2020, Logic PD, Inc. dba Beacon EmbeddedWorks */ #include <dt-bindings/gpio/gpio.h>
arch/arm64/boot/dts/renesas/r8a774a1-beacon-rzg2m-kit.dts +1 -1
@@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 /* - * Copyright 2020, Compass Electronics Group, LLC + * Copyright 2020, Logic PD, Inc. dba Beacon EmbeddedWorks */ /dts-v1/;
arch/arm64/boot/dts/renesas/r8a774b1-beacon-rzg2n-kit.dts +1 -1
@@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 /* - * Copyright 2020, Compass Electronics Group, LLC + * Copyright 2020, Logic PD, Inc. dba Beacon EmbeddedWorks */ /dts-v1/;
arch/arm64/boot/dts/renesas/r8a774e1-beacon-rzg2h-kit.dts +1 -1
@@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 /* - * Copyright 2020, Compass Electronics Group, LLC + * Copyright 2020, Logic PD, Inc. dba Beacon EmbeddedWorks */ /dts-v1/;
Signature · 1 line
2.34.1
Re: [PATCH 3/4] arm64: dts: renesas: r8a774[a/b/e]1-beacon: Update corporate name
Hi Adam,
CC GregKH
Quoted 5 lines · Adam Ford
At the end of 2021, Beacon EmbeddedWorks was sold off from Compass. Its legal name is now 'Logic PD, Inc. dba Beacon EmbeddedWorks" and as far as I know Compass Electronics doesn't exist anymore.
Signed-off-by Adam Ford <[email protected]>
Thanks for your patch!
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi line 3
Quoted 7 lines
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +1
-1@@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 /* - * Copyright 2020, Compass Electronics Group, LLC + * Copyright 2020, Logic PD, Inc. dba Beacon EmbeddedWorks
IANAL, but I don't think this change is appropriate: the copyright date is 2020, which is the year when the file was created, and the copyright owner at that time was Compass. The current copyright owner is the current owner of the assets of Compass, which may change again in the future.
I'm also not aware of people changing copyright headers for code owned by now defunct companies, see the existence of code still copyrighted by e.g. Motorola Inc., Digital Equipment Corporation, and Compaq Computer Corporation.
If/when you make (substantial) changes to these files, you can add a "Copyright 2023, Logic PD, Inc. dba Beacon EmbeddedWorks" line.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH 3/4] arm64: dts: renesas: r8a774[a/b/e]1-beacon: Update corporate name
Quoted 28 lines · Geert Uytterhoeven
Hi Adam,
CC GregKH
Quoted 5 lines · Adam Ford
At the end of 2021, Beacon EmbeddedWorks was sold off from Compass. Its legal name is now 'Logic PD, Inc. dba Beacon EmbeddedWorks" and as far as I know Compass Electronics doesn't exist anymore.
Signed-off-by Adam Ford <[email protected]>Thanks for your patch!
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi line 3
Quoted 7 lines
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +1
-1@@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 /* - * Copyright 2020, Compass Electronics Group, LLC + * Copyright 2020, Logic PD, Inc. dba Beacon EmbeddedWorksIANAL, but I don't think this change is appropriate: the copyright date is 2020, which is the year when the file was created, and the copyright owner at that time was Compass. The current copyright owner is the current owner of the assets of Compass, which may change again in the future.
Quoted 7 lines
I'm also not aware of people changing copyright headers for code owned by now defunct companies, see the existence of code still copyrighted by e.g. Motorola Inc., Digital Equipment Corporation, and Compaq Computer Corporation.
If/when you make (substantial) changes to these files, you can add a "Copyright 2023, Logic PD, Inc. dba Beacon EmbeddedWorks" line.
OK. We can drop this patch from the series.
thanks,
adam
Quoted 11 lines
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
PATCH 4/4 arm64: boot: dts: r8a774[a/b/e]1-beacon: Consolidate sound clocks
In reply to Adam FordEach kit-level file represents a SOM + baseboard for a specific SoC type and uses specific clocks unique to each SoC. With the exception of one clock, the rest of the clock info was duplicated.
There is a generic clock called CPG_AUDIO_CLK_I defined in each of the SoC DTSI files which points to this unique clock. By using that, the clock information for the rcar_sound can be consolidated into the baseboard file and have it reference this generic clock thus removing the duplication from the three variants.
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +19 -0
@@ -639,6 +639,25 @@ &rcar_sound { #clock-cells = <1>; clock-frequency = <11289600>; + /* Reference versaclock instead of audio_clk_a */ + clocks = <&cpg CPG_MOD 1005>, + <&cpg CPG_MOD 1006>, <&cpg CPG_MOD 1007>, + <&cpg CPG_MOD 1008>, <&cpg CPG_MOD 1009>, + <&cpg CPG_MOD 1010>, <&cpg CPG_MOD 1011>, + <&cpg CPG_MOD 1012>, <&cpg CPG_MOD 1013>, + <&cpg CPG_MOD 1014>, <&cpg CPG_MOD 1015>, + <&cpg CPG_MOD 1022>, <&cpg CPG_MOD 1023>, + <&cpg CPG_MOD 1024>, <&cpg CPG_MOD 1025>, + <&cpg CPG_MOD 1026>, <&cpg CPG_MOD 1027>, + <&cpg CPG_MOD 1028>, <&cpg CPG_MOD 1029>, + <&cpg CPG_MOD 1030>, <&cpg CPG_MOD 1031>, + <&cpg CPG_MOD 1020>, <&cpg CPG_MOD 1021>, + <&cpg CPG_MOD 1020>, <&cpg CPG_MOD 1021>, + <&cpg CPG_MOD 1019>, <&cpg CPG_MOD 1018>, + <&versaclock6_bb 4>, <&audio_clk_b>, + <&audio_clk_c>, + <&cpg CPG_CORE CPG_AUDIO_CLK_I>; + status = "okay"; ports {
arch/arm64/boot/dts/renesas/r8a774a1-beacon-rzg2m-kit.dts +0 -21
@@ -58,24 +58,3 @@ &du { clock-names = "du.0", "du.1", "du.2", "dclkin.0", "dclkin.1", "dclkin.2"; }; - -/* Reference versaclock instead of audio_clk_a */ -&rcar_sound { - clocks = <&cpg CPG_MOD 1005>, - <&cpg CPG_MOD 1006>, <&cpg CPG_MOD 1007>, - <&cpg CPG_MOD 1008>, <&cpg CPG_MOD 1009>, - <&cpg CPG_MOD 1010>, <&cpg CPG_MOD 1011>, - <&cpg CPG_MOD 1012>, <&cpg CPG_MOD 1013>, - <&cpg CPG_MOD 1014>, <&cpg CPG_MOD 1015>, - <&cpg CPG_MOD 1022>, <&cpg CPG_MOD 1023>, - <&cpg CPG_MOD 1024>, <&cpg CPG_MOD 1025>, - <&cpg CPG_MOD 1026>, <&cpg CPG_MOD 1027>, - <&cpg CPG_MOD 1028>, <&cpg CPG_MOD 1029>, - <&cpg CPG_MOD 1030>, <&cpg CPG_MOD 1031>, - <&cpg CPG_MOD 1020>, <&cpg CPG_MOD 1021>, - <&cpg CPG_MOD 1020>, <&cpg CPG_MOD 1021>, - <&cpg CPG_MOD 1019>, <&cpg CPG_MOD 1018>, - <&versaclock6_bb 4>, <&audio_clk_b>, - <&audio_clk_c>, - <&cpg CPG_CORE R8A774A1_CLK_S0D4>; -};
arch/arm64/boot/dts/renesas/r8a774b1-beacon-rzg2n-kit.dts +0 -21
@@ -46,24 +46,3 @@ &du { clock-names = "du.0", "du.1", "du.3", "dclkin.0", "dclkin.1", "dclkin.3"; }; - -/* Reference versaclock instead of audio_clk_a */ -&rcar_sound { - clocks = <&cpg CPG_MOD 1005>, - <&cpg CPG_MOD 1006>, <&cpg CPG_MOD 1007>, - <&cpg CPG_MOD 1008>, <&cpg CPG_MOD 1009>, - <&cpg CPG_MOD 1010>, <&cpg CPG_MOD 1011>, - <&cpg CPG_MOD 1012>, <&cpg CPG_MOD 1013>, - <&cpg CPG_MOD 1014>, <&cpg CPG_MOD 1015>, - <&cpg CPG_MOD 1022>, <&cpg CPG_MOD 1023>, - <&cpg CPG_MOD 1024>, <&cpg CPG_MOD 1025>, - <&cpg CPG_MOD 1026>, <&cpg CPG_MOD 1027>, - <&cpg CPG_MOD 1028>, <&cpg CPG_MOD 1029>, - <&cpg CPG_MOD 1030>, <&cpg CPG_MOD 1031>, - <&cpg CPG_MOD 1020>, <&cpg CPG_MOD 1021>, - <&cpg CPG_MOD 1020>, <&cpg CPG_MOD 1021>, - <&cpg CPG_MOD 1019>, <&cpg CPG_MOD 1018>, - <&versaclock6_bb 4>, <&audio_clk_b>, - <&audio_clk_c>, - <&cpg CPG_CORE R8A774B1_CLK_S0D4>; -};
arch/arm64/boot/dts/renesas/r8a774e1-beacon-rzg2h-kit.dts +0 -21
@@ -51,24 +51,3 @@ &du { clock-names = "du.0", "du.1", "du.3", "dclkin.0", "dclkin.1", "dclkin.3"; }; - -/* Reference versaclock instead of audio_clk_a */ -&rcar_sound { - clocks = <&cpg CPG_MOD 1005>, - <&cpg CPG_MOD 1006>, <&cpg CPG_MOD 1007>, - <&cpg CPG_MOD 1008>, <&cpg CPG_MOD 1009>, - <&cpg CPG_MOD 1010>, <&cpg CPG_MOD 1011>, - <&cpg CPG_MOD 1012>, <&cpg CPG_MOD 1013>, - <&cpg CPG_MOD 1014>, <&cpg CPG_MOD 1015>, - <&cpg CPG_MOD 1022>, <&cpg CPG_MOD 1023>, - <&cpg CPG_MOD 1024>, <&cpg CPG_MOD 1025>, - <&cpg CPG_MOD 1026>, <&cpg CPG_MOD 1027>, - <&cpg CPG_MOD 1028>, <&cpg CPG_MOD 1029>, - <&cpg CPG_MOD 1030>, <&cpg CPG_MOD 1031>, - <&cpg CPG_MOD 1020>, <&cpg CPG_MOD 1021>, - <&cpg CPG_MOD 1020>, <&cpg CPG_MOD 1021>, - <&cpg CPG_MOD 1019>, <&cpg CPG_MOD 1018>, - <&versaclock6_bb 4>, <&audio_clk_b>, - <&audio_clk_c>, - <&cpg CPG_CORE R8A774E1_CLK_S0D4>; -};
Signature · 1 line
2.34.1
Re: [PATCH 4/4] arm64: boot: dts: r8a774[a/b/e]1-beacon: Consolidate sound clocks
Quoted 11 lines · Adam Ford
Each kit-level file represents a SOM + baseboard for a specific SoC type and uses specific clocks unique to each SoC. With the exception of one clock, the rest of the clock info was duplicated.
There is a generic clock called
CPG_AUDIO_CLK_Idefined in each of the SoC DTSI files which points to this unique clock. By using that, the clock information for thercar_soundcan be consolidated into the baseboard file and have it reference this generic clock thus removing the duplication from the three variants.Signed-off-by Adam Ford <[email protected]>
i.e. will queue in renesas-devel for v6.3.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Quoted 5 lines · Adam Ford
The board used to originally introduce the Beacon Embedded RZ/G2[M/N/H] boards had a GPIO expander with address 20, but this was change when the final board went to production.
Quoted 9 lines
The production boards changed both the part itself and the address. With the incorrect address, the LCD cannot come up. If the LCD fails, the rcar-du driver fails to come up, and that also breaks HDMI.
Pre-release board were not shipped to the general public, so it should be safe to push this as a fix. Anyone with a production board would have video fail due to this GPIO expander change.
Geert,
Is this patch OK as-is? This is more critical to me than the other patches in the series.
adam
Quoted 53 lines
Fixes a1d8a344f1ca ("arm64: dts: renesas: Introduce r8a774a1-beacon-rzg2m-kit")Signed-off-by Adam Ford <[email protected]>arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +15
-15@@ -437,20 +437,6 @@ wm8962_endpoint: endpoint { }; }; - /* 0 - lcd_reset */ - /* 1 - lcd_pwr */ - /* 2 - lcd_select */ - /* 3 - backlight-enable */ - /* 4 - Touch_shdwn */ - /* 5 - LCD_H_pol */ - /* 6 - lcd_V_pol */ - gpio_exp1: gpio@20 { - compatible = "onnn,pca9654"; - reg = <0x20>; - gpio-controller; - #gpio-cells = <2>; - }; - touchscreen@26 { compatible = "ilitek,ili2117"; reg = <0x26>;@@ -482,6 +468,21 @@ hd3ss3220_out_ep: endpoint { }; }; }; + + gpio_exp1: gpio@70 { + compatible = "onnn,pca9654"; + reg = <0x70>; + gpio-controller; + #gpio-cells = <2>; + gpio-line-names = + "lcd_reset", + "lcd_pwr", + "lcd_select", + "backlight-enable", + "Touch_shdwn", + "LCD_H_pol", + "lcd_V_pol"; + }; }; &lvds0 { --2.34.1
Hi Adam,
Quoted 9 lines · Adam Ford
The board used to originally introduce the Beacon Embedded RZ/G2[M/N/H] boards had a GPIO expander with address 20, but this was change when the final board went to production.
The production boards changed both the part itself and the address. With the incorrect address, the LCD cannot come up. If the LCD fails, the rcar-du driver fails to come up, and that also breaks HDMI.
Quoted 6 lines
Pre-release board were not shipped to the general public, so it should be safe to push this as a fix. Anyone with a production board would have video fail due to this GPIO expander change.
Fixes a1d8a344f1ca ("arm64: dts: renesas: Introduce r8a774a1-beacon-rzg2m-kit")Signed-off-by Adam Ford <[email protected]>
Thanks for your patch!
Quoted 24 lines
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +0
-14@@ -437,20 +437,6 @@ wm8962_endpoint: endpoint { }; }; - /* 0 - lcd_reset */ - /* 1 - lcd_pwr */ - /* 2 - lcd_select */ - /* 3 - backlight-enable */ - /* 4 - Touch_shdwn */ - /* 5 - LCD_H_pol */ - /* 6 - lcd_V_pol */ - gpio_exp1: gpio@20 { - compatible = "onnn,pca9654"; - reg = <0x20>; - gpio-controller; - #gpio-cells = <2>; - }; - touchscreen@26 { compatible = "ilitek,ili2117"; reg = <0x26>;
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi hd3ss3220_out_ep: endpoint { · line 473
Quoted 6 lines
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +3
-0@@ -482,6 +468,21 @@ hd3ss3220_out_ep: endpoint { }; }; }; + + gpio_exp1: gpio@70 { + compatible = "onnn,pca9654";
According to the patch description, the actual part was changed, too?
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi hd3ss3220_out_ep: endpoint { · line 486
Quoted 13 lines
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +12
-0+ reg = <0x70>; + gpio-controller; + #gpio-cells = <2>; + gpio-line-names = + "lcd_reset", + "lcd_pwr", + "lcd_select", + "backlight-enable", + "Touch_shdwn", + "LCD_H_pol", + "lcd_V_pol"; + }; };
The rest LGTM.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Quoted 46 lines · Geert Uytterhoeven
Hi Adam,
Quoted 9 lines · Adam Ford
The board used to originally introduce the Beacon Embedded RZ/G2[M/N/H] boards had a GPIO expander with address 20, but this was change when the final board went to production.
The production boards changed both the part itself and the address. With the incorrect address, the LCD cannot come up. If the LCD fails, the rcar-du driver fails to come up, and that also breaks HDMI.
Quoted 6 lines
Pre-release board were not shipped to the general public, so it should be safe to push this as a fix. Anyone with a production board would have video fail due to this GPIO expander change.
Fixes a1d8a344f1ca ("arm64: dts: renesas: Introduce r8a774a1-beacon-rzg2m-kit")Signed-off-by Adam Ford <[email protected]>Thanks for your patch!
Quoted 24 lines
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +0
-14@@ -437,20 +437,6 @@ wm8962_endpoint: endpoint { }; }; - /* 0 - lcd_reset */ - /* 1 - lcd_pwr */ - /* 2 - lcd_select */ - /* 3 - backlight-enable */ - /* 4 - Touch_shdwn */ - /* 5 - LCD_H_pol */ - /* 6 - lcd_V_pol */ - gpio_exp1: gpio@20 { - compatible = "onnn,pca9654"; - reg = <0x20>; - gpio-controller; - #gpio-cells = <2>; - }; - touchscreen@26 { compatible = "ilitek,ili2117"; reg = <0x26>;@@ -482,6 +468,21 @@ hd3ss3220_out_ep: endpoint {
Quoted 8 lines
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi hd3ss3220_out_ep: endpoint { · line 473
Quoted 6 lines
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +3
-0}; }; }; + + gpio_exp1: gpio@70 { + compatible = "onnn,pca9654";According to the patch description, the actual part was changed, too?
humm.. I was under the impression it was after talking with one of the hardware developers, but clearly it's using the same compatible name. I will investigate this further. One way or the other, I'll redo the commit message.
adam
Quoted 27 lines
Quoted 4 lines
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +3
-0+ reg = <0x70>; + gpio-controller; + #gpio-cells = <2>;arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi hd3ss3220_out_ep: endpoint { · line 486
Quoted 10 lines
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +9
-0+ gpio-line-names = + "lcd_reset", + "lcd_pwr", + "lcd_select", + "backlight-enable", + "Touch_shdwn", + "LCD_H_pol", + "lcd_V_pol"; + }; };The rest LGTM.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Quoted 49 lines · Adam Ford
Quoted 46 lines · Geert Uytterhoeven
Hi Adam,
Quoted 9 lines · Adam Ford
The board used to originally introduce the Beacon Embedded RZ/G2[M/N/H] boards had a GPIO expander with address 20, but this was change when the final board went to production.
The production boards changed both the part itself and the address. With the incorrect address, the LCD cannot come up. If the LCD fails, the rcar-du driver fails to come up, and that also breaks HDMI.
Quoted 6 lines
Pre-release board were not shipped to the general public, so it should be safe to push this as a fix. Anyone with a production board would have video fail due to this GPIO expander change.
Fixes a1d8a344f1ca ("arm64: dts: renesas: Introduce r8a774a1-beacon-rzg2m-kit")Signed-off-by Adam Ford <[email protected]>Thanks for your patch!
Quoted 24 lines
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +0
-14@@ -437,20 +437,6 @@ wm8962_endpoint: endpoint { }; }; - /* 0 - lcd_reset */ - /* 1 - lcd_pwr */ - /* 2 - lcd_select */ - /* 3 - backlight-enable */ - /* 4 - Touch_shdwn */ - /* 5 - LCD_H_pol */ - /* 6 - lcd_V_pol */ - gpio_exp1: gpio@20 { - compatible = "onnn,pca9654"; - reg = <0x20>; - gpio-controller; - #gpio-cells = <2>; - }; - touchscreen@26 { compatible = "ilitek,ili2117"; reg = <0x26>;@@ -482,6 +468,21 @@ hd3ss3220_out_ep: endpoint {
Quoted 8 lines
Quoted 8 lines
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi hd3ss3220_out_ep: endpoint { · line 473
Quoted 6 lines
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +3
-0}; }; }; + + gpio_exp1: gpio@70 { + compatible = "onnn,pca9654";According to the patch description, the actual part was changed, too?
After a bit of some investigation, the part was changed to nxp,pca9538. It appears to be the same driver and the same ".data" structure is used. This probably explains why I didn't see any issues when I was testing this. Unfortunately, the hardware engineer who made this hardware change is not around to ask why the change was
made. I'll do a V2 since, I don't see this in renesas-devel.
adam
Quoted 34 lines
humm.. I was under the impression it was after talking with one of the hardware developers, but clearly it's using the same compatible name. I will investigate this further. One way or the other, I'll redo the commit message.
adam
Quoted 27 lines
Quoted 4 lines
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +3
-0+ reg = <0x70>; + gpio-controller; + #gpio-cells = <2>;arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi hd3ss3220_out_ep: endpoint { · line 486
Quoted 10 lines
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +9
-0+ gpio-line-names = + "lcd_reset", + "lcd_pwr", + "lcd_select", + "backlight-enable", + "Touch_shdwn", + "LCD_H_pol", + "lcd_V_pol"; + }; };The rest LGTM.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Hi Adam,
Quoted 53 lines · Adam Ford
Quoted 43 lines · Adam Ford
Quoted 41 lines · Geert Uytterhoeven
Quoted 40 lines · Adam Ford
The board used to originally introduce the Beacon Embedded RZ/G2[M/N/H] boards had a GPIO expander with address 20, but this was change when the final board went to production.
The production boards changed both the part itself and the address. With the incorrect address, the LCD cannot come up. If the LCD fails, the rcar-du driver fails to come up, and that also breaks HDMI.
Pre-release board were not shipped to the general public, so it should be safe to push this as a fix. Anyone with a production board would have video fail due to this GPIO expander change.
Fixes a1d8a344f1ca ("arm64: dts: renesas: Introduce r8a774a1-beacon-rzg2m-kit")Signed-off-by Adam Ford <[email protected]>arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +0
-14@@ -437,20 +437,6 @@ wm8962_endpoint: endpoint { }; }; - /* 0 - lcd_reset */ - /* 1 - lcd_pwr */ - /* 2 - lcd_select */ - /* 3 - backlight-enable */ - /* 4 - Touch_shdwn */ - /* 5 - LCD_H_pol */ - /* 6 - lcd_V_pol */ - gpio_exp1: gpio@20 { - compatible = "onnn,pca9654"; - reg = <0x20>; - gpio-controller; - #gpio-cells = <2>; - }; - touchscreen@26 { compatible = "ilitek,ili2117"; reg = <0x26>;@@ -482,6 +468,21 @@ hd3ss3220_out_ep: endpoint {Quoted 8 lines
Quoted 8 lines
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi hd3ss3220_out_ep: endpoint { · line 473
Quoted 6 lines
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +3
-0}; }; }; + + gpio_exp1: gpio@70 { + compatible = "onnn,pca9654";According to the patch description, the actual part was changed, too?
Quoted 6 lines
After a bit of some investigation, the part was changed to nxp,pca9538. It appears to be the same driver and the same ".data" structure is used. This probably explains why I didn't see any issues when I was testing this. Unfortunately, the hardware engineer who made this hardware change is not around to ask why the change was made.
Yeah, there are lots of compatible parts.
Quoted 1 line
I'll do a V2 since, I don't see this in renesas-devel.
Correct, I was waiting for clarification.
Looking forward to v2...
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds