mdadm/udev: Don't handle change event on raw devices
PATCH v2 1/1 mdadm/udev: Don't handle change event on raw devices
The raw devices are ready when add event happpens and the raid can be assembled. So there is no need to handle change events. And it can cause some inconvenient problems.
For example, the OS is installed on md0(/root) and md1(/home). md0 and md1 are created on partitions. When it wants to re-install OS, anaconda can't clear the storage configure. It deletes one partition and does some jobs. The change event happens. Now the raid device is assembled again. It can't delete the other partitions.
So in this patch, we don't handle change event on raw devices anymore.
--- udev-md-raid-assembly.rules | 8 ++++++++ 1 file changed, 8 insertions(+)
udev-md-raid-assembly.rules +8 -0
@@ -11,6 +11,11 @@ SUBSYSTEM!="block", GOTO="md_inc_end" ENV{SYSTEMD_READY}=="0", GOTO="md_inc_end" # handle potential components of arrays (the ones supported by md) +# For member devices which are md/dm devices, we don't need to +# handle add event. Because md/dm devices need to do some init jobs. +# Then the change event happens. +# When adding md/dm devices, ID_FS_TYPE can only be linux_raid_member +# after change event happens. ENV{ID_FS_TYPE}=="linux_raid_member", GOTO="md_inc" # "noiswmd" on kernel command line stops mdadm from handling
@@ -28,6 +33,9 @@ GOTO="md_inc_end" LABEL="md_inc" +# Bare disks are ready when add event happens, the raid can be assembled. +ACTION=="change", KERNEL!="dm-*|md*", GOTO="md_inc_end" + # remember you can limit what gets auto/incrementally assembled by # mdadm.conf(5)'s 'AUTO' and selectively whitelist using 'ARRAY' ACTION!="remove", IMPORT{program}="BINDIR/mdadm --incremental --export $devnode --offroot $env{DEVLINKS}"
Signature · 1 line
2.32.0 (Apple Git-132)
Jes Sorensen
AppliedQuoted 11 lines · Xiao Ni
The raw devices are ready when add event happpens and the raid can be assembled. So there is no need to handle change events. And it can cause some inconvenient problems.
For example, the OS is installed on md0(/root) and md1(/home). md0 and md1 are created on partitions. When it wants to re-install OS, anaconda can't clear the storage configure. It deletes one partition and does some jobs. The change event happens. Now the raid device is assembled again. It can't delete the other partitions.
Quoted 7 lines
So in this patch, we don't handle change event on raw devices anymore.
Signed-off-by Xiao Ni <[email protected]>--- udev-md-raid-assembly.rules | 8 ++++++++ 1 file changed, 8 insertions(+)
Applied!
Thanks,
Jes