dt-bindings: Add a cpu-capacity property for RISC-V
Subsystems (4)
cover dt-bindings: Add a cpu-capacity property for RISC-V
From: Conor Dooley <[email protected]>
Hey,
Ever since RISC-V starting using generic arch topology code, the code paths for cpu-capacity have been there but there's no binding defined to actually convey the information. Defining the same property as used on arm seems to be the only logical thing to do, so do it.
It's worth noting that right now, actually putting this property in a DT will cause allocation failures on RISC-V - but there's already a patch for that thanks to Ley Foon Tan:
https://patchwork.kernel.org/project/linux-riscv/patch/[email protected]/
Thanks,
Conor.
Conor Dooley (2):
dt-bindings: arm: move cpu-capacity to a shared loation
dt-bindings: riscv: add a capacity-dmips-mhz cpu property
Documentation/devicetree/bindings/arm/cpus.yaml | 2 +-
.../devicetree/bindings/{arm => cpu}/cpu-capacity.txt | 4 ++--
Documentation/devicetree/bindings/riscv/cpus.yaml | 6 ++++++
Documentation/scheduler/sched-capacity.rst | 2 +-
.../translations/zh_CN/scheduler/sched-capacity.rst | 2 +-
5 files changed, 11 insertions(+), 5 deletions(-)
rename Documentation/devicetree/bindings/{arm => cpu}/cpu-capacity.txt (98%)Signature · 1 line
2.39.0
PATCH 1/2 dt-bindings: arm: move cpu-capacity to a shared loation
From: Conor Dooley <[email protected]>
RISC-V uses the same generic topology code as arm64 & while there currently exists no binding for cpu-capacity on RISC-V, the code paths can be hit if the property is present.
Move the documentation of cpu-capacity to a shared location, ahead of defining a binding for capacity-dmips-mhz on RISC-V. Update some references to this document in the process.
---
I wasn't sure what to do with reference [1], but since the property will be the same on RISC-V, I left it as is.
---
Documentation/devicetree/bindings/arm/cpus.yaml | 2 +-
.../devicetree/bindings/{arm => cpu}/cpu-capacity.txt | 4 ++--
Documentation/scheduler/sched-capacity.rst | 2 +-
Documentation/translations/zh_CN/scheduler/sched-capacity.rst | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
rename Documentation/devicetree/bindings/{arm => cpu}/cpu-capacity.txt (98%)Documentation/devicetree/bindings/arm/cpus.yaml +1 -1
@@ -257,7 +257,7 @@ properties: capacity-dmips-mhz: description: - u32 value representing CPU capacity (see ./cpu-capacity.txt) in + u32 value representing CPU capacity (see ../cpu/cpu-capacity.txt) in DMIPS/MHz, relative to highest capacity-dmips-mhz in the system.
Documentation/devicetree/bindings/cpu/cpu-capacity.txt renamed from Documentation/devicetree/bindings/arm/cpu-capacity.txt +2 -2
@@ -1,12 +1,12 @@ ========================================== -ARM CPUs capacity bindings +CPU capacity bindings ========================================== ========================================== 1 - Introduction ========================================== -ARM systems may be configured to have cpus with different power/performance +Some systems may be configured to have cpus with different power/performance characteristics within the same chip. In this case, additional information has to be made available to the kernel for it to be aware of such differences and take decisions accordingly.
Documentation/scheduler/sched-capacity.rst +1 -1
@@ -260,7 +260,7 @@ for that purpose. The arm and arm64 architectures directly map this to the arch_topology driver CPU scaling data, which is derived from the capacity-dmips-mhz CPU binding; see -Documentation/devicetree/bindings/arm/cpu-capacity.txt. +Documentation/devicetree/bindings/cpu/cpu-capacity.txt. 3.2 Frequency invariance ------------------------
Documentation/translations/zh_CN/scheduler/sched-capacity.rst +1 -1
@@ -233,7 +233,7 @@ CFS调度类基于实体负载跟踪机制(Per-Entity Load Tracking, PELT) arm和arm64架构直接把这个信息映射到arch_topology驱动的CPU scaling数据中(译注:参考 arch_topology.h的percpu变量cpu_scale),它是从capacity-dmips-mhz CPU binding中衍生计算 -出来的。参见Documentation/devicetree/bindings/arm/cpu-capacity.txt。 +出来的。参见Documentation/devicetree/bindings/cpu/cpu-capacity.txt。 3.2 频率不变性 --------------
Signature · 1 line
2.39.0
RE: [PATCH v1 1/2] dt-bindings: arm: move cpu-capacity to a shared loation
Quoted 9 lines
From: Conor Dooley <[email protected]>
RISC-V uses the same generic topology code as arm64 & while there currently exists no binding for cpu-capacity on RISC-V, the code paths can be hit if the property is present.
Quoted 5 lines
Move the documentation of cpu-capacity to a shared location, ahead of defining a binding for capacity-dmips-mhz on RISC-V. Update some references to this document in the process.
Signed-off-by Conor Dooley <[email protected]>
Hi Conor
I plan to move cpu-capacity.txt binding to generic directory as well after [1]. Thanks for your patch series helping this.
[1] https://patchwork.kernel.org/project/linux-riscv/patch/[email protected]/
Regards
Ley Foon
Re: [PATCH v1 1/2] dt-bindings: arm: move cpu-capacity to a shared loation
In reply to Conor DooleyQuoted 14 lines · Conor Dooley
From: Conor Dooley <[email protected]>
RISC-V uses the same generic topology code as arm64 & while there currently exists no binding for cpu-capacity on RISC-V, the code paths can be hit if the property is present.
Move the documentation of cpu-capacity to a shared location, ahead of defining a binding for capacity-dmips-mhz on RISC-V. Update some references to this document in the process.
Signed-off-by Conor Dooley <[email protected]>---
I wasn't sure what to do with reference [1], but since the property will be the same on RISC-V, I left it as is.
Quoted 8 lines
---
Documentation/devicetree/bindings/arm/cpus.yaml | 2 +-
.../devicetree/bindings/{arm => cpu}/cpu-capacity.txt | 4 ++--
Documentation/scheduler/sched-capacity.rst | 2 +-
Documentation/translations/zh_CN/scheduler/sched-capacity.rst | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
rename Documentation/devicetree/bindings/{arm => cpu}/cpu-capacity.txt (98%)Re: [PATCH v1 1/2] dt-bindings: arm: move cpu-capacity to a shared loation
In reply to Conor DooleyQuoted 11 lines · Conor Dooley
From: Conor Dooley <[email protected]>
RISC-V uses the same generic topology code as arm64 & while there currently exists no binding for cpu-capacity on RISC-V, the code paths can be hit if the property is present.
Move the documentation of cpu-capacity to a shared location, ahead of defining a binding for capacity-dmips-mhz on RISC-V. Update some references to this document in the process.
Signed-off-by Conor Dooley <[email protected]>
Quoted 64 lines
---
I wasn't sure what to do with reference [1], but since the property will be the same on RISC-V, I left it as is.--- Documentation/devicetree/bindings/arm/cpus.yaml | 2 +- .../devicetree/bindings/{arm => cpu}/cpu-capacity.txt | 4 ++-- Documentation/scheduler/sched-capacity.rst | 2 +- Documentation/translations/zh_CN/scheduler/sched-capacity.rst | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-)rename
Documentation/devicetree/bindings/{arm=>cpu}/cpu-capacity.txt(98%)Documentation/devicetree/bindings/arm/cpus.yaml +1
-1@@ -257,7 +257,7 @@ properties: capacity-dmips-mhz: description: - u32 value representing CPU capacity (see ./cpu-capacity.txt) in + u32 value representing CPU capacity (see ../cpu/cpu-capacity.txt) in DMIPS/MHz, relative to highest capacity-dmips-mhz in the system.Documentation/devicetree/bindings/cpu/cpu-capacity.txt renamed from Documentation/devicetree/bindings/arm/cpu-capacity.txt +2
-2@@ -1,12 +1,12 @@ ========================================== -ARM CPUs capacity bindings +CPU capacity bindings ========================================== ========================================== 1 - Introduction ========================================== -ARM systems may be configured to have cpus with different power/performance +Some systems may be configured to have cpus with different power/performance characteristics within the same chip. In this case, additional information has to be made available to the kernel for it to be aware of such differences and take decisions accordingly.Documentation/scheduler/sched-capacity.rst +1
-1@@ -260,7 +260,7 @@ for that purpose. The arm and arm64 architectures directly map this to the arch_topology driver CPU scaling data, which is derived from the capacity-dmips-mhz CPU binding; see -Documentation/devicetree/bindings/arm/cpu-capacity.txt. +Documentation/devicetree/bindings/cpu/cpu-capacity.txt. 3.2 Frequency invariance ------------------------Documentation/translations/zh_CN/scheduler/sched-capacity.rst +0
-0
Documentation/translations/zh_CN/scheduler/sched-capacity.rst CFS调度类基于实体负载跟踪机制(Per-Entity Load Tracking, PELT) · line 239
Quoted 8 lines
Documentation/translations/zh_CN/scheduler/sched-capacity.rst +1
-1@@ -233,7 +233,7 @@ CFS调度类基于实体负载跟踪机制(Per-Entity Load Tracking, PELT) arm和arm64架构直接把这个信息映射到arch_topology驱动的CPU scaling数据中(译注:参考 arch_topology.h的percpu变量cpu_scale),它是从capacity-dmips-mhz CPU binding中衍生计算 -出来的。参见Documentation/devicetree/bindings/arm/cpu-capacity.txt。 +出来的。参见Documentation/devicetree/bindings/cpu/cpu-capacity.txt。 3.2 频率不变性 --------------
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
PATCH 2/2 dt-bindings: riscv: add a capacity-dmips-mhz cpu property
In reply to Conor DooleyFrom: Conor Dooley <[email protected]>
Since commit 03f11f03dbfe ("RISC-V: Parse cpu topology during boot.") RISC-V has used the generic arch topology code, which provides for disparate CPU capacities. We never defined a binding to acquire this information from the DT though, so document the one already used by the generic arch topology code: "capacity-dmips-mhz".
--- Documentation/devicetree/bindings/riscv/cpus.yaml | 6 ++++++ 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/riscv/cpus.yaml +6 -0
@@ -114,6 +114,12 @@ properties: List of phandles to idle state nodes supported by this hart (see ./idle-states.yaml). + capacity-dmips-mhz: + description: + u32 value representing CPU capacity (see ../cpu/cpu-capacity.txt) in + DMIPS/MHz, relative to highest capacity-dmips-mhz + in the system. + required: - riscv,isa - interrupt-controller
Signature · 1 line
2.39.0
RE: [PATCH v1 2/2] dt-bindings: riscv: add a capacity-dmips-mhz cpu property
Quoted 36 lines
-----Original Message-----
From: Conor Dooley <[email protected]>
Since commit
03f11f03dbfe("RISC-V: Parse cpu topology during boot.") RISC- V has used the generic arch topology code, which provides for disparate CPU capacities. We never defined a binding to acquire this information from the DT though, so document the one already used by the generic arch topology
code: "capacity-dmips-mhz".Signed-off-by Conor Dooley <[email protected]>--- Documentation/devicetree/bindings/riscv/cpus.yaml | 6 ++++++ 1 file changed, 6 insertions(+)Documentation/devicetree/bindings/riscv/cpus.yaml +6
-1@@ -114,6 +114,12 @@ properties: List of phandles to idle state nodes supported by this hart (see ./idle-states.yaml). + capacity-dmips-mhz: + description: + u32 value representing CPU capacity (see ../cpu/cpu-capacity.txt) in + DMIPS/MHz, relative to highest capacity-dmips-mhz + in the system. + required: - riscv,isa - interrupt-controller --
Quoted 1 line
2.39.0
Thanks Conor.
Regards
Ley Foon
Re: [PATCH v1 2/2] dt-bindings: riscv: add a capacity-dmips-mhz cpu property
In reply to Conor DooleyQuoted 8 lines · Conor Dooley
From: Conor Dooley <[email protected]>
Since commit
03f11f03dbfe("RISC-V: Parse cpu topology during boot.") RISC-V has used the generic arch topology code, which provides for disparate CPU capacities. We never defined a binding to acquire this information from the DT though, so document the one already used by the generic arch topology code: "capacity-dmips-mhz".
Quoted 5 lines
Signed-off-by Conor Dooley <[email protected]>--- Documentation/devicetree/bindings/riscv/cpus.yaml | 6 ++++++ 1 file changed, 6 insertions(+)
Palmer Dabbelt
AppliedQuoted 10 lines · Conor Dooley
From: Conor Dooley <[email protected]>
Hey,
Ever since RISC-V starting using generic arch topology code, the code paths for cpu-capacity have been there but there's no binding defined to actually convey the information. Defining the same property as used on arm seems to be the only logical thing to do, so do it.
[...]
Applied, thanks!
[1/2] dt-bindings: arm: move cpu-capacity to a shared loation
https://git.kernel.org/palmer/c/7d2078310cbf [2/2] dt-bindings: riscv: add a capacity-dmips-mhz cpu property https://git.kernel.org/palmer/c/991994509ee9
Best regards,
Signature · 6 lines
Palmer Dabbelt <[email protected]> _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
This series was applied to riscv/linux.git (for-next) by Palmer Dabbelt <[email protected]>:
Hello:
This series was applied to riscv/linux.git (for-next) by Palmer Dabbelt <[email protected]>:
Quoted 10 lines · On Wed, 4 Jan 2023 18:05:12 +0000 you wrote:
From: Conor Dooley <[email protected]>
Hey,
Ever since RISC-V starting using generic arch topology code, the code paths for cpu-capacity have been there but there's no binding defined to actually convey the information. Defining the same property as used on arm seems to be the only logical thing to do, so do it.
[...]
Here is the summary with links:
- [v1,1/2] dt-bindings: arm: move cpu-capacity to a shared loation
https://git.kernel.org/riscv/c/7d2078310cbf - [v1,2/2] dt-bindings: riscv: add a capacity-dmips-mhz cpu property https://git.kernel.org/riscv/c/991994509ee9
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html