mm/page_alloc: invert logic for early page initialisation checks
Subsystems (2)
PATCH 1/1 mm/page_alloc: invert logic for early page initialisation checks
From: "Mike Rapoport (IBM)" <[email protected]>
Rename early_page_uninitialised() to early_page_initialised() and invert its logic to make the code more readable.
Signed-off-by Mike Rapoport (IBM) <[email protected]>
--- mm/page_alloc.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
mm/page_alloc.c +8 -8
@@ -443,15 +443,15 @@ static inline bool deferred_pages_enabled(void)return static_branch_unlikely (&deferred_pages); } -/* Returns true if the struct page for the pfn is uninitialised */ -static inline bool __meminit early_page_uninitialised (unsigned long pfn) +/* Returns true if the struct page for the pfn is initialised */ +static inline bool __meminit early_page_initialised (unsigned long pfn) {int nid =early_pfn_to_nid (pfn);if (node_online (nid) && pfn >=NODE_DATA (nid)->first_deferred_pfn) -return true; +return false; -return false; +return true; }/*
@@ -498,9 +498,9 @@ static inline bool deferred_pages_enabled(void)return false; } -static inline bool early_page_uninitialised (unsigned long pfn) +static inline bool early_page_initialised (unsigned long pfn) { -return false; +return true; }static inline bool defer_init (int nid,unsigned long pfn,unsigned long end_pfn)
@@ -1641,7 +1641,7 @@ static void __meminit init_reserved_page(unsigned long pfn)pg_data_t *pgdat;int nid, zid; -if (!early_page_uninitialised (pfn)) +if (early_page_initialised (pfn))return ; nid =early_pfn_to_nid (pfn);
@@ -1804,7 +1804,7 @@ int __meminit early_pfn_to_nid(unsigned long pfn)void __init memblock_free_pages (struct page *page,unsigned long pfn,unsigned int order) { -if (early_page_uninitialised (pfn)) +if (!early_page_initialised (pfn))return ;if (!kmsan_memblock_free_pages (page, order)) {/* KMSAN will take care of these pages. */
Signature · 1 line
2.35.1
Quoted 7 lines · Mike Rapoport
From: "Mike Rapoport (IBM)" <[email protected]>
Rename
early_page_uninitialised()toearly_page_initialised()and invert its logic to make the code more readable.Signed-off-by Mike Rapoport (IBM) <[email protected]>---
LGTM
Reviewed-by Anshuman Khandual <[email protected]>
Quoted 57 lines
mm/page_alloc.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)mm/page_alloc.c +8
-8@@ -443,15 +443,15 @@ static inline bool deferred_pages_enabled(void)return static_branch_unlikely (&deferred_pages); } -/* Returns true if the struct page for the pfn is uninitialised */ -static inline bool __meminit early_page_uninitialised (unsigned long pfn) +/* Returns true if the struct page for the pfn is initialised */ +static inline bool __meminit early_page_initialised (unsigned long pfn) {int nid =early_pfn_to_nid (pfn);if (node_online (nid) && pfn >=NODE_DATA (nid)->first_deferred_pfn) -return true; +return false; -return false; +return true; }/* @@ -498,9 +498,9 @@ static inline bool deferred_pages_enabled(void)return false; } -static inline bool early_page_uninitialised (unsigned long pfn) +static inline bool early_page_initialised (unsigned long pfn) { -return false; +return true; }static inline bool defer_init (int nid,unsigned long pfn,unsigned long end_pfn)@@ -1641,7 +1641,7 @@ static void __meminit init_reserved_page(unsigned long pfn)pg_data_t *pgdat;int nid, zid; -if (!early_page_uninitialised (pfn)) +if (early_page_initialised (pfn))return ; nid =early_pfn_to_nid (pfn);@@ -1804,7 +1804,7 @@ int __meminit early_pfn_to_nid(unsigned long pfn)void __init memblock_free_pages (struct page *page,unsigned long pfn,unsigned int order) { -if (early_page_uninitialised (pfn)) +if (!early_page_initialised (pfn))return ;if (!kmsan_memblock_free_pages (page, order)) {/* KMSAN will take care of these pages. */
Quoted 6 lines · Mike Rapoport
From: "Mike Rapoport (IBM)" <[email protected]>
Rename
early_page_uninitialised()toearly_page_initialised()and invert its logic to make the code more readable.Signed-off-by Mike Rapoport (IBM) <[email protected]>
Reviewed-by David Hildenbrand <[email protected]>
Signature · 3 lines
Thanks, David / dhildenb
Quoted 6 lines · Mike Rapoport
From: "Mike Rapoport (IBM)" <[email protected]>
Rename
early_page_uninitialised()toearly_page_initialised()and invert its logic to make the code more readable.Signed-off-by Mike Rapoport (IBM) <[email protected]>
Acked-by Mel Gorman <[email protected]>
Signature · 2 lines
Mel Gorman SUSE Labs