Skip to contentSkip to conversation

mm: fix vma->anon_name memory leak for anonymous shmem VMAs

PATCH Applied Suren Baghdasaryan 4 participants 7 messages Jan 5, 2023

Subsystems (4)
lore
Share & tools
lore

Suren Baghdasaryan

author reviewer
#0 lore raw

PATCH v2 1/1 mm: fix vma->anon_name memory leak for anonymous shmem VMAs

free_anon_vma_name() is missing a check for anonymous shmem VMA which leads to a memory leak due to refcount not being dropped. Fix this by calling anon_vma_name_put() unconditionally. It will free vma->anon_name whenever it's non-NULL.

Fixes d09e8ca6cb93 ("mm: anonymous shared memory naming")
Reported-by [email protected]
Cc David Hildenbrand <[email protected]>
Cc Hugh Dickins <[email protected]>
Cc Pasha Tatashin <[email protected]>

---
applies over mm-hotfixes-unstable branch of
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm tree after reverting the original version of this patch.

 include/linux/mm_inline.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
include/linux/mm_inline.h +1 -2
index e8ed225d8f7c..ff3f3f23f649 100644
@@ -413,8 +413,7 @@ static inline void free_anon_vma_name(struct vm_area_struct *vma)
 	 * Not using anon_vma_name because it generates a warning if mmap_lock
 	 * is not held, which might be the case here.
 	 */
-	if (!vma->vm_file)
-		anon_vma_name_put(vma->anon_name);
+	anon_vma_name_put(vma->anon_name);
 }
 
 static inline bool anon_vma_name_eq(struct anon_vma_name *anon_name1,
Signature · 1 line
2.39.0.314.g84b9a713c41-goog
maintainer
#1 lore raw
Quoted 6 lines · On Wed, 4 Jan 2023 16:02:40 -0800 Suren Baghdasaryan <[email protected]> wrote:

free_anon_vma_name() is missing a check for anonymous shmem VMA which leads to a memory leak due to refcount not being dropped. Fix this by calling anon_vma_name_put() unconditionally. It will free vma->anon_name whenever it's non-NULL.

Fixes d09e8ca6cb93 ("mm: anonymous shared memory naming")

A cc:stable is appropriate here, yes?

author reviewer
#2 lore raw
Quoted 11 lines · Andrew Morton
Quoted 6 lines · On Wed, 4 Jan 2023 16:02:40 -0800 Suren Baghdasaryan <[email protected]> wrote:

free_anon_vma_name() is missing a check for anonymous shmem VMA which leads to a memory leak due to refcount not being dropped. Fix this by calling anon_vma_name_put() unconditionally. It will free vma->anon_name whenever it's non-NULL.

Fixes d09e8ca6cb93 ("mm: anonymous shared memory naming")

A cc:stable is appropriate here, yes?

Hmm. The patch we are fixing here was merged in 6.2-rc1. Should I CC stable to fix the previous -rc branch?

#3 lore raw
Quoted 9 lines · Suren Baghdasaryan
Quoted 8 lines · Andrew Morton
Quoted 5 lines · On Wed, 4 Jan 2023 16:02:40 -0800 Suren Baghdasaryan <[email protected]> wrote:

free_anon_vma_name() is missing a check for anonymous shmem VMA which leads to a memory leak due to refcount not being dropped. Fix this by calling anon_vma_name_put() unconditionally. It will free vma->anon_name whenever it's non-NULL.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Fixes d09e8ca6cb93 ("mm: anonymous shared memory naming")

A cc:stable is appropriate here, yes?

Hmm. The patch we are fixing here was merged in 6.2-rc1. Should I CC stable to fix the previous -rc branch?

No need for stable if it's not in a release kernel yet.

Signature · 3 lines
Thanks,

David / dhildenb
#4 lore raw
Quoted 12 lines · David Hildenbrand
Quoted 11 lines · Suren Baghdasaryan
Quoted 10 lines · Andrew Morton
Quoted 6 lines · On Wed,  4 Jan 2023 16:02:40 -0800 Suren Baghdasaryan <[email protected]> wrote:

free_anon_vma_name() is missing a check for anonymous shmem VMA which leads to a memory leak due to refcount not being dropped.  Fix this by calling anon_vma_name_put() unconditionally. It will free vma->anon_name whenever it's non-NULL.

Fixes d09e8ca6cb93 ("mm: anonymous shared memory naming")
Quoted 7 lines
Quoted 5 lines
Quoted 1 line

A cc:stable is appropriate here, yes?

Hmm. The patch we are fixing here was merged in 6.2-rc1. Should I CC stable to fix the previous -rc branch?

No need for stable if it's not in a release kernel yet.

Commit d09e8ca6cb93 is in 6.1. The fix applies cleanly.

cheers
Holger

#5 lore raw
Quoted 15 lines · Holger Hoffstätte
Quoted 14 lines · David Hildenbrand
Quoted 13 lines · Suren Baghdasaryan
Quoted 11 lines · Andrew Morton
Quoted 6 lines · On Wed,  4 Jan 2023 16:02:40 -0800 Suren Baghdasaryan <[email protected]> wrote:

free_anon_vma_name() is missing a check for anonymous shmem VMA which leads to a memory leak due to refcount not being dropped.  Fix this by calling anon_vma_name_put() unconditionally. It will free vma->anon_name whenever it's non-NULL.

Fixes d09e8ca6cb93 ("mm: anonymous shared memory naming")

A cc:stable is appropriate here, yes?

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Hmm. The patch we are fixing here was merged in 6.2-rc1. Should I CC stable to fix the previous -rc branch?

No need for stable if it's not in a release kernel yet.

Commit d09e8ca6cb93 is in 6.1. The fix applies cleanly.

$ git tag --contains d09e8ca6cb93 | grep "^v"
v6.2-rc1
v6.2-rc2

Doesn't look like 6.1 to me.

Signature · 3 lines
Thanks,

David / dhildenb
Reviewed-by on v2 1/1
#6 lore raw
In reply to Suren Baghdasaryan
Quoted 5 lines · Suren Baghdasaryan

free_anon_vma_name() is missing a check for anonymous shmem VMA which leads to a memory leak due to refcount not being dropped. Fix this by calling anon_vma_name_put() unconditionally. It will free vma->anon_name whenever it's non-NULL.

Quoted 7 lines
Fixes d09e8ca6cb93 ("mm: anonymous shared memory naming")
Reported-by [email protected]
Cc David Hildenbrand <[email protected]>
Cc Hugh Dickins <[email protected]>
Cc Pasha Tatashin <[email protected]>
Signature · 3 lines
Thanks,

David / dhildenb