Skip to contentSkip to conversation

drm/vc4: Start console with 32 bpp / 24 depth

PATCH In review Thomas Zimmermann 2 participants 4 messages Jan 5, 2023

Subsystems (3)
lore
Share & tools
lore

Thomas Zimmermann

author maintainer
#0 lore raw

PATCH 1/1 drm/vc4: Start console with 32 bpp / 24 depth

Invoke the generic console emulation with a 32 bits per pixel. The preferred color depth is 24, so the current value of 16 bpp is too small. This results in the following error message

vc4-drm gpu: [drm] bpp/depth value of 16/24 not supported vc4-drm gpu: [drm] No compatible format found

------------[ cut here ]------------
WARNING: CPU: 2 PID: 66 at drivers/gpu/drm/drm_atomic.c:1604 __drm_atomic_helper_set_config+0x2e8/0x314 [drm]

The problem has been present for a long, but has only now surfaced as commit 37c90d589dc0 ("drm/fb-helper: Fix single-probe color-format selection") attempts to improve selection of the color format.

See [1] for the initial bug report.

Fixes 37c90d589dc0 ("drm/fb-helper: Fix single-probe color-format selection")
Cc Thomas Zimmermann <[email protected]>
Cc Javier Martinez Canillas <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Maxime Ripard <[email protected]>
---
 drivers/gpu/drm/vc4/vc4_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/vc4/vc4_drv.c +1 -1
index 0ccaee57fe9a..64423b79982f 100644
@@ -387,7 +387,7 @@ static int vc4_drm_bind(struct device *dev)
 	if (ret < 0)
 		goto unbind_all;
 
-	drm_fbdev_generic_setup(drm, 16);
+	drm_fbdev_generic_setup(drm, 32);
 
 	return 0;
 
Signature · 1 line
2.39.0
author maintainer
#1 lore raw

Am 05.01.23 um 09:07 schrieb Thomas Zimmermann:

Quoted 10 lines

Invoke the generic console emulation with a 32 bits per pixel. The preferred color depth is 24, so the current value of 16 bpp is too small. This results in the following error message

vc4-drm gpu: [drm] bpp/depth value of 16/24 not supported vc4-drm gpu: [drm] No compatible format found

------------[ cut here ]------------
WARNING: CPU: 2 PID: 66 at drivers/gpu/drm/drm_atomic.c:1604 __drm_atomic_helper_set_config+0x2e8/0x314 [drm]

The problem has been present for a long, but has only now surfaced

'for a long time'

Quoted 31 lines

as commit 37c90d589dc0 ("drm/fb-helper: Fix single-probe color-format selection") attempts to improve selection of the color format.

See [1] for the initial bug report.

Fixes 37c90d589dc0 ("drm/fb-helper: Fix single-probe color-format selection")
Cc Thomas Zimmermann <[email protected]>
Cc Javier Martinez Canillas <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Maxime Ripard <[email protected]>
---
  drivers/gpu/drm/vc4/vc4_drv.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/vc4/vc4_drv.c +1 -1
index 0ccaee57fe9a..64423b79982f 100644
@@ -387,7 +387,7 @@ static int vc4_drm_bind(struct device *dev)
  	if (ret < 0)
  		goto unbind_all;
 
-	drm_fbdev_generic_setup(drm, 16);
+	drm_fbdev_generic_setup(drm, 32);
 
  	return 0;
 
Signature · 6 lines
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
#2 lore raw
In reply to Thomas Zimmermann

Hi,

Quoted 33 lines · Thomas Zimmermann

Invoke the generic console emulation with a 32 bits per pixel. The preferred color depth is 24, so the current value of 16 bpp is too small. This results in the following error message

vc4-drm gpu: [drm] bpp/depth value of 16/24 not supported vc4-drm gpu: [drm] No compatible format found

------------[ cut here ]------------
WARNING: CPU: 2 PID: 66 at drivers/gpu/drm/drm_atomic.c:1604 __drm_atomic_helper_set_config+0x2e8/0x314 [drm]

The problem has been present for a long, but has only now surfaced as commit 37c90d589dc0 ("drm/fb-helper: Fix single-probe color-format selection") attempts to improve selection of the color format.

See [1] for the initial bug report.

Fixes 37c90d589dc0 ("drm/fb-helper: Fix single-probe color-format selection")
Cc Thomas Zimmermann <[email protected]>
Cc Javier Martinez Canillas <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Maxime Ripard <[email protected]>
---
 drivers/gpu/drm/vc4/vc4_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/vc4/vc4_drv.c +0 -0
index 0ccaee57fe9a..64423b79982f 100644

drivers/gpu/drm/vc4/vc4_drv.c static int vc4_drm_bind(struct device *dev) · line 390

Quoted 5 lines
drivers/gpu/drm/vc4/vc4_drv.c +1 -1
@@ -387,7 +387,7 @@ static int vc4_drm_bind(struct device *dev)
 	if (ret < 0)
 		goto unbind_all;
 
-	drm_fbdev_generic_setup(drm, 16);
+	drm_fbdev_generic_setup(drm, 32);

This is essentially a revert of f741b28fb299.

It's not clear to me what sets the depth preference to 24, because I'd rather change that.

Maxime

author maintainer
#3 lore raw

Hi

Am 05.01.23 um 09:36 schrieb Maxime Ripard:

Quoted 39 lines

Hi,

Quoted 36 lines · Thomas Zimmermann

Invoke the generic console emulation with a 32 bits per pixel. The preferred color depth is 24, so the current value of 16 bpp is too small. This results in the following error message

vc4-drm gpu: [drm] bpp/depth value of 16/24 not supported vc4-drm gpu: [drm] No compatible format found

------------[ cut here ]------------
WARNING: CPU: 2 PID: 66 at drivers/gpu/drm/drm_atomic.c:1604 __drm_atomic_helper_set_config+0x2e8/0x314 [drm]

The problem has been present for a long, but has only now surfaced as commit 37c90d589dc0 ("drm/fb-helper: Fix single-probe color-format selection") attempts to improve selection of the color format.

See [1] for the initial bug report.

Fixes 37c90d589dc0 ("drm/fb-helper: Fix single-probe color-format selection")
Cc Thomas Zimmermann <[email protected]>
Cc Javier Martinez Canillas <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Maxime Ripard <[email protected]>
---
  drivers/gpu/drm/vc4/vc4_drv.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/vc4/vc4_drv.c +0 -0
index 0ccaee57fe9a..64423b79982f 100644
@@ -387,7 +387,7 @@ static int vc4_drm_bind(struct device *dev)
  	if (ret < 0)
  		goto unbind_all;
 
Quoted 7 lines

drivers/gpu/drm/vc4/vc4_drv.c static int vc4_drm_bind(struct device *dev) · line 390

Quoted 2 lines
drivers/gpu/drm/vc4/vc4_drv.c +1 -1
-	drm_fbdev_generic_setup(drm, 16);
+	drm_fbdev_generic_setup(drm, 32);

This is essentially a revert of f741b28fb299.

It's not clear to me what sets the depth preference to 24, because I'd rather change that.

I see. We should reduce the preferred color depth to 16 then. [1]

Best regards
Thomas

[1] https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/vc4/vc4_kms.c#L1048

Quoted 2 lines

Maxime

Signature · 6 lines
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev