udf: remove redundant variable netype
Subsystems (2)
PATCH 1/1 udf: remove redundant variable netype
The variable netype is assigned a value that is never read, the assignment is redundant the variable can be removed.
Cleans up clang scan-build warning:fs/exfat/dir.c:1012:5: warning: Value stored to 'step' is never read
Signed-off-by Colin Ian King <[email protected]>
--- fs/udf/truncate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/udf/truncate.c +2 -2
@@ -125,7 +125,7 @@ void udf_discard_prealloc(struct inode *inode)struct kernel_lb_addr eloc;uint32_t elen;uint64_t lbcount =0 ; -int8_t etype =-1 , netype; +int8_t etype =-1 ;struct udf_inode_info *iinfo =UDF_I (inode);int bsize =1 << inode->i_blkbits;
@@ -136,7 +136,7 @@ void udf_discard_prealloc(struct inode *inode) epos.block = iinfo->i_location;/* Find the last extent in the file */ -while ((netype =udf_next_aext (inode, &epos, &eloc, &elen,0 )) !=-1 ) { +while (udf_next_aext (inode, &epos, &eloc, &elen,0 ) !=-1 ) {brelse (prev_epos.bh); prev_epos = epos;if (prev_epos.bh)
Signature · 1 line
2.30.2
Quoted 7 lines · Colin Ian King
The variable netype is assigned a value that is never read, the assignment is redundant the variable can be removed.
Cleans up clang scan-build warning:
fs/exfat/dir.c:1012:5: warning: Value stored to 'step' is never readSigned-off-by Colin Ian King <[email protected]>
Thanks, I've added the patch to my tree. Just the warning message mentioned in the changelog is apparently from somewhere else so I've just deleted it ;).
Honza
Quoted 29 lines
--- fs/udf/truncate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)fs/udf/truncate.c +2
-2@@ -125,7 +125,7 @@ void udf_discard_prealloc(struct inode *inode)struct kernel_lb_addr eloc;uint32_t elen;uint64_t lbcount =0 ; -int8_t etype =-1 , netype; +int8_t etype =-1 ;struct udf_inode_info *iinfo =UDF_I (inode);int bsize =1 << inode->i_blkbits;@@ -136,7 +136,7 @@ void udf_discard_prealloc(struct inode *inode) epos.block = iinfo->i_location;/* Find the last extent in the file */ -while ((netype =udf_next_aext (inode, &epos, &eloc, &elen,0 )) !=-1 ) { +while (udf_next_aext (inode, &epos, &eloc, &elen,0 ) !=-1 ) {brelse (prev_epos.bh); prev_epos = epos;if (prev_epos.bh)Signature · 1 line
2.30.2
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR