Skip to contentSkip to conversation

util_macros.h: Add missing insclusion

PATCH Applied Andy Shevchenko 2 participants 3 messages Jan 3, 2023 – Jan 9, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 util_macros.h: Add missing insclusion

The header is the direct user of definitions from the math.h, include it.

---
 include/linux/util_macros.h | 2 ++
 1 file changed, 2 insertions(+)
include/linux/util_macros.h +2 -0
index 72299f261b25..b641ec00be3e 100644
@@ -2,6 +2,8 @@
 #ifndef _LINUX_HELPER_MACROS_H_
 #define _LINUX_HELPER_MACROS_H_
 
+#include <linux/math.h>
+
 #define __find_closest(x, a, as, op)					\
 ({									\
 	typeof(as) __fc_i, __fc_as = (as) - 1;				\
Signature · 1 line
2.35.1
#1 lore raw
Quoted 8 lines · On Tue, 3 Jan 2023 14:19:37 +0200 Andy Shevchenko…

The header is the direct user of definitions from the math.h, include it.

...

include/linux/util_macros.h line 9

Quoted 8 lines
include/linux/util_macros.h +2 -0
@@ -2,6 +2,8 @@
 #ifndef _LINUX_HELPER_MACROS_H_
 #define _LINUX_HELPER_MACROS_H_
 
+#include <linux/math.h>
+
 #define __find_closest(x, a, as, op)					\
 ({									\
 	typeof(as) __fc_i, __fc_as = (as) - 1;				\

Does this fix any known build errors, or was it an I-noticed-this thing?

#2 lore raw
Quoted 1 line · Andrew Morton

On Tue, 3 Jan 2023 14:19:37 +0200 Andy Shevchenko <[email protected]> wrote:

...

Quoted 1 line

Does this fix any known build errors, or was it an I-noticed-this thing?

Not for my knowledge. It's rather the latter category to prevent such due to header changes.

Signature · 2 lines
With Best Regards,
Andy Shevchenko