Skip to contentSkip to conversation

netfilter: remove clusterip target

PATCH New Florian Westphal 1 participant 1 message Jan 5, 2023

Subsystems (2)
lore
Share & tools
lore

Florian Westphal

author maintainer
#0 lore raw

PATCH 1/1 netfilter: remove clusterip target

Marked as 'to be removed soon' since kernel 4.1 (2015). Functionality was superseded by the 'cluster' match, added in kernel 2.6.30 (2009).

clusterip_tg_check still has races that can give

proc_dir_entry 'ipt_CLUSTERIP/10.1.1.2' already registered

followed by a WARN splat.

Remove it instead of trying to fix this up again,

---
 .../uapi/linux/netfilter_ipv4/ipt_CLUSTERIP.h |  38 -
 net/ipv4/netfilter/Kconfig                    |  14 -
 net/ipv4/netfilter/Makefile                   |   1 -
 net/ipv4/netfilter/ipt_CLUSTERIP.c            | 929 ------------------
 4 files changed, 982 deletions(-)
 delete mode 100644 include/uapi/linux/netfilter_ipv4/ipt_CLUSTERIP.h
 delete mode 100644 net/ipv4/netfilter/ipt_CLUSTERIP.c
include/uapi/linux/netfilter_ipv4/ipt_CLUSTERIP.h deleted +0 -38
deleted file mode 100644
index ff6599494fe6..000000000000
@@ -1,38 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
-#ifndef _IPT_CLUSTERIP_H_target
-#define _IPT_CLUSTERIP_H_target
-
-#include <linux/types.h>
-#include <linux/if_ether.h>
-
-enum clusterip_hashmode {
-    CLUSTERIP_HASHMODE_SIP = 0,
-    CLUSTERIP_HASHMODE_SIP_SPT,
-    CLUSTERIP_HASHMODE_SIP_SPT_DPT,
-};
-
-#define CLUSTERIP_HASHMODE_MAX CLUSTERIP_HASHMODE_SIP_SPT_DPT
-
-#define CLUSTERIP_MAX_NODES 16
-
-#define CLUSTERIP_FLAG_NEW 0x00000001
-
-struct clusterip_config;
-
-struct ipt_clusterip_tgt_info {
-
-	__u32 flags;
-
-	/* only relevant for new ones */
-	__u8 clustermac[ETH_ALEN];
-	__u16 num_total_nodes;
-	__u16 num_local_nodes;
-	__u16 local_nodes[CLUSTERIP_MAX_NODES];
-	__u32 hash_mode;
-	__u32 hash_initval;
-
-	/* Used internally by the kernel */
-	struct clusterip_config *config;
-};
-
-#endif /*_IPT_CLUSTERIP_H_target*/
net/ipv4/netfilter/Kconfig +0 -14
index aab384126f61..f71a7e9a7de6 100644
@@ -259,20 +259,6 @@ config IP_NF_MANGLE
 
 	  To compile it as a module, choose M here.  If unsure, say N.
 
-config IP_NF_TARGET_CLUSTERIP
-	tristate "CLUSTERIP target support"
-	depends on IP_NF_MANGLE
-	depends on NF_CONNTRACK
-	depends on NETFILTER_ADVANCED
-	select NF_CONNTRACK_MARK
-	select NETFILTER_FAMILY_ARP
-	help
-	  The CLUSTERIP target allows you to build load-balancing clusters of
-	  network servers without having a dedicated load-balancing
-	  router/server/switch.
-
-	  To compile it as a module, choose M here.  If unsure, say N.
-
 config IP_NF_TARGET_ECN
 	tristate "ECN target support"
 	depends on IP_NF_MANGLE
net/ipv4/netfilter/Makefile +0 -1
index 93bad1184251..5a26f9de1ab9 100644
@@ -39,7 +39,6 @@ obj-$(CONFIG_IP_NF_MATCH_AH) += ipt_ah.o
 obj-$(CONFIG_IP_NF_MATCH_RPFILTER) += ipt_rpfilter.o
 
 # targets
-obj-$(CONFIG_IP_NF_TARGET_CLUSTERIP) += ipt_CLUSTERIP.o
 obj-$(CONFIG_IP_NF_TARGET_ECN) += ipt_ECN.o
 obj-$(CONFIG_IP_NF_TARGET_REJECT) += ipt_REJECT.o
 obj-$(CONFIG_IP_NF_TARGET_SYNPROXY) += ipt_SYNPROXY.o
net/ipv4/netfilter/ipt_CLUSTERIP.c deleted +0 -929

929 lines not on this page · raw message

Signature · 1 line
2.38.2