Skip to contentSkip to conversation

i3c: transfer pid from boardinfo to device info

PATCH Applied Jack Chen 2 participants 2 messages Jan 5, 2023 – Jan 10, 2023 I3C

lore
Share & tools
lore

Jack Chen

author
#0 lore raw

PATCH 1/1 i3c: transfer pid from boardinfo to device info

I3C device PID could be defined in device tree and stored in i3c_dev_boardinfo. It should be passed to i3c_device_info when allocating a i3c_dev_desc.
Rational behind this change is: when users decide to use SETDASA to assign a dynamic address with exactly the original static address, in step of i3c_master_reattach_i3c_dev, this address is checked to be taken. Then device information retrieving step is skipped. As a result, though the i3c device is registered correctly, its device driver could not be probed.

Tested: Tested with a I3C device. If assigned-address is set to be the device's static address, without this change, its device driver could not probed. And with this change, its driver is probed successfully.

---
 drivers/i3c/master.c | 1 +
 1 file changed, 1 insertion(+)
drivers/i3c/master.c +1 -0
index d7e6f6c99aea..4dad80338831 100644
@@ -1438,6 +1438,7 @@ static int i3c_master_early_i3c_dev_add(struct i3c_master_controller *master,
 {
 	struct i3c_device_info info = {
 		.static_addr = boardinfo->static_addr,
+		.pid = boardinfo->pid,
 	};
 	struct i3c_dev_desc *i3cdev;
 	int ret;
Signature · 1 line
2.39.0.314.g84b9a713c41-goog
maintainer Applied
#1 lore raw
Quoted 11 lines · Jack Chen

I3C device PID could be defined in device tree and stored in i3c_dev_boardinfo. It should be passed to i3c_device_info when allocating a i3c_dev_desc.
Rational behind this change is: when users decide to use SETDASA to assign a dynamic address with exactly the original static address, in step of i3c_master_reattach_i3c_dev, this address is checked to be taken. Then device information retrieving step is skipped. As a result, though the i3c device is registered correctly, its device driver could not be probed.

[...]

Applied, thanks!

[1/1] i3c: transfer pid from boardinfo to device info

      commit: e826acc18bc7bdf4278bf8928caa3a0cd4065432

Best regards,

Signature · 8 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

-- 
linux-i3c mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-i3c